diff mbox series

[v1] ALSA: usb-audio: Use kmemdup_array instead of kmemdup for multiple allocation

Message ID 20240826043454.3198-1-shenlichuan@vivo.com (mailing list archive)
State New
Headers show
Series [v1] ALSA: usb-audio: Use kmemdup_array instead of kmemdup for multiple allocation | expand

Commit Message

Shen Lichuan Aug. 26, 2024, 4:34 a.m. UTC 
Let the kmemdup_array() take care about multiplication
and possible overflows.

Using kmemdup_array() is more appropriate and makes the code
easier to audit.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
 sound/usb/quirks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Takashi Iwai Aug. 26, 2024, 8:32 a.m. UTC | #1 
On Mon, 26 Aug 2024 06:34:54 +0200,
Shen Lichuan wrote:
> 
> Let the kmemdup_array() take care about multiplication
> and possible overflows.
> 
> Using kmemdup_array() is more appropriate and makes the code
> easier to audit.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>

Thanks, applied now.


Takashi
diff mbox series

Patch

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index e7b68c67852e..53c69f3069c4 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -167,8 +167,8 @@  static int create_fixed_stream_quirk(struct snd_usb_audio *chip,
 		return -EINVAL;
 	}
 	if (fp->nr_rates > 0) {
-		rate_table = kmemdup(fp->rate_table,
-				     sizeof(int) * fp->nr_rates, GFP_KERNEL);
+		rate_table = kmemdup_array(fp->rate_table, fp->nr_rates, sizeof(int),
+					   GFP_KERNEL);
 		if (!rate_table) {
 			kfree(fp);
 			return -ENOMEM;