| Message ID | 20240827070650.11424-3-zhangzekun11@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 815f1fcf2403454904cbbc5cf370df6bc300f392 |
| Headers | show |
| Series | Some clean up with helper fucntion | expand |
diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c index 56f7f946882e..ebbe12692f57 100644 --- a/sound/soc/generic/audio-graph-card2.c +++ b/sound/soc/generic/audio-graph-card2.c @@ -1141,21 +1141,12 @@ static int graph_counter(struct device_node *lnk) */ if (graph_lnk_is_multi(lnk)) { struct device_node *ports = port_to_ports(lnk); - struct device_node *port = NULL; - int cnt = 0; /* * CPU/Codec = N:M case has many endpoints. * We can't use of_graph_get_endpoint_count() here */ - while(1) { - port = of_get_next_child(ports, port); - if (!port) - break; - cnt++; - } - - return cnt - 1; + return of_get_child_count(ports) - 1; } /* * Single CPU / Codec
of_get_child_count() can help to get the num of child directly and we don't need to manually count the child num. No functional change with this conversion. Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> --- v2: Remove the use of for_each_child_of_node() to avoid code logic broken and add the comment back. sound/soc/generic/audio-graph-card2.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)