| Message ID | 20240830070504.289450-1-yanzhen@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] irqchip: Simplify with dev_err_probe() | expand |
On Fri, Aug 30, 2024 at 03:05:04PM +0800, Yan Zhen wrote: > Switch to use dev_err_probe() to simplify the error path and > unify a message template. > > Using this helper is totally fine even if err is known to never > be -EPROBE_DEFER. > > The benefit compared to a normal dev_err() is the standardized format > of the error code, it being emitted symbolically and the fact that > the error code is returned which allows more compact error paths. > > Signed-off-by: Yan Zhen <yanzhen@vivo.com> > --- Subject line probably should be irqchip/madera: but otherwise: Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On 30/08/2024 10:17, Charles Keepax wrote: > On Fri, Aug 30, 2024 at 03:05:04PM +0800, Yan Zhen wrote: >> Switch to use dev_err_probe() to simplify the error path and >> unify a message template. >> >> Using this helper is totally fine even if err is known to never >> be -EPROBE_DEFER. >> >> The benefit compared to a normal dev_err() is the standardized format >> of the error code, it being emitted symbolically and the fact that >> the error code is returned which allows more compact error paths. >> >> Signed-off-by: Yan Zhen <yanzhen@vivo.com> >> --- > > Subject line probably should be irqchip/madera: but otherwise: > > Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> No, this must stop. Do not change one line per patch. Best regards, Krzysztof
diff --git a/drivers/irqchip/irq-madera.c b/drivers/irqchip/irq-madera.c index acceb6e7fa95..d5ad4466a140 100644 --- a/drivers/irqchip/irq-madera.c +++ b/drivers/irqchip/irq-madera.c @@ -199,9 +199,8 @@ static int madera_irq_probe(struct platform_device *pdev) ret = regmap_update_bits(madera->regmap, MADERA_IRQ1_CTRL, MADERA_IRQ_POL_MASK, 0); if (ret) { - dev_err(&pdev->dev, - "Failed to set IRQ polarity: %d\n", ret); - return ret; + return dev_err_probe(&pdev->dev, ret, + "Failed to set IRQ polarity"); } }
Switch to use dev_err_probe() to simplify the error path and unify a message template. Using this helper is totally fine even if err is known to never be -EPROBE_DEFER. The benefit compared to a normal dev_err() is the standardized format of the error code, it being emitted symbolically and the fact that the error code is returned which allows more compact error paths. Signed-off-by: Yan Zhen <yanzhen@vivo.com> --- Changes in v2: -Rewrite the subject. -Remove 'ret' from the message. drivers/irqchip/irq-madera.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)