| Message ID | 20240830084309.395129-1-yanzhen@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] pinctrl: madera: Simplify with dev_err_probe() | expand |
On 30/08/2024 10:43, Yan Zhen wrote: > > diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c > index 898b197c3738..2932d7aba725 100644 > --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c > +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c > @@ -1063,12 +1063,9 @@ static int madera_pin_probe(struct platform_device *pdev) > if (pdata->gpio_configs) { > ret = pinctrl_register_mappings(pdata->gpio_configs, > pdata->n_gpio_configs); > - if (ret) { > - dev_err(priv->dev, > - "Failed to register pdata mappings (%d)\n", > - ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(priv->dev, ret, > + "Failed to register pdata mappings\n"); Another example, one of many from @vivo.com, where you touch one line and leave everything else not modified. Are you going to send 5 different patches - one per each line? You generate tremendous amount of work for reviewers, just to ramp up your stats in company. Best regards, Krzysztof
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c index 898b197c3738..2932d7aba725 100644 --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c @@ -1063,12 +1063,9 @@ static int madera_pin_probe(struct platform_device *pdev) if (pdata->gpio_configs) { ret = pinctrl_register_mappings(pdata->gpio_configs, pdata->n_gpio_configs); - if (ret) { - dev_err(priv->dev, - "Failed to register pdata mappings (%d)\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(priv->dev, ret, + "Failed to register pdata mappings\n"); } ret = pinctrl_enable(priv->pctl);
Switch to use dev_err_probe() to simplify the error path and unify a message template. Using this helper is totally fine even if err is known to never be -EPROBE_DEFER. The benefit compared to a normal dev_err() is the standardized format of the error code, it being emitted symbolically and the fact that the error code is returned which allows more compact error paths. Signed-off-by: Yan Zhen <yanzhen@vivo.com> --- Changes in v3: -Rewrite the subject as 'pinctrl: madera:'. drivers/pinctrl/cirrus/pinctrl-madera-core.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)