| Message ID | 20240907-asoc-fix-mt8365-build-v1-4-7ad0bac20161@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 63157d994025639075b3faa372976a96186322c1 |
| Headers | show |
| Series | ASoC: mt8365: Fix -Werror builds | expand |
Il 07/09/24 02:53, Mark Brown ha scritto: > The compilers warn if functions without a prototype are not static so add > appropriate static declarations. > > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Mark Brown <broonie@kernel.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com> On 07/09/2024 02:53, Mark Brown wrote: > The compilers warn if functions without a prototype are not static so add > appropriate static declarations. > > Reported-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > sound/soc/mediatek/mt8365/mt8365-afe-clk.c | 4 ++-- > sound/soc/mediatek/mt8365/mt8365-afe-pcm.c | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-clk.c b/sound/soc/mediatek/mt8365/mt8365-afe-clk.c > index 300d1f0ae660..8a0af2ea8546 100644 > --- a/sound/soc/mediatek/mt8365/mt8365-afe-clk.c > +++ b/sound/soc/mediatek/mt8365/mt8365-afe-clk.c > @@ -295,7 +295,7 @@ int mt8365_afe_disable_afe_on(struct mtk_base_afe *afe) > return 0; > } > > -int mt8365_afe_hd_engen_enable(struct mtk_base_afe *afe, bool apll1) > +static int mt8365_afe_hd_engen_enable(struct mtk_base_afe *afe, bool apll1) > { > if (apll1) > regmap_update_bits(afe->regmap, AFE_HD_ENGEN_ENABLE, > @@ -307,7 +307,7 @@ int mt8365_afe_hd_engen_enable(struct mtk_base_afe *afe, bool apll1) > return 0; > } > > -int mt8365_afe_hd_engen_disable(struct mtk_base_afe *afe, bool apll1) > +static int mt8365_afe_hd_engen_disable(struct mtk_base_afe *afe, bool apll1) > { > if (apll1) > regmap_update_bits(afe->regmap, AFE_HD_ENGEN_ENABLE, > diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c > index df6dd8c5bbe5..54d2112d2e92 100644 > --- a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c > +++ b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c > @@ -170,7 +170,7 @@ bool mt8365_afe_channel_supported(unsigned int channel, unsigned int id) > return false; > } > > -bool mt8365_afe_clk_group_44k(int sample_rate) > +static bool mt8365_afe_clk_group_44k(int sample_rate) > { > if (sample_rate == 11025 || > sample_rate == 22050 || > @@ -182,7 +182,7 @@ bool mt8365_afe_clk_group_44k(int sample_rate) > return false; > } > > -bool mt8365_afe_clk_group_48k(int sample_rate) > +static bool mt8365_afe_clk_group_48k(int sample_rate) > { > return (!mt8365_afe_clk_group_44k(sample_rate)); > } > @@ -496,8 +496,8 @@ static int mt8365_afe_configure_cm(struct mtk_base_afe *afe, > return 0; > } > > -int mt8365_afe_fe_startup(struct snd_pcm_substream *substream, > - struct snd_soc_dai *dai) > +static int mt8365_afe_fe_startup(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > { > struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); > @@ -714,8 +714,8 @@ static int mt8365_afe_fe_prepare(struct snd_pcm_substream *substream, > return 0; > } > > -int mt8365_afe_fe_trigger(struct snd_pcm_substream *substream, int cmd, > - struct snd_soc_dai *dai) > +static int mt8365_afe_fe_trigger(struct snd_pcm_substream *substream, int cmd, > + struct snd_soc_dai *dai) > { > struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); > struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); >
diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-clk.c b/sound/soc/mediatek/mt8365/mt8365-afe-clk.c index 300d1f0ae660..8a0af2ea8546 100644 --- a/sound/soc/mediatek/mt8365/mt8365-afe-clk.c +++ b/sound/soc/mediatek/mt8365/mt8365-afe-clk.c @@ -295,7 +295,7 @@ int mt8365_afe_disable_afe_on(struct mtk_base_afe *afe) return 0; } -int mt8365_afe_hd_engen_enable(struct mtk_base_afe *afe, bool apll1) +static int mt8365_afe_hd_engen_enable(struct mtk_base_afe *afe, bool apll1) { if (apll1) regmap_update_bits(afe->regmap, AFE_HD_ENGEN_ENABLE, @@ -307,7 +307,7 @@ int mt8365_afe_hd_engen_enable(struct mtk_base_afe *afe, bool apll1) return 0; } -int mt8365_afe_hd_engen_disable(struct mtk_base_afe *afe, bool apll1) +static int mt8365_afe_hd_engen_disable(struct mtk_base_afe *afe, bool apll1) { if (apll1) regmap_update_bits(afe->regmap, AFE_HD_ENGEN_ENABLE, diff --git a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c index df6dd8c5bbe5..54d2112d2e92 100644 --- a/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c +++ b/sound/soc/mediatek/mt8365/mt8365-afe-pcm.c @@ -170,7 +170,7 @@ bool mt8365_afe_channel_supported(unsigned int channel, unsigned int id) return false; } -bool mt8365_afe_clk_group_44k(int sample_rate) +static bool mt8365_afe_clk_group_44k(int sample_rate) { if (sample_rate == 11025 || sample_rate == 22050 || @@ -182,7 +182,7 @@ bool mt8365_afe_clk_group_44k(int sample_rate) return false; } -bool mt8365_afe_clk_group_48k(int sample_rate) +static bool mt8365_afe_clk_group_48k(int sample_rate) { return (!mt8365_afe_clk_group_44k(sample_rate)); } @@ -496,8 +496,8 @@ static int mt8365_afe_configure_cm(struct mtk_base_afe *afe, return 0; } -int mt8365_afe_fe_startup(struct snd_pcm_substream *substream, - struct snd_soc_dai *dai) +static int mt8365_afe_fe_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) { struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); @@ -714,8 +714,8 @@ static int mt8365_afe_fe_prepare(struct snd_pcm_substream *substream, return 0; } -int mt8365_afe_fe_trigger(struct snd_pcm_substream *substream, int cmd, - struct snd_soc_dai *dai) +static int mt8365_afe_fe_trigger(struct snd_pcm_substream *substream, int cmd, + struct snd_soc_dai *dai) { struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream); struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai);
The compilers warn if functions without a prototype are not static so add appropriate static declarations. Reported-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/mediatek/mt8365/mt8365-afe-clk.c | 4 ++-- sound/soc/mediatek/mt8365/mt8365-afe-pcm.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-)