| Message ID | 20240916131910.22680-3-andrei.simion@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ac8775d7de5a8ccac225a398cbce9fb9fffdbb9f |
| Headers | show |
| Series | Updates for Atmel SSC DAI | expand |
On 16/09/2024 16:19:10+0300, Andrei Simion wrote: > From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > > Drop S24_LE format because it is not supported if more than 2 channels > (of TDM slots) are used. This limitation makes it impractical for use cases > requiring more than 2 TDM slots, leading to potential issues in > multi-channel configurations. > > [andrei.simion@microchip.com: Reword the commit title and the commit > message. Add code comment to explain the removed code.] > Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > Signed-off-by: Andrei Simion <andrei.simion@microchip.com> > --- > v1 -> v2: > - add code comment to explain why S24_LE is dropped. > --- > sound/soc/atmel/atmel_ssc_dai.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index 7047f17fe7a8..89098f41679c 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component) > return 0; > } > > +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */ > #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ > - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) > + SNDRV_PCM_FMTBIT_S32_LE) > > static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { > .startup = atmel_ssc_startup, > -- > 2.34.1 >
diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 7047f17fe7a8..89098f41679c 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component) return 0; } +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */ #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) + SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { .startup = atmel_ssc_startup,