diff mbox series

[1/2] ASoC: Intel: Kconfig: Only select SND_SOC_SDCA if ACPI is enabled

Message ID 20241107100204.24952-2-peter.ujfalusi@linux.intel.com (mailing list archive)
State New
Headers show
Series ASoC: Intel: Fix Kconfig for ACPI=n | expand

Commit Message

Peter Ujfalusi Nov. 7, 2024, 10:02 a.m. UTC
The SDCA module have hard dependency to compile on ACPI, it can only be
selected if ACPI is also enabled.
The SDCA header provides inline prototypes for other modules to compile in
case SND_SOC_SDCA is not enabled.

Fixes: 845cb1ddf1fc ("ASoC: Intel: Kconfig: select SND_SOC_SDCA by SND_SOC_ACPI_INTEL_SDCA_QUIRKS")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411070806.UhCRpZok-lkp@intel.com/
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/soc/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liao, Bard Nov. 7, 2024, 10:13 a.m. UTC | #1
On 11/7/2024 6:02 PM, Peter Ujfalusi wrote:
> The SDCA module have hard dependency to compile on ACPI, it can only be
> selected if ACPI is also enabled.
> The SDCA header provides inline prototypes for other modules to compile in
> case SND_SOC_SDCA is not enabled.
> 
> Fixes: 845cb1ddf1fc ("ASoC: Intel: Kconfig: select SND_SOC_SDCA by SND_SOC_ACPI_INTEL_SDCA_QUIRKS")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411070806.UhCRpZok-lkp@intel.com/
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
diff mbox series

Patch

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 46b45f390ae9..502129772856 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -78,7 +78,7 @@  config SND_SOC_ACPI_INTEL_MATCH
 
 config SND_SOC_ACPI_INTEL_SDCA_QUIRKS
 	tristate
-	select SND_SOC_SDCA
+	select SND_SOC_SDCA if ACPI
 
 endif ## SND_SOC_INTEL_SST_TOPLEVEL || SND_SOC_SOF_INTEL_TOPLEVEL