| Message ID | 20241112-alsa_test_rates-v1-1-95cf529db871@jookia.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c853e96308c58f9a06fcf393bcfe0eabdb72ca9c |
| Headers | show |
| Series | ASoC: test-component: Support continuous rates for test component | expand |
Hi John Thank you for the patch > There's no reason to limit the supported rates of the test component > to specific ones as if it's a real piece of hardware. Set the rates to > continuous to aid in testing different rates. > > Signed-off-by: John Watts <contact@jookia.org> > --- > I've needed to use this while testing audio-graph-card2 with a variable > MCLK. I'm not sure if there's a reason why it's not continous already but this > patch seems to work well enough from my test results. I didn't know SNDRV_PCM_RATE_CONTINUOUS, but indeed dummy_dai is using it. The reason why I used 8000-384000 on the test-component was that it was most wide range support. Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thank you for your help !! Best regards --- Kuninori Morimoto
On Tue, 12 Nov 2024 21:34:00 +1100, John Watts wrote: > There's no reason to limit the supported rates of the test component > to specific ones as if it's a real piece of hardware. Set the rates to > continuous to aid in testing different rates. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: test-component: Support continuous rates for test component commit: c853e96308c58f9a06fcf393bcfe0eabdb72ca9c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/generic/test-component.c b/sound/soc/generic/test-component.c index e9e5e235a8a659cabffee7acd747a68bd45f177f..e675b69109a8cf39e2462db8006daf6dbe75840b 100644 --- a/sound/soc/generic/test-component.c +++ b/sound/soc/generic/test-component.c @@ -233,7 +233,7 @@ static const struct snd_soc_dai_ops test_verbose_ops = { .num_auto_selectable_formats = 1, }; -#define STUB_RATES SNDRV_PCM_RATE_8000_384000 +#define STUB_RATES SNDRV_PCM_RATE_CONTINUOUS #define STUB_FORMATS (SNDRV_PCM_FMTBIT_S8 | \ SNDRV_PCM_FMTBIT_U8 | \ SNDRV_PCM_FMTBIT_S16_LE | \
There's no reason to limit the supported rates of the test component to specific ones as if it's a real piece of hardware. Set the rates to continuous to aid in testing different rates. Signed-off-by: John Watts <contact@jookia.org> --- I've needed to use this while testing audio-graph-card2 with a variable MCLK. I'm not sure if there's a reason why it's not continous already but this patch seems to work well enough from my test results. --- sound/soc/generic/test-component.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652 change-id: 20241112-alsa_test_rates-00dab3465bbc Best regards,