| Message ID | 20241206021647.2343-1-liujing@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: cmipci: Modify the incorrect format specifier | expand |
On Fri, 06 Dec 2024 03:16:47 +0100, liujing wrote: > > Replace %d with %u in snprintf() because it is "unsigned int". > > Signed-off-by: liujing <liujing@cmss.chinamobile.com> I applied this one, but please keep in mind that we don't have to convert all those cases blindly. The code there is correct even with "%d", as the value can't be a negative value. That said, if you keep working on a similar case, you'd better study the code more closely and judge whether it really "fixes" any real bug or not, before submitting patches at the next time. thanks, Takashi
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c index e3cac73517d6..cb8593c376ee 100644 --- a/sound/pci/cmipci.c +++ b/sound/pci/cmipci.c @@ -3084,7 +3084,7 @@ static int snd_cmipci_create(struct snd_card *card, struct pci_dev *pci, } } } - sprintf(card->shortname, "C-Media CMI%d", val); + sprintf(card->shortname, "C-Media CMI%u", val); if (cm->chip_version < 68) scnprintf(modelstr, sizeof(modelstr), " (model %d)", cm->chip_version);
Replace %d with %u in snprintf() because it is "unsigned int". Signed-off-by: liujing <liujing@cmss.chinamobile.com>