| Message ID | 20241211-sound-atmel-at91sam9g20ek-v2-1-86a0e31e6af9@microchip.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ASoC: dt-bindings: sound: atmel-at91sam9g20ek: convert to json-schema | expand |
On Wed, 11 Dec 2024 15:16:15 +0530, Balakrishnan Sambath wrote: > Convert atmel-at91sam9g20ek-wm8731-audio DT binding to yaml > based json-schema.Change file name to match json-scheme naming. > > Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com> > --- > Changes in v2: > - Add missing CODEC pin options to 'atmel,audio-routing' items. > - Drop 'minItems' from 'atmel,audio-routing' since enum defines valid connections. > - Add subsystem tag to subject. > - Add blank line between properties and fix typo. > - Add audio complex description. > - Link to v1: https://lore.kernel.org/lkml/20240214-at91sam9g20ek-wm8731-yaml-v1-1-33333e17383b@microchip.com > --- > .../bindings/sound/atmel,at91sam9g20ek-wm8731.yaml | 70 ++++++++++++++++++++++ > .../sound/atmel-at91sam9g20ek-wm8731-audio.txt | 26 -------- > 2 files changed, 70 insertions(+), 26 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.example.dtb: sound: atmel,audio-routing:2: 'Int MIC' is not one of ['Ext Spk', 'Int Mic', 'LOUT', 'ROUT', 'LHPOUT', 'RHPOUT', 'LLINEIN', 'RLINEIN', 'MICIN'] from schema $id: http://devicetree.org/schemas/sound/atmel,at91sam9g20ek-wm8731.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241211-sound-atmel-at91sam9g20ek-v2-1-86a0e31e6af9@microchip.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 11/12/2024 10:46, Balakrishnan Sambath wrote: > +properties: > + compatible: > + const: atmel,at91sam9g20ek-wm8731-audio > + > + atmel,model: > + $ref: /schemas/types.yaml#/definitions/string > + description: The user-visible name of this sound complex. > + > + atmel,audio-routing: > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array > + description: A list of the connections between audio components. > + items: > + enum: > + # Board Connectors > + - Ext Spk > + - Int Mic > + > + # CODEC Pins > + - LOUT > + - ROUT > + - LHPOUT > + - RHPOUT > + - LLINEIN > + - RLINEIN > + - MICIN As previously questioned, I don't think you can create infinite amount of pairs out of it. Assuming you always connect board with codec (because codec-codec are already defined inside the codec), you can have max 14 pairs, but most likely less in practice. Best regards, Krzysztof
Hi, On 11.12.2024 11:46, Balakrishnan Sambath wrote: > Convert atmel-at91sam9g20ek-wm8731-audio DT binding to yaml > based json-schema.Change file name to match json-scheme naming. > > Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com> > --- > Changes in v2: > - Add missing CODEC pin options to 'atmel,audio-routing' items. > - Drop 'minItems' from 'atmel,audio-routing' since enum defines valid connections. > - Add subsystem tag to subject. > - Add blank line between properties and fix typo. > - Add audio complex description. > - Link to v1: https://lore.kernel.org/lkml/20240214-at91sam9g20ek-wm8731-yaml-v1-1-33333e17383b@microchip.com > --- > .../bindings/sound/atmel,at91sam9g20ek-wm8731.yaml | 70 ++++++++++++++++++++++ > .../sound/atmel-at91sam9g20ek-wm8731-audio.txt | 26 -------- > 2 files changed, 70 insertions(+), 26 deletions(-) I recommend you to remove from title the word 'sound'. You can check the commit history of the Documentation/devicetree/bindings/sound/ before you write the commit title. Best Regards, Andrei Simion
Hi Krzysztof, On 11/12/24 4:59 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 11/12/2024 10:46, Balakrishnan Sambath wrote: >> +properties: >> + compatible: >> + const: atmel,at91sam9g20ek-wm8731-audio >> + >> + atmel,model: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: The user-visible name of this sound complex. >> + >> + atmel,audio-routing: >> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >> + description: A list of the connections between audio components. >> + items: >> + enum: >> + # Board Connectors >> + - Ext Spk >> + - Int Mic >> + >> + # CODEC Pins >> + - LOUT >> + - ROUT >> + - LHPOUT >> + - RHPOUT >> + - LLINEIN >> + - RLINEIN >> + - MICIN > > As previously questioned, I don't think you can create infinite amount > of pairs out of it. Assuming you always connect board with codec > (because codec-codec are already defined inside the codec), you can have > max 14 pairs, but most likely less in practice. I agree with your perspective.Here this binding is specific to the AT91SAM9G20EK board,which uses the onboard WM8731 codec for audio support.Since some of similar bindings do not explicitly enforce maxItems,I assumed this to be a valid case. However, based on my understanding from the schematics, https://ww1.microchip.com/downloads/en/DeviceDoc/doc6413.pdf, a "maxItems: 4" value appears valid.Are you referring to the same understanding here? > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.yaml b/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.yaml new file mode 100644 index 0000000000000000000000000000000000000000..7f6334c96e0b753f83a1714a34514f101c2639c9 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/atmel,at91sam9g20ek-wm8731.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/atmel,at91sam9g20ek-wm8731.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Atmel at91sam9g20ek wm8731 audio complex + +maintainers: + - Balakrishnan Sambath <balakrishnan.s@microchip.com> + +description: + The audio complex configuration for Atmel at91sam9g20ek with WM8731 audio codec. + +properties: + compatible: + const: atmel,at91sam9g20ek-wm8731-audio + + atmel,model: + $ref: /schemas/types.yaml#/definitions/string + description: The user-visible name of this sound complex. + + atmel,audio-routing: + $ref: /schemas/types.yaml#/definitions/non-unique-string-array + description: A list of the connections between audio components. + items: + enum: + # Board Connectors + - Ext Spk + - Int Mic + + # CODEC Pins + - LOUT + - ROUT + - LHPOUT + - RHPOUT + - LLINEIN + - RLINEIN + - MICIN + + atmel,ssc-controller: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of the SSC controller. + + atmel,audio-codec: + $ref: /schemas/types.yaml#/definitions/phandle + description: The phandle of WM8731 audio codec. + +required: + - compatible + - atmel,model + - atmel,audio-routing + - atmel,ssc-controller + - atmel,audio-codec + +additionalProperties: false + +examples: + - | + sound { + compatible = "atmel,at91sam9g20ek-wm8731-audio"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pck0_as_mck>; + atmel,model = "wm8731 @ AT91SAMG20EK"; + atmel,audio-routing = + "Ext Spk", "LHPOUT", + "Int MIC", "MICIN"; + atmel,ssc-controller = <&ssc0>; + atmel,audio-codec = <&wm8731>; + }; diff --git a/Documentation/devicetree/bindings/sound/atmel-at91sam9g20ek-wm8731-audio.txt b/Documentation/devicetree/bindings/sound/atmel-at91sam9g20ek-wm8731-audio.txt deleted file mode 100644 index 9c5a9947b64d454a892e1e4148ff06be7c33d6cd..0000000000000000000000000000000000000000 --- a/Documentation/devicetree/bindings/sound/atmel-at91sam9g20ek-wm8731-audio.txt +++ /dev/null @@ -1,26 +0,0 @@ -* Atmel at91sam9g20ek wm8731 audio complex - -Required properties: - - compatible: "atmel,at91sam9g20ek-wm8731-audio" - - atmel,model: The user-visible name of this sound complex. - - atmel,audio-routing: A list of the connections between audio components. - - atmel,ssc-controller: The phandle of the SSC controller - - atmel,audio-codec: The phandle of the WM8731 audio codec -Optional properties: - - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt - -Example: -sound { - compatible = "atmel,at91sam9g20ek-wm8731-audio"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_pck0_as_mck>; - - atmel,model = "wm8731 @ AT91SAMG20EK"; - - atmel,audio-routing = - "Ext Spk", "LHPOUT", - "Int MIC", "MICIN"; - - atmel,ssc-controller = <&ssc0>; - atmel,audio-codec = <&wm8731>; -};
Convert atmel-at91sam9g20ek-wm8731-audio DT binding to yaml based json-schema.Change file name to match json-scheme naming. Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com> --- Changes in v2: - Add missing CODEC pin options to 'atmel,audio-routing' items. - Drop 'minItems' from 'atmel,audio-routing' since enum defines valid connections. - Add subsystem tag to subject. - Add blank line between properties and fix typo. - Add audio complex description. - Link to v1: https://lore.kernel.org/lkml/20240214-at91sam9g20ek-wm8731-yaml-v1-1-33333e17383b@microchip.com --- .../bindings/sound/atmel,at91sam9g20ek-wm8731.yaml | 70 ++++++++++++++++++++++ .../sound/atmel-at91sam9g20ek-wm8731-audio.txt | 26 -------- 2 files changed, 70 insertions(+), 26 deletions(-) --- base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4 change-id: 20241210-sound-atmel-at91sam9g20ek-b0e9dee4533c Best regards,