From patchwork Fri Jan 31 20:24:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Lechner X-Patchwork-Id: 13955742 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B1AF1F3D4F for ; Fri, 31 Jan 2025 20:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355106; cv=none; b=NZzOnpiqSeNte0yIP0Z+VHf6G3qxcdZQIt4fheEo3pOcteo7ZG4IGB2qG9PGmBYRGT9WJ77YgWnNlr0opnP7487VKKRGjCFGSSziWMoZ8ArgDkuLZom5LfSQ0gU38AkPL/9LgEGFT5OmI9b4s1lZz2QT1wfcaiRpCp16pVxy1vI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738355106; c=relaxed/simple; bh=a4UCT4/NNPETnikiY/3/IXvAqgQyANJWQskJKLdiZxw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DD0FWMSxfdqg5ta+JuT4UcPpsHj+A6BJalS6wtNur5tc4otHkUeJP7mMgFVlc4K/du27rRlZZtN9afRkNLIxILIdUJTnKw5ifH8gVs+tEd+UGZwsjy2MBCcdEmfwIyRXjXpihLd9VFCgSdXiByvjAtxC9psxw5WPhWKtCDCHIc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=i3p50MoR; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="i3p50MoR" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2a01bcd0143so1484716fac.2 for ; Fri, 31 Jan 2025 12:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738355104; x=1738959904; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=i3p50MoRqTck66HqRmjce02FFEVCLPd1WryuRoM8Vuk+27DcmPvbT5L1dLrth8Rspe SEJB+O8mrL3HlRbKg5VFYWuQCDhd9iOd4J+Lt4BFQJljF4pHcQrCLAKdvLDtw0FlJGV1 7dEVAyPkdLMXt20S1aFiNAknpOWcDXQLBiMeQMF6UQLyyjAzwVOLhiheBRWtvlGJLrkT YS2GUkU7S1H9uADGOi9+20YUVkUG5taerhoyFL8T8fFl/7yBhswxXr+dFp1bwdy7n38P 1IXFmSQrGkvfN+yZ77Yu/R9POZDUUjLQtzpE/7EtjT2Db+Ut9M+aCRHdVkFBw5e8e1N8 FszQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738355104; x=1738959904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNU4SR73NkzT5flFO6XZzV58Nb+8n8xP048rFGpOLNA=; b=tJZCqfZhid5lK2L1ufGB3/c0l39x5Zb3VtfICrQqJfZ/b7uSwa64daYGWvyq9UHLGO H7hkBYaim9xn816DO8TbQhoJnDilYGjt9H/HZyzl5aLevSKWjrXusiEwKUCN0lshkUoI OMRAY1LdWVpCRGlgdmOJ8lRTv7i9SYkryucE15IkOfSEL+g5DDyic/wjiGJE2jcIMBzy d0a/B1HevxCg/Oao+0B4o1ysMsSR6AjtphJ3nIyLpaJ/D892blWE2WRGq3Sy5v30npXM mqnZ4QMffjbkDOvFKHqQzqnKAg72EfUY+3HLIEW1c/imLgTAOEKKh1xGzO6fnPOKUhso rABg== X-Forwarded-Encrypted: i=1; AJvYcCWWqGt4+nRJ2wKfXlsUhoxFMzfqOAeJVbLQQHm64uFD/0RU3aHXJKoPEbq6f2UMpGuiac+w1lbCq1hlgw==@vger.kernel.org X-Gm-Message-State: AOJu0YwarchnXUhdBTtGo0B/QVU+h5d1+GrDsZNy970Sa6jZCHhiI8SU nrBMKPopOxiaU3srpxj/HUXgtfX8FUahz7yxh4cjmdCHMIwMnCnMGWEmyV/YzIg= X-Gm-Gg: ASbGncszUwDmJKukI5tnEFT0VYJ5a1Id4epc2+OYrXsfjJKpVZxNpx8qkTA9oN9GpKJ qhqgs1/aYLu4Ruma2J7PnNVCIcaLzWeB4wF9bNIPnIoEs06kS27oqOlFMf7d23kh2SyUaoN039h Qno63ysZZDfJCDAEgjtApxvMlQid7fM7Evw9Gz0DSX/uz7QeDZMRwKN5Vt593ucJhCfGy2KGL5u jMyc92scs2ZkSBZmRERtGVq/hTEmqpaG6gRtDvh+AMFbf8FyhLGOJK1of6IORn0Z59bn51VmWX0 nhp/izF+sToxz3WeaJOKDgaLkhUNWDHLgawKjtbmYuaJTVM= X-Google-Smtp-Source: AGHT+IEjjM8UkUItH0qBBqM7/8yjcARln6tFWMQk1I1vtwY7yg+bjxT3tjK0CN1AwA297vbCg45WVA== X-Received: by 2002:a05:6871:7891:b0:29e:48d6:2e62 with SMTP id 586e51a60fabf-2b32f06986amr8146491fac.9.1738355104164; Fri, 31 Jan 2025 12:25:04 -0800 (PST) Received: from [127.0.1.1] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35623d2ffsm1403157fac.22.2025.01.31.12.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 12:25:02 -0800 (PST) From: David Lechner Date: Fri, 31 Jan 2025 14:24:47 -0600 Subject: [PATCH 07/13] iio: amplifiers: hmc425a: use gpiods_set_array_value_cansleep Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250131-gpio-set-array-helper-v1-7-991c8ccb4d6e@baylibre.com> References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> In-Reply-To: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 Reduce verbosity by using gpiods_set_array_value_cansleep() instead of gpiods_set_array_value_cansleep(). Passing NULL as the 3rd argument to gpiod_set_array_value_cansleep() only needs to be done if the array was constructed manually, which is not the case here. This change effectively replaces that argument with st->gpios->array_info. The possible side effect of this change is that it could make setting the GPIOs more efficient. Signed-off-by: David Lechner --- drivers/iio/amplifiers/hmc425a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c index 2ee4c0d70281e24c1c818249b86d89ebe06d4876..e8c67c8145b1b9ccb9b70ccd3ce4f5de08f96e69 100644 --- a/drivers/iio/amplifiers/hmc425a.c +++ b/drivers/iio/amplifiers/hmc425a.c @@ -161,8 +161,7 @@ static int hmc425a_write(struct iio_dev *indio_dev, u32 value) values[0] = value; - gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, - NULL, values); + gpiods_set_array_value_cansleep(st->gpios, values); return 0; }