| Message ID | 20250205192258.358362-1-jacklivingood@comcast.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] sounds: firewire: isight: changed strcpy to strscpy | expand |
Hi, On Wed, Feb 05, 2025 at 11:22:58AM -0800, jack Livingood wrote: > From: Jack Livingood <jacklivingood@comcast.net> > > changed strcpy to strscpy in order to prevent a possible linear > overflow. > > Signed-off-by: Jack Livingood <jacklivingood@comcast.net> > --- > sound/firewire/isight.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Looks good to me. Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Thanks Takashi Sakamoto
On Wed, 05 Feb 2025 20:22:58 +0100, jack Livingood wrote: > > From: Jack Livingood <jacklivingood@comcast.net> > > changed strcpy to strscpy in order to prevent a possible linear > overflow. > > Signed-off-by: Jack Livingood <jacklivingood@comcast.net> Applied now. Thanks. Takashi
diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c index 806f82c9ceee..e9617fc0a532 100644 --- a/sound/firewire/isight.c +++ b/sound/firewire/isight.c @@ -637,13 +637,13 @@ static int isight_probe(struct fw_unit *unit, card->private_free = isight_card_free; - strcpy(card->driver, "iSight"); - strcpy(card->shortname, "Apple iSight"); + strscpy(card->driver, "iSight"); + strscpy(card->shortname, "Apple iSight"); snprintf(card->longname, sizeof(card->longname), "Apple iSight (GUID %08x%08x) at %s, S%d", fw_dev->config_rom[3], fw_dev->config_rom[4], dev_name(&unit->device), 100 << fw_dev->max_speed); - strcpy(card->mixername, "iSight"); + strspy(card->mixername, "iSight"); err = isight_create_pcm(isight); if (err < 0)