| Message ID | 20250213070546.1572-1-vulab@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: hda: Add error check for snd_ctl_rename_id() in snd_hda_create_dig_out_ctls() | expand |
> Check the return value of snd_ctl_rename_id() in > snd_hda_create_dig_out_ctls(). Ensure that potential > failures are properly handled. I would prefer a change description variant without the word “potential” for this issue. https://cwe.mitre.org/data/definitions/252.html Regards, Markus
On Thu, Feb 13, 2025 at 08:26:09AM +0100, Markus Elfring wrote: > > Check the return value of snd_ctl_rename_id() in > > snd_hda_create_dig_out_ctls(). Ensure that potential > > failures are properly handled. > > I would prefer a change description variant without the word “potential” > for this issue. > https://cwe.mitre.org/data/definitions/252.html > > Regards, > Markus > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 14763c0f31ad..46a220404999 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -2470,7 +2470,9 @@ int snd_hda_create_dig_out_ctls(struct hda_codec *codec, break; id = kctl->id; id.index = spdif_index; - snd_ctl_rename_id(codec->card, &kctl->id, &id); + err = snd_ctl_rename_id(codec->card, &kctl->id, &id); + if (err < 0) + return err; } bus->primary_dig_out_type = HDA_PCM_TYPE_HDMI; }
Check the return value of snd_ctl_rename_id() in snd_hda_create_dig_out_ctls(). Ensure that potential failures are properly handled. Fixes: 5c219a340850 ("ALSA: hda: Fix kctl->id initialization") Cc: stable@vger.kernel.org # 6.4+ Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> --- sound/pci/hda/hda_codec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)