| Message ID | 20250214215826.80878-1-nikola.jelic83@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2,V4] ASoC: dt-bindings: Add cmx655 codec | expand |
On Fri, Feb 14, 2025 at 10:58:01PM +0100, Nikola Jelic wrote: > Signed-off-by: Nikola Jelic <nikola.jelic83@gmail.com> > > --- > V3 -> V4: review remarks You keep sending the same, not responding to comments and not fixing them. Still nothing improved - same problems as v1. What above changelog even mean? Please respond to the feedback, the best to the v1 which you received, that you acknowledge and implement it. If you have questions, then ask. Sending something with the same mistakes for 5th or 6th time means we do not understand each other. Best regards, Krzysztof
On 16/02/2025 14:03, Krzysztof Kozlowski wrote: > On Fri, Feb 14, 2025 at 10:58:01PM +0100, Nikola Jelic wrote: >> Signed-off-by: Nikola Jelic <nikola.jelic83@gmail.com> >> >> --- >> V3 -> V4: review remarks > > You keep sending the same, not responding to comments and not fixing > them. Still nothing improved - same problems as v1. > > What above changelog even mean? > > Please respond to the feedback, the best to the v1 which you received, > that you acknowledge and implement it. If you have questions, then ask. > Sending something with the same mistakes for 5th or 6th time means we do > not understand each other. To recap, feedback from v1 to respond to: Please run scripts/checkpatch.pl and fix reported warnings. After that, run also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Feedback from v3: go to v3 and respond or implement. Your changelog suggests nothing changed or it is just not precise enough. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/cml,cmx655d.yaml b/Documentation/devicetree/bindings/sound/cml,cmx655d.yaml new file mode 100644 index 000000000000..577e1d4942c6 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/cml,cmx655d.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/cml,cmx655d.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: CML Micro CMX655D codec + +maintainers: + - Richard Walton <rwalton@cmlmicro.com> + - Nikola Jelic <nikola.jelic83@gmail.com> + +description: + The CMX655D is an ultra-low power voice codec. + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: cml,cmx655d + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + + reset-gpios: + maxItems: 1 + + interrupts: + maxItems: 1 + + interrupt-names: + const: cmx-irq + +required: + - compatible + - reg + - '#sound-dai-cells' + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/gpio/gpio.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + audio-codec@54 { + compatible = "cml,cmx655d"; + reg = <0x54>; + #sound-dai-cells = <0>; + reset-gpios = <&gpio 24 GPIO_ACTIVE_LOW>; + interrupt-parent = <&gpio>; + interrupts = <25 IRQ_TYPE_EDGE_RISING>; + }; + + }; +... diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index dac80c62b742..74f925f3e3cb 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -310,6 +310,8 @@ patternProperties: description: Carl Cloos Schweisstechnik GmbH. "^cloudengines,.*": description: Cloud Engines, Inc. + "^cml,.*": + description: CML Micro, Ltd. "^cnm,.*": description: Chips&Media, Inc. "^cnxt,.*":
Signed-off-by: Nikola Jelic <nikola.jelic83@gmail.com> --- V3 -> V4: review remarks V2 -> V3: fixed dt_binding_check + yamllint warnings V1 -> V2: removed the txt file, fixed review remarks --- .../bindings/sound/cml,cmx655d.yaml | 62 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + 2 files changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/cml,cmx655d.yaml