[25/27] ASoC: tas2770: Fix volume scale

Message ID	20250215-apple-codec-changes-v1-25-723569b21b19@gmail.com (mailing list archive)
State	Superseded
Commit	579cd64b9df8a60284ec3422be919c362de40e41
Headers	show Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4921324B29; Sat, 15 Feb 2025 00:06:06 +0000 (UTC) From: James Calligeros <jcalligeros99@gmail.com> Date: Sat, 15 Feb 2025 10:02:58 +1000 Subject: [PATCH 25/27] ASoC: tas2770: Fix volume scale Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250215-apple-codec-changes-v1-25-723569b21b19@gmail.com> References: <20250215-apple-codec-changes-v1-0-723569b21b19@gmail.com> In-Reply-To: <20250215-apple-codec-changes-v1-0-723569b21b19@gmail.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>, Baojun Xu <baojun.xu@ti.com>, Dan Murphy <dmurphy@ti.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Shi Fu <shifu0704@thundersoft.com> Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>, =?utf-8?q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>, Hector Martin <marcan@marcan.st>, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, asahi@lists.linux.dev, James Calligeros <jcalligeros99@gmail.com>
Series	ASoC: tas27{64,70}: improve support for Apple codec variants \| expand [00/27] ASoC: tas27{64,70}: improve support for Apple codec variants [01/27] ASoC: dt-bindings: tas27xx: add compatible for SN012776 [02/27] ASoC: dt-bindings: tas2770: add compatible for TAS5770L [03/27] ASoC: tas2764: Extend driver to SN012776 [04/27] ASoC: tas2764: Add control concerning overcurrent events [05/27] ASoC: tas2770: Factor out set_ivsense_slots [06/27] ASoC: tas2770: Fix and redo I/V sense TDM slot setting logic [07/27] ASoC: tas2764: Reinit cache on part reset [08/27] ASoC: tas2764: Configure zeroing of SDOUT slots [09/27] ASoC: tas2764: Apply Apple quirks [10/27] ASoC: tas2764: Raise regmap range maximum [11/27] ASoC: tas2770: Export 'die_temp' to sysfs [12/27] ASoC: tas2764: Export 'die_temp' to sysfs [13/27] ASoC: tas2764: Crop SDOUT zero-out mask based on BCLK ratio [14/27] ASoC: tas2764: Enable main IRQs [15/27] ASoC: tas2764: Power up/down amp on mute ops [16/27] ASoC: tas2764: Add SDZ regulator [17/27] ASoC: tas2764: Add reg defaults for TAS2764_INT_CLK_CFG [18/27] ASoC: tas2764: Mark SW_RESET as volatile [19/27] ASoC: tas2764: Fix power control mask [20/27] ASoC: tas2764: Wait for ramp-down after shutdown [21/27] ASoC: tas2770: Add SDZ regulator [22/27] ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change [23/27] ASoC: tas2770: Add zero-fill and pull-down controls [24/27] ASoC: tas2770: Support setting the PDM TX slot [25/27] ASoC: tas2770: Fix volume scale [26/27] ASoC: tas2764: Set the SDOUT polarity correctly [27/27] ASoC: tas2770: Set the SDOUT polarity correctly

Message ID

20250215-apple-codec-changes-v1-25-723569b21b19@gmail.com (mailing list archive)

State

Superseded

Commit

579cd64b9df8a60284ec3422be919c362de40e41

Headers

From: James Calligeros <jcalligeros99@gmail.com>
Date: Sat, 15 Feb 2025 10:02:58 +1000
Subject: [PATCH 25/27] ASoC: tas2770: Fix volume scale
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20250215-apple-codec-changes-v1-25-723569b21b19@gmail.com>
References: <20250215-apple-codec-changes-v1-0-723569b21b19@gmail.com>
In-Reply-To: <20250215-apple-codec-changes-v1-0-723569b21b19@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
 Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
 Baojun Xu <baojun.xu@ti.com>, Dan Murphy <dmurphy@ti.com>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Shi Fu <shifu0704@thundersoft.com>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
 =?utf-8?q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>,
  Hector Martin <marcan@marcan.st>, linux-sound@vger.kernel.org,
  linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
  asahi@lists.linux.dev, James Calligeros <jcalligeros99@gmail.com>

Series

ASoC: tas27{64,70}: improve support for Apple codec variants | expand

Commit Message

James Calligeros Feb. 15, 2025, 12:02 a.m. UTC

From: Hector Martin <marcan@marcan.st>

The scale starts at -100dB, not -128dB.

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
 sound/soc/codecs/tas2770.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Feb. 17, 2025, midnight UTC | #1

On Sat, Feb 15, 2025 at 10:02:58AM +1000, James Calligeros wrote:
> From: Hector Martin <marcan@marcan.st>
> 
> The scale starts at -100dB, not -128dB.

This was one of the patches I pulled out, it's already in CI (I left
everything for a week in case there were review comments).

diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
index 555642d5c53533d9959314f0384c4dfe91ca799b..a9e65f95ec8600d905c45db4e013d3c2602fa8dc 100644
--- a/sound/soc/codecs/tas2770.c
+++ b/sound/soc/codecs/tas2770.c
@@ -653,7 +653,7 @@  static void tas2770_codec_remove(struct snd_soc_component *component)
 }
 
 static DECLARE_TLV_DB_SCALE(tas2770_digital_tlv, 1100, 50, 0);
-static DECLARE_TLV_DB_SCALE(tas2770_playback_volume, -12750, 50, 0);
+static DECLARE_TLV_DB_SCALE(tas2770_playback_volume, -10050, 50, 0);
 
 static const struct snd_kcontrol_new tas2770_snd_controls[] = {
 	SOC_SINGLE_TLV("Speaker Playback Volume", TAS2770_PLAY_CFG_REG2,

[25/27] ASoC: tas2770: Fix volume scale

Commit Message

Comments

Patch