| Message ID | 20250310073653.56476-1-yung-chuan.liao@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | soundwire: take in count the bandwidth of a prepared stream | expand |
On Mon, 10 Mar 2025 15:36:53 +0800, Bard Liao wrote: > When a stream's state is marked as prepared, it is ready for > playback/capture. Therefore, we need to include the stream's bandwidth > when we calculate the required bandwidth of a bus. > > Applied, thanks! [1/1] soundwire: take in count the bandwidth of a prepared stream commit: 08ae0d61c3d79bb5d52ae30ad4fc12442e966a23 Best regards,
diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c index b646c2ffe84a..1cfaccf43eac 100644 --- a/drivers/soundwire/generic_bandwidth_allocation.c +++ b/drivers/soundwire/generic_bandwidth_allocation.c @@ -237,10 +237,11 @@ static int sdw_compute_group_params(struct sdw_bus *bus, continue; } else { /* - * Include runtimes with running (ENABLED state) and paused (DISABLED state) - * streams + * Include runtimes with running (ENABLED/PREPARED state) and + * paused (DISABLED state) streams */ if (m_rt->stream->state != SDW_STREAM_ENABLED && + m_rt->stream->state != SDW_STREAM_PREPARED && m_rt->stream->state != SDW_STREAM_DISABLED) continue; }
When a stream's state is marked as prepared, it is ready for playback/capture. Therefore, we need to include the stream's bandwidth when we calculate the required bandwidth of a bus. Fixes: 25befdf32aa40 ("soundwire: generic_bandwidth_allocation: count the bandwidth of active streams only") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Link: https://github.com/thesofproject/linux/issues/5334 Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> --- drivers/soundwire/generic_bandwidth_allocation.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)