| Message ID | 20250317140845.702-1-vulab@iscas.ac.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: Add initialization for wm8997 component | expand |
On Mon, Mar 17, 2025 at 10:08:44PM +0800, Wentao Liang wrote: > In wm8997_component_probe(), wm8997 should be initialized by > arizona_init_gpio(). A proper implementation can be found in > 'wm8998_component_probe()' where the wm8998 component is > initialized with arizona_init_gpio(). > > Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> > --- > sound/soc/codecs/wm8997.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/codecs/wm8997.c b/sound/soc/codecs/wm8997.c > index 5389c363b14e..ef8e09cc7211 100644 > --- a/sound/soc/codecs/wm8997.c > +++ b/sound/soc/codecs/wm8997.c > @@ -1066,6 +1066,8 @@ static int wm8997_component_probe(struct snd_soc_component *component) > if (ret < 0) > return ret; > > + arizona_init_gpio(component); > + This is not a missing initialisation, arizona_init_gpios hooks up the signal detect feature. I am not certain it is worth adding the signal detect feature to wm8997 at this point given I am not even sure it shipped any units. If you do actually have a reason for doing so, this is not sufficient to enable the feature. You need to also add the Signal Detect widgets and routes. Thanks, Charles
diff --git a/sound/soc/codecs/wm8997.c b/sound/soc/codecs/wm8997.c index 5389c363b14e..ef8e09cc7211 100644 --- a/sound/soc/codecs/wm8997.c +++ b/sound/soc/codecs/wm8997.c @@ -1066,6 +1066,8 @@ static int wm8997_component_probe(struct snd_soc_component *component) if (ret < 0) return ret; + arizona_init_gpio(component); + snd_soc_component_disable_pin(component, "HAPTICS"); priv->core.arizona->dapm = dapm;
In wm8997_component_probe(), wm8997 should be initialized by arizona_init_gpio(). A proper implementation can be found in 'wm8998_component_probe()' where the wm8998 component is initialized with arizona_init_gpio(). Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> --- sound/soc/codecs/wm8997.c | 2 ++ 1 file changed, 2 insertions(+)