| Message ID | 20250320115633.4248-4-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: wcd938x: enable t14s audio headset | expand |
On 20/03/2025 12:56, srinivas.kandagatla@linaro.org wrote: > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > index 10531350c336..e7aa00a9c59a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > @@ -23,8 +23,13 @@ properties: > - qcom,wcd9380-codec > - qcom,wcd9385-codec > > + mux-controls: > + description: A reference to the audio mux switch for > + switching CTIA/OMTP Headset types > + > us-euro-gpios: > - description: GPIO spec for swapping gnd and mic segments > + description: GPIO spec for swapping gnd and mic segments. > + This property is considered obsolete, recommended to use mux-controls. > maxItems: 1 Assuming intention is to really obsolete/deprecate, then please add: deprecated: true Best regards, Krzysztof
On 21/03/2025 09:29, Krzysztof Kozlowski wrote: > On 20/03/2025 12:56, srinivas.kandagatla@linaro.org wrote: >> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml >> index 10531350c336..e7aa00a9c59a 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml >> @@ -23,8 +23,13 @@ properties: >> - qcom,wcd9380-codec >> - qcom,wcd9385-codec >> >> + mux-controls: >> + description: A reference to the audio mux switch for >> + switching CTIA/OMTP Headset types >> + >> us-euro-gpios: >> - description: GPIO spec for swapping gnd and mic segments >> + description: GPIO spec for swapping gnd and mic segments. >> + This property is considered obsolete, recommended to use mux-controls. >> maxItems: 1 > > > Assuming intention is to really obsolete/deprecate, then please add: > > deprecated: true Thanks, I was looking for this flag.. v3 will fix this. --srini > > > > > Best regards, > Krzysztof
On Thu, Mar 20, 2025 at 11:56:31AM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > On some platforms to minimise pop and click during switching between > CTIA and OMTP headset an additional HiFi mux is used. Most common > case is that this switch is switched on by default, but on some > platforms this needs a regulator enable. > > Move to using mux-controls so that both the gpio and regulators can be > driven correctly, rather than adding regulator handing in the codec. > > This patch adds required bindings to add such mux controls. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > index 10531350c336..e7aa00a9c59a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml > @@ -23,8 +23,13 @@ properties: > - qcom,wcd9380-codec > - qcom,wcd9385-codec > > + mux-controls: > + description: A reference to the audio mux switch for > + switching CTIA/OMTP Headset types maxItems: 1 > + > us-euro-gpios: > - description: GPIO spec for swapping gnd and mic segments > + description: GPIO spec for swapping gnd and mic segments. > + This property is considered obsolete, recommended to use mux-controls. > maxItems: 1 > > required: > -- > 2.39.5 >
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml index 10531350c336..e7aa00a9c59a 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml @@ -23,8 +23,13 @@ properties: - qcom,wcd9380-codec - qcom,wcd9385-codec + mux-controls: + description: A reference to the audio mux switch for + switching CTIA/OMTP Headset types + us-euro-gpios: - description: GPIO spec for swapping gnd and mic segments + description: GPIO spec for swapping gnd and mic segments. + This property is considered obsolete, recommended to use mux-controls. maxItems: 1 required: