From patchwork Mon Mar 24 11:51:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 14027136 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2055.outbound.protection.outlook.com [40.107.105.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E88D325E47D; Mon, 24 Mar 2025 11:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817162; cv=fail; b=sHjEwIPQVonVgjEVyZ1zqdtaWhVnuF6DdDVmuHuKx2m3lepvCfn2Ppm8VYu2yURB4E0bWtf+dZAYPKLHhJht2cTG0gERvvkh4mP6cAbyfDukBMKDcCuKJAy4lF9Szn2h3Dj3ynVyvaIVtEzZzx5axWMnk2zK4jC9OihEULncKDk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817162; c=relaxed/simple; bh=clBLY6CTjup4wOQ0/L626b6aymnbE1kq3ZpcfBvAZPs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qAHi8yk2bbpBWnvTXwRfsl9FguYMEchHxqp5XIH9Lo9rMUSXfxcl0pQF5gcBuhPYPZQBSpq5ImUF4/96q/qGvgHMUqDC4aYtCFtozTqn8sale7joii0MelhwLnb/bnuL9n3z3nCgO7eHogUe5D+VzEmLdWxZraiBU7P4x1I+xwc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=TdDvLfVd; arc=fail smtp.client-ip=40.107.105.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="TdDvLfVd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=toamur910b67lVJWdRmWQsmJLEsJoeU92Vt8NIS5Kba+Uno+qh6TiljgikMZuLbYEtCGvm+n/Xa5UqByt293puGZ2PGTm0ZhINuBvyeBKahRecYW9hXEMazaJ+JAlR/hvQPfUZKYb/RC+prqTocx5wq/6myJeLatb8uOoxbC/R5dlWmPoEv5amcwiNl67XFgwpSW14bSml9PycLxkek8/iR65qSaVfvDvc+udN+NbwHddkXoJVQDsYI/2GTvggqWplWhYbT7ksKZc2JcYXcev175Ytcz80yEc/TjqxMp4xmchCKWcgSjZ7lzSUK76lDL/k77su0ksjvmH0/5xlDN3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAgBNSK4ySIw3VgQKwYgVCvAqc9nYi/Toq0XR0gV2Rc=; b=I6H42Rp9dM9McFbOpug+fgt8D4q7sB4OMoJyRlebPmevrDQumQeTsDgNT7WRgKbQ0Wxd8IPQ7VFRzKPdNW7dCpOSCnI5cym3/jPzqyqeCbJagYRsOcuTh5In2Iz56FLwwSNdGAO4Q/ZJn+PfnuobuFRS7lAOqh7RQlQ3UwatE4WGk+sUfCGoWNpNdqwm5E5u/BjvNiXVQY766ffEeZuVxb2Il3tHJ8v2tNdMDEiEGC3vlkAbu3jr6R4WNcd39MZN0F64huIzq4bfwknYHK0UmWMZnMHJO5zKhWVT4wSknPjQ0D7DS0+gK2lgjLdafxQxkeeiN309+zVTGG96ozuztA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAgBNSK4ySIw3VgQKwYgVCvAqc9nYi/Toq0XR0gV2Rc=; b=TdDvLfVdFoA0hKJraW1C8g5v6NjwrvFwN1PmNAIv9k6eqaMmYm/ShFWaHEqznqAF+MWJoDQ3bK4g4tf6M7pgUNe8dKrEgfTStOQltorwKLXfecIZ5XJgorhjn/vFcVI2/beX5rPMP/bxEv0jZj3ER8O5bf+1A16rj15yti0wkkpNhy75h4BsQ9wbjXlldcI90+rBP19+vKIsPsY6eU1zri8oYktdMlQsX0r2bLF++wIMvwjZIcxR2Gsz+RUokLPW7GijtFzFZmvtKy7lPUqmt/QupJFbcRDLpEEDGe4+bU5zN9/+zECwT/CPvqn+dH4opbFfkBOgxF86riYxNZHlnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10793.eurprd04.prod.outlook.com (2603:10a6:102:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 11:52:36 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 11:52:36 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 19:51:27 +0800 Subject: [PATCH v2 1/3] ASoC: codec: wcd939x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v2-1-773f67ce3b56@nxp.com> References: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Steev Klimaszewski , Johan Hovold Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742817094; l=2626; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=70jr6uAvczABhCM5Jlgve8nrHarquKaD/mWAZ0z+24s=; b=IeaXLnWbBlYiwkkX700XtWUHNv9wjbI3oxxTyXqVppIyVHKJKg3w/Do1t7iGx+LGQqNeujLq+ di1keOpsT33ADLuAI+mnbJA71SU1fPQc65q0qBF62gIRhscJWjFS55/ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6399d413-c25d-4631-9a69-08dd6aca5ec8 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?2fKxuIrOtHhLve/NFv+gYqwIUxFRyAa?= =?utf-8?q?hKYhwHkaGfG0RA0/iL/3GqwMbwvwIFx1zQjYByl6THLoPJx20yAbLDVXq95wr9xtG?= =?utf-8?q?tDcNn+67xr9X1OSLuDujIwl80qqUGNvWwx/WOYVuyWVvM/hkKjwkCeGehAmxE31go?= =?utf-8?q?iaEl0XwVcDZA2wSbYmsUkaCOOj8E3alc+gOAiUjhaBIsKxXMryk0R3ArfaAsCgtmx?= =?utf-8?q?UM5dK51P36GqRZGnr5yHKo3cVRQZWMLF642TX2d/uduBKVZLKhiuV8LvTmZ2xaDoK?= =?utf-8?q?HXKi1yz/ed3VgTjiew1iG4mU8BOGz09tm4hkHFl7GIZf8wzJychMp0ReoanH+87Qg?= =?utf-8?q?eA+pejsP8rtP4/Io3umZl+hgZ14eTdwoJi5lvegbijWdRf2dAixtN1uxWMEzx8ZD3?= =?utf-8?q?gg03x1YFWOqr2wUWXTX7wec+QvZeBLLHZ74ZNddjlYMqElczd/3MxmxgyXHbFREED?= =?utf-8?q?GUgHr1OvgWjlRyotNsS32HrL2ODXp52g3e6G74C7bRhGPyKlI410sGqIGwcYiiQ1A?= =?utf-8?q?Nhy3WlpZQrJz6Feaxzk+4dhhrU3Pr8eJGZ9XmJimnKgeXTUi2Z1fSnO0o616CU/Dz?= =?utf-8?q?lFVGQDZBTggv/kk/Io0Ti/W3/aZ010RoICZNkVtAgm4GxG2bkkco2ADOe9xK+MYKT?= =?utf-8?q?IsqIpZ+2iNcwezIyIa80I/Ms5Nmu29oF24A90U4s+q27RGaAnAIT+xf83vFoBMIz+?= =?utf-8?q?4G3C3qUX3l7m8sxl/TDfdeL8b59e7E2xfAmIzSnnfQ6aqjsMRY5gAwzixmootK4h/?= =?utf-8?q?95rDaZar2YHSQhgixAtgdzCDU9nVM8ML3Vdx75GepSy0c6AgqeJAbQrKQE3ubLPtD?= =?utf-8?q?d/n5UBC5ltSAa3iw8VUZAR1ILnsgHJUCjoIfL/9buxlKbaM+GhEURLC+o2FP43D73?= =?utf-8?q?LxtESVQFFC8HJlQbh5cgDqKAHGxycuhiHVQNu30vbwTJXM/PNabMKcdMPISOTg0Q+?= =?utf-8?q?E/NUsklEbZHFH0gQnYDLRLdr2DOgRqwGZZxscchwv3W/DEzRDXJ7Ykf/D1hfbOwyl?= =?utf-8?q?X0T1SIprC2ezhBEGskEC9siacPAajVdxgLKVoXCCpgiT6C8cfOeF5HREGtff00EbX?= =?utf-8?q?Bfuzb+iGkmsJfv/5fdGZLbvCErFRmOe0N0stn0PuGqMt5K8cKoqUQ32XAAmi7aCXs?= =?utf-8?q?Mnf3LBOReAIlnNLtiKwrUItaVWB4Knmag1RDO2JhPePIKhDcskCvv7QG7dSL+LlB0?= =?utf-8?q?ClBpoF8OTXR66ba0XOt/gSUvz42HxaOoexoOOHrt2y+y2Io99h9SGNAk3acq6NwC0?= =?utf-8?q?79eBaKCeSnhaalZqDyckghR/vG+bYoauGE2xSaKERyl16cZxzxpAzU3fG+ljMfVQk?= =?utf-8?q?lsVq+cpCSFvHNR58maI4lF+TEKlRtDTA9INrP6VTY40LwXYqPvEypVI0N3tZVBa2l?= =?utf-8?q?iNY+38dPI/b?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?aEl8siaAEhozcaQXIyhbJAUqFazI?= =?utf-8?q?qv0E0DsxEUFLOtt2w+KhOyahU1wzM1SZRLf5rmjGKnzUGLBhKmSdUpDSOf9e31N06?= =?utf-8?q?DeyypunbspuOd0laCSBr1+CXtEMCKoEOJQ/kWpUGopadqFdUhnMqhb6zjxmBNAKCS?= =?utf-8?q?11dc0CAjjpzJ7cVTrf/fUPaGjBVaDmJcSH0WGLJnfYh/IQskWcIHYwau2TepJavAu?= =?utf-8?q?ZSKjXRAss1q+uc8YYB7M01oLWFbEz7uM9da+M60YCLIT9lixqU1JDaLTHuRtr5Swp?= =?utf-8?q?RlyaQyMMTyMiLlCAGvl+vN55BnKCrAQAcSxC71SnqwUD4Z82Jrjw8UPLTJcd1+Mp7?= =?utf-8?q?2zpRR0/3M0Plz+2/d9fkHRY1LxPP3soopHjRwE7PyDSpvp0ZM5+reNj79AaFETPqQ?= =?utf-8?q?jdYbHU2s8fKpzmJbipORtqPkC6oFidtfbk9fVpSgTq/AoqmyEgHjBB9fFhBeCMQjc?= =?utf-8?q?qJqxfqAmzC8JqsXiDbK/e9XXsqS/K8E+0zoeU5JaTYCtjUXVpSSchF3NxO5k/6umI?= =?utf-8?q?eMoWIH27w/CoCGqT6m9ZfiqR2rcxsEiKBI7o+FoqLfFgLC8IhLvvRPKuPg5yAyGqj?= =?utf-8?q?k5HxlI4slbd0XvbdCYLTYkH8YxRrykokb5xTtz1QI3jfcByIxYFLOzlU/QX7yk+h/?= =?utf-8?q?io01n3UV9o7PJQDaAfLNQsUD1Z5NmFQDyiP0Px9c7kbMpR9znEbMJaxQJy3pbCPsW?= =?utf-8?q?KGs+GyNRpFnci6gKHgtB4A12s8SdyYYtWvTTrzw81vhm4vDNqdVj45o9bmY/NPuxO?= =?utf-8?q?akW9HS1iyEwjgqEWHmkZG1Q0qKJHTkOowUw5f2hT5EDm4KsoGJMTpcEiJhOxKUdSl?= =?utf-8?q?c7nIDdjy4J4awt3Qpg5if61ec2oIybodsC9FDETqSptKnDfY5nSFmiBvOyX6tNaJM?= =?utf-8?q?v7JHtohaF4rAZFGjb/n8YtQIN8+ubMNxaniNNR1Na0mq9MLGOb7yb6N3stsAOhp4A?= =?utf-8?q?SiMG+Rg9OgVmbQTlgr7yc9PKAFzXt2ZJEK5qNkvIy/ZVjAhb69GD6Ahyr/bWLlg2k?= =?utf-8?q?nfdoEdTPYe34ZDoXUEe8T7f5K1w5N1WlymxKF+dU5m1Rjf56ygETlHVInG2ngWDbY?= =?utf-8?q?vGFxO0sQcYawHyW/VLPp8WZMFiT785Ig40kRWTLTTg6SikidfCG54pFsPy34Htpc9?= =?utf-8?q?2W7t6ASyOqIM1wYmkO0pOkpc0WGmBzZ32AXgRDXSVYNr1idYnN5dpOk0EP+wxZXVL?= =?utf-8?q?dkYZ4Rsvb1L45FV4QFKpsI5qReyuWdymCJXLoa/aHPtP5hiHvs2BYuYv58hGR6Bbn?= =?utf-8?q?Wj3HQRvkiaECoA2qlfADNTqzBblYzw6m8aLMj/tyN6sw0DdKgzKHnRqZpmDUnkwpx?= =?utf-8?q?18NxVVMNzBRnf/lXYcmltVN5Ppe9TzpqWXJ8x6YLekThOLpNtu2Z48Wqtyt9wz8CU?= =?utf-8?q?azhEMsduJ0idNEljT3NOX6J3JFhjyC/fbpgV+QsIhDeQj4uqYgOMA07nq598WZ63v?= =?utf-8?q?l/59/bDEqcMJxTmLPp3V4S25iYkreWGtE99Npg+LbfBQ2AL15Oi0wc7TG+mf5b/yg?= =?utf-8?q?ls+xgmSinjG7?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6399d413-c25d-4631-9a69-08dd6aca5ec8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 11:52:36.4562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RltyDcxBctdLFSBfyWVLVr2nD+Sem+9VutHhkfVeOe/XZeTKx9ORe9V9R0e8QEF8FRt3zwXKz0Mqn8fsQDCGzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10793 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_OUT_LOW when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. The in-tree DTS files have the right polarity set up already so we can expect this to "just work". Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Reviewed-by: Bartosz Golaszewski --- sound/soc/codecs/wcd939x.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 0a87a79772da6c0ed3c7dd7d098e949b9cead2a4..837c86ceb1097254f4029087ce401c5a8645bf21 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -201,7 +200,7 @@ struct wcd939x_priv { u32 hph_mode; u32 tx_mode[TX_ADC_MAX]; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; u32 micb1_mv; u32 micb2_mv; u32 micb3_mv; @@ -3239,10 +3238,11 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device #endif /* CONFIG_TYPEC */ int ret; - wcd939x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd939x->reset_gpio < 0) - return dev_err_probe(dev, wcd939x->reset_gpio, - "Failed to get reset gpio\n"); + wcd939x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(wcd939x->reset_gpio)) { + ret = PTR_ERR(wcd939x->reset_gpio); + return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); + } wcd939x->supplies[0].supply = "vdd-rxtx"; wcd939x->supplies[1].supply = "vdd-io"; @@ -3290,10 +3290,10 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device static int wcd939x_reset(struct wcd939x_priv *wcd939x) { - gpio_direction_output(wcd939x->reset_gpio, 0); + gpiod_set_value(wcd939x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd939x->reset_gpio, 1); + gpiod_set_value(wcd939x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30);