From patchwork Mon Mar 24 11:51:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 14027137 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2055.outbound.protection.outlook.com [40.107.105.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8048E25E834; Mon, 24 Mar 2025 11:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817164; cv=fail; b=k5iZXEDUyPiR3R8ttd0qtrUL6jirj/SnALS5UAxQbaICvDKEJiajZfo0oMTGCJNG7UY1sqRBseM2LquPZtAvQ3FaR6TcNDux5TwUnL8Q1Fm36AyVsRj0XAS8HDsQ8Ozn4Dqd5bI3H2pb1MY0cHM6rLsav+GB1BBEEcNeaKF0wko= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817164; c=relaxed/simple; bh=tEh8xndEV4DzAQiz5Ev7QRAHEmx0QSyxe4RRnt2cTY0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=hBdSgsgM3b+/ZdHkXUbSijUZDMu54qZvdY0kJRlfFprJppWFrC5dXB+vsY/AFCMiv/5iCUpWxtkl6dTIe7cCKTmLENX70K4SbCZ44y0qLegKuZaDp/I5QBPYI4LBss2AcEjDoXNxoUmAthMTZHYImYGaw9RMVm4nX/qe29YpcMc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aWZZAK3h; arc=fail smtp.client-ip=40.107.105.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aWZZAK3h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XnLOBppDMsMm4EjYewp6jzINLyHop25jLzdwNT4Ov+QYKZrhvu3+nwUeNvxkfc540rs7i8yiAB83rUrygU5GDmTygAV0TOMpAi+RApSYqq1VT9T8Gx9qGPiYF5Lh36pbT9u3/OFwvHrmqEEX3Lm/smCCKF9M81hIl6XsSyWZqqU9shrqLtQZ0f0RcRicuZDNJxde2cDQynuhkKpywMfEovvvpW7+z0sb87y4anY1mar+/JDiTaLh/AmfmD9hPsImAoy1KTr0boatOQ+jhuBjs27YlSb2Mk/ECOnUuFZtiIweJ0Ab/wLTDjEP8AH6gQpqQHo9seFZng12goQqMnpzzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Z66TkoJaOB2GgBs3x7C09pBu6O01+YtSgB1JDK+/gs=; b=eflcUA8n+ma8yCbEYhdHG/5cUH388C4RoK7R4AefBT6zwPw9a7kIdTYZptv8C0D7i56Igm+2p4EKiLRXV0Qq385hCJciVh0qdkFDu7DbaHNQjd2FtJUtQIdEUiAYhmTstYNRfSEcRo9A+fZE/ZsoA85SAGiIHv0PD9NW8nXzRko49uWH8ol90jnNVYS1+/duziHNx8V7BB5NZsKboo9eBUQruOUwlNzeV6wPPjPdw6MCi+oeikM6HPttSVBqeakDPmTZpHTMvM+hFr/Yi2a4881UkHp9HEkIA5VfvJPSk2Ffy02pbV9tc811ivTWdA8bpxO3yv2kU6vmm0iuBxqsdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Z66TkoJaOB2GgBs3x7C09pBu6O01+YtSgB1JDK+/gs=; b=aWZZAK3h/p3pswtYTH/SEwXOKlEv8kMag2UNGtfncS88m/TZFYyhWUBaLS6XC1gcucRd595bnBMY+8lPDDMP+EgP7rxGIfkXyWmd8GVRM/m7fXs8M3+aH9fWdvZkQrsSs9VmBmDbHB7fkdI8QjJEZospGsib5RJnHLQLCHeZkw5e6K1KPjX40X/6ji4AQz9+ZSGEhDr7J4MxNNCzYU4saX8Bjj8efuDl1IYK+8j3va0IRrtwwhZiQBmMhVd1BuCLiNhLSbGGyYgYx+1p4ecHGFNef+DzASVT482gGfIVcM0ZtLIJ4zb+vKVAbiOG61UpBczKhCm7kA0twH+ePZZWuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10793.eurprd04.prod.outlook.com (2603:10a6:102:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 11:52:40 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 11:52:40 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 19:51:28 +0800 Subject: [PATCH v2 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v2-2-773f67ce3b56@nxp.com> References: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Steev Klimaszewski , Johan Hovold Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742817094; l=2592; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=KSNVXc7VPsbNPc5hvKvI9fW2pZtagLee72i+Ls0pits=; b=eLTZNwa1m4W/6cgx7DG8GkY0x4wlSm9QZHXfTAGsttxLL9XulTTc5OH1f4VK0T9CzT7YaqMFB EDNpy+aVzbXBXarIrBQor1tuMvqddQ7EnqfNgEhLHFJYbD2SOV3xhTK X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c37ad15-525e-4c4b-3753-08dd6aca6140 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?kFuk017/gr9GugyFbTXh9bTdkwZDzHo?= =?utf-8?q?loZAoOzrREwBNXok/vcPeCbzBZ08fP2dhZrSt+rF9QcrTAhGCXDj+1bJ9iPOK+4kz?= =?utf-8?q?HKlN1Zbwb7wERAHhUyqtt6SXDdMLLwo+lVD9vddt6WvcAYF9Qmd4fsf8b+aDKKVtO?= =?utf-8?q?3FMfmhLP/7SoYODmlrnB1o/d0Drd2MrI6EXOvgE5JlnuB2uON42upH66DJaUJYVyP?= =?utf-8?q?5ifKT8x8acQlTkYUu7hMTAzrk2DVL+2KgPDVNVJ36cVH6PhCLUdL5gJ1Js4OXIFco?= =?utf-8?q?uBb1Gu0bmIArKbwW3J4c5mAL7e5IexThFs87JCuiJJSenN/9IxiGmHUN/EoCdUqZU?= =?utf-8?q?E9SVVfedXnOdzr7DeUzEVgik8dzmg8o0Nwv4nK7xZZppgkKu1/fqqFDOf12e/OC1k?= =?utf-8?q?Xm0UQPGjY+kstB4fYg397LnvMwnPv77g5Ht7BWaB3lWaIUQzq23alWrTZNjPI5T4H?= =?utf-8?q?C+o05ts3e3wxfc4W5vkA8xb7qlpXEb0pCYezSzVXaep1aopbEx47NBsdZSJhEL8QT?= =?utf-8?q?HvwwIlzh/0tg1IM9DbynSkYK4AS+c2h5XbhpJ7SmUbTD/CTkvqISDdO2Iwm6kswtS?= =?utf-8?q?VJkLR9TASIKw51V9I6yfTDiaw42eonpptSj0siOda5yrhw2+sb6KdFxtw/UQToICU?= =?utf-8?q?IdhcMxsT3H7RtVaSE1o8r3Hq+BqODpIbqjNUrdSox3atLVNHrLYRWG7GsXz7iq1GS?= =?utf-8?q?Dp2tjS9Ae9/7x0uPXlQ+qUtQBhw9N1uLYITrBelvZmqvK23Kg4muRRRFMs85yWs5P?= =?utf-8?q?KYT8IrWC0fH7l/C6hvFQtNHhANHMhS/CyZrNRZipOFIW8czpcopgTp1OEN1OESb0g?= =?utf-8?q?aPsWWk1y3abSpysrL/lS4n2h9hhVixRjF5nqV6DfL5gmyCzSm/IF0uALHCGk38pPX?= =?utf-8?q?ueP1dXzkHn/bsDa78Kd5Y//yPHJj1Jb2o371XIhpmCvXZXwsGNUq2LY1rXzIK7WIj?= =?utf-8?q?rPlVbI5Q/ZTCKrqwv0vkUK8OBorMenC/8NSseoQ8lIND4Bnfy9V9WfObQLm3INayx?= =?utf-8?q?HUuTo8b95kCSK5j2U9trPtBUkYB1BgLC/XKGUfBzgG29kCgMFD2Yi2eZVWNsZWloi?= =?utf-8?q?7q8QIjTmdy4Pv4zyWrZpPGOl2bkcJC6TsgcQitlX8BVvKbqJ8OraV3/9fCiiYD8eT?= =?utf-8?q?r+TWGWgcjcZywLyEaTCwRXiNvWMsHoyGmyXCgRaCeTKTcDvuAlYHShcAL38fLln+m?= =?utf-8?q?J3Glr9fDnr0dxOM7K2cb1stJuPP8koqDudbQp/atVMMQd6z8r8xoeSgXgyovcHRbk?= =?utf-8?q?uY0BCAW5sw2jsOvQg80r9GqfuuCPXv67c5tB3pWEhjA+LxeZFvDu3sXpboapIRWq3?= =?utf-8?q?cPrOg0hKqk/DrS2PpbNxZ196pgYhKYylsdVHBzYPY9O6y1AXeymsyUT9gyiGMKqQU?= =?utf-8?q?kMawQAAV8so?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?LyoLiqcRtkVlsUskYDwCsUqO5kBT?= =?utf-8?q?mw8ZhRo6MfpEP+9xcBQJUXvfONECgDgfIHyYzxzqi4RbYLDylgIGQsbJ7tIXh9Yu8?= =?utf-8?q?8j1MqUQKfxGUmaeMa34IvPXb1OklofRkwxoU+w8dRJUrQ/xfWL53fBmqt73vTtC2x?= =?utf-8?q?AmXBBTeJP56FX1XFiWxGwpcEyBi+vZX+bh+B5ak4Sj68wzTSMtSe+fTSLAIl15vyO?= =?utf-8?q?OvnSE/E0busLt9J9653Pf2Y+mmaowk+KVVHVchVLDISbV+11QJ5rfxYU3JI0JCNAN?= =?utf-8?q?8qAmJOgRhYt+vPhW8JD8Qd6g0oJ8Ceesbk0gH1jh0ewaQycxvocm0Bb65q/K0lmoS?= =?utf-8?q?uxua6zQvQqusZWquE3Sv0gvD3IWKIwVf1+tYKPJgXmxtJ/0KBH3l5ZnZrY9468LpV?= =?utf-8?q?DyqwPRER7wxzZw0/ajL445zYlioOfrrCmppmmjmwm8Ku3gfOMGrhNyeraE9qxzSAq?= =?utf-8?q?4lE/klGQUZSIv7XYG8TeD8SBOpAkU8QcNj9boiJ/z9Nyij9DZL9pN3UWBveL4UMJz?= =?utf-8?q?EQazndxJRfHhW7ZimpaKghfh8AL3yjBj767NiB1XnbXXMLTq4I04PnwKfO7M53mJc?= =?utf-8?q?Wcauhydb7bLDESCBEGehSKhrdYPm2NB/UYOwEG71zGY4n6sbgr8lZHeVByb0GG1WH?= =?utf-8?q?roExA1aHuezj3FzXdbZeZ/6QOo9RLGx+1U/QHnDgNF54cTjOgXupgQazsa5e5LE6Z?= =?utf-8?q?xSrsfh3W8Gwq+qX2sL3WCIERxY0Jo+3he/QaJOcjLrsezdQY6OZK9/YqietOGAOE8?= =?utf-8?q?wzdhNT3UAKrHwKw5bVdc66mF55CTlBl/Oq2RvJ8Etaqp7v6z/3L6k64AO8FAeJG2U?= =?utf-8?q?b/HHvHjTcppedgCox7Yc+BQi1eIXup9j8JwHM2kHu7+k+PbeWRV3jPZRO0pKuYx2+?= =?utf-8?q?jJOyMitchBnevUAB8MlshS9uaXpfhqL/31rL6PKan2KQIa8CDfAax4PPzvwpk+w1c?= =?utf-8?q?hiF+FMHyb2bPjuRDcVCtN6HqISTLkBKUxs8IhXjhZKqIeltcaJJDjoEZMlMSLxHhu?= =?utf-8?q?W6dsll3OFjRIw4b05XW98HkJ6et+co73Nx+76plkqCcsEHJ3KiTcYeH0y3GykEJRQ?= =?utf-8?q?BfQ5emdVBYpNDIKfC8RqWyKbkSAQpplAtPAMecTLZxxFlNWCFSGgizUfIkiefR1Qn?= =?utf-8?q?DArdWmml9W+kL522N4AcsYtQ5t5iD36QcnP1iyxjoBWTecGe/JqwGCpo/3+YP+eL8?= =?utf-8?q?aisobXOJg7smyy7O/itQiAl1YXDw+PaDxUNZ3Z/3vi57YQ+nyyMCMKZe1NSd9R1Z0?= =?utf-8?q?dYAyt+Jr8ZbLhATwlXmaVasbOLjKx/COMweBquyjRS/QzLeDFPlRwT++za3o+VGJa?= =?utf-8?q?NeRyap0V1rzL91mfJqiuh4EXKsT5YDDe8KOoX4e3edbSrwRiGMWz24fEvsAt7X/Yr?= =?utf-8?q?NTAgUwb480l0LtwcmmuY2GR/ChBIxtQ3Jzei9GnycYmeZ8DOWDxsUsZ7cnisgfqiF?= =?utf-8?q?z7DrtARtEgjwa7my8X7atAM2WjlNhboiSzCcl/APiFmXc2S2zwus2jGXvCEuLO0aW?= =?utf-8?q?gMpI81n/LEhd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c37ad15-525e-4c4b-3753-08dd6aca6140 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 11:52:40.5009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EcF9i7kwwWdIzPXgB2VzrQOKM3AD0bGz2Z/AS1Odu9lFP/oRvogaKtSqRW7E/7Kol95ouiiqDfm/P91OK0mLzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10793 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_OUT_LOW when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. The in-tree DTS files have the right polarity set up already so we can expect this to "just work". Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Tested-by: Steev Klimaszewski Reviewed-by: Bartosz Golaszewski --- sound/soc/codecs/wcd938x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 1ae498c323912ed799dcc033e7777936d90c9284..955a0d3a77d7cb45932faa0c7a6f5060232d33b4 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -171,7 +170,7 @@ struct wcd938x_priv { int flyback_cur_det_disable; int ear_rx_path; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; struct gpio_desc *us_euro_gpio; u32 micb1_mv; u32 micb2_mv; @@ -3251,9 +3250,9 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device struct wcd_mbhc_config *cfg = &wcd938x->mbhc_cfg; int ret; - wcd938x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd938x->reset_gpio < 0) - return dev_err_probe(dev, wcd938x->reset_gpio, + wcd938x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(wcd938x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd938x->reset_gpio), "Failed to get reset gpio\n"); wcd938x->us_euro_gpio = devm_gpiod_get_optional(dev, "us-euro", @@ -3297,10 +3296,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device static int wcd938x_reset(struct wcd938x_priv *wcd938x) { - gpio_direction_output(wcd938x->reset_gpio, 0); + gpiod_set_value(wcd938x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd938x->reset_gpio, 1); + gpiod_set_value(wcd938x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30);