From patchwork Mon Mar 24 11:51:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 14027138 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2058.outbound.protection.outlook.com [40.107.103.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFF9D25EFA2; Mon, 24 Mar 2025 11:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817169; cv=fail; b=sz55Nb+RPmnL09DjdR59r7YOBsl5hTzWzMeRQD+33SxddUUcPydiaB34sbSGLPwCxqzSPsdDdqT7SKyu6XbXKwtAA9i5aECL9A1WlY7cfIe7gMpxV+FxnwzHQw6jzAd8pO3BakTIRxbxOXHHWA2qxaZMnq8CT67S5DFC6W1kBG0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817169; c=relaxed/simple; bh=8lqloYOCi2lS15i/mVpCiuhpzEslgQDTnHHBRmj9IGU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=KPzIXxB1nRTrV/jyGU3eCaTmDWdMt8eUjImGPRkuNrsxR0AvNUKklmnNLYaiO9upvLJOqxch3cmzeWC1IyENSAijVnCEjblbdFZF123eUUPupMS6lNhT/TqXASLB4407u4Sq6MQ+nvhwKyVc8jK6k07SEarDdpB12wPulIO6ABA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=IFNzURFH; arc=fail smtp.client-ip=40.107.103.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="IFNzURFH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hq5dIgb1B2tOS5ylAfB9dGV4rLDtsaVzljrCwDe32voKRhqkj5AimGpR8Q2X60n6h7sCnrPicRoGePHZQP6JBsa8cfz4kzGKTpPpwcR40c7gUM3+AVz1wTsfGirvcZz8YsIgk0FQSKj+M1idfmtY6Gbx212HeCyeFGX5NY/JYAeqcEAcgHzwrKuBh4+nsSpRV03RGVPLVXgqNWM1PUuqv54VWTJRuKLBNUdMmJl8V9/bMLFsJ/f4vZ7AzYQM2ZWb+ctal7HwZOEvVxZkQ3ULYTSRrXaHGt35+Gmd7ho2G+cOCg3ti4Od/Aqe/4FFMoHmTMyHxbaiQpcmbp9N/kulPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kS+KFdX/62KQA61insdOu5dnTsYuS2Hy6x2nmZkHz+s=; b=QDkC9xx6DhULmC+F3nJhU8NQ/OH8DYXe+M+mNscm1EHIZe4RU5YBRw/fyXzLl1Uqb2Xv+rAcWeWvF7ZJMaAa3GU0JY7ZpCMNsWWYPba7+w3GmCg/PdfnVsG8XVFKGpB8wUaX5SfHAba+hzF6VWXHoAzxmuk3N+HDpg7Q/1tW+b3Y79zk/z8LnPza5WcAStDwU3n627f7JVoCjfeR8GhHcttrqT9/jOo4wnzShLpNZINMQEmizEilNUH50QfIHN6Fs6et7NY85rB47dvk3kO25L22Ux5b8UjPufSZJ2ekdgmOy0oHYV22MnCq5QxHyVn2u0DytarIdb/Cj82V/nYGGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kS+KFdX/62KQA61insdOu5dnTsYuS2Hy6x2nmZkHz+s=; b=IFNzURFHO9lPiMNT73bXuYzoqVeiBXGx9ItIbVM8Y4t5BVn2KWkzk2CmBNru8x8Q6Gl3EU3yTxa3Wmn3AUygCrJVG+4wJZGc2qpQo2o00mXgeZtBSyeKXhwZAccZZyGGw+yqpMLEXiypWNHYcdRyKRE0QF2k9h5DkXEfcfzxES0kOYMvmCyqMabgrcOyatRdzbU16RW2H++XK5qRK3dyb1JWH7LKa4buhtjdTa6WW7SjdzI9297Xg0wp/AZIaIlA4ENGFLtVdVw28N2Hn8OeRVBHZLTx2oSnFmIRDtKVXVOXhjn2XpeNj84DlSOk367hJbWBQBE0tb4q59n0XKyNOw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10793.eurprd04.prod.outlook.com (2603:10a6:102:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 11:52:44 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 11:52:44 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 19:51:29 +0800 Subject: [PATCH v2 3/3] ASoC: codec: wcd9335: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v2-3-773f67ce3b56@nxp.com> References: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Steev Klimaszewski , Johan Hovold Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742817094; l=2514; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=4mUyoIQOgr7LboU+OHDfVwrt16rnj5LwQLXfpKlgYHY=; b=zY9CbRM1ubURRwHAnynCEUrP6uTcXu1lbsA7IlzHvLVI4Zy0njFoGFWYPK48dARNcwCrWGlK0 qzQ0pBFKYFuDZ0j5uw+GTbH+5ovc+oXvvdQF6qfCpQiYeYBXGXir/4c X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10793:EE_ X-MS-Office365-Filtering-Correlation-Id: f62432f0-2ab2-4f7a-e28a-08dd6aca63ab X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?q4+e8bXO5iqCxnB4PNJruTcf1/O6OY5?= =?utf-8?q?3SWM47XarhrdccmgIWsHxYxsRMCf2wihtAeAvBYvJLkdF7wbqDYkI+4Qv3k+8+Ir8?= =?utf-8?q?LIMqofnqrSMhqIHK1tzlldmSEdXMSkb6dnAhqDRFxD5W3v20SarW7ZRRv06RMIRZo?= =?utf-8?q?A6pAoQCU985wUaBeZKJuppaqGx3aNWu43K6WObhz38NbmqaB9zP583QdrcKpEViu8?= =?utf-8?q?hIajfgYPzuTAXyXVoQidJ4u2wlYxexLouzFgIj3tvoHgE7A6tT1meb6yrO2vZr5TI?= =?utf-8?q?ZfGTR7bmTXHDM+VlC/QXoU2r9lAVJ7xOIwQoy+jJzRmGrVJ6zddALmF9NZqIi+lXq?= =?utf-8?q?URU5joGm/AKHe+vX3j6YpysxdMTNlcwlVVBzT5c63rRsGwDmECgzqAlMs1UlWt2Ar?= =?utf-8?q?SWO0e/9S0zZ/9Op0n4DgOvcYbP/PiX8D/1nM0T4MhsKKZdqzbRwWhniDh3+VX7eTg?= =?utf-8?q?nxp18mwt+jXJ4ceE+ZT2uB+4C6aG2B1evkDliBbJ+k1UPhjKlfUD2e8/5CW/eZJiJ?= =?utf-8?q?bE5sBQToU97cJWyP4ItlqYEjrfKNcUqiqsCUI1/yFsYDnQiN1a8jcJvVgQtuMlhHd?= =?utf-8?q?MQnfnUTMLZHZfC2B0JDu2a34SgSlDuof5wKKKl6MUa8Jdjs8t5OlyIz6nJLELYFm6?= =?utf-8?q?/TGsvoCS2An4W2gnMpDl5o7+mSLKh7my9z+MjPzvF2UXw6qeWwEV/2CEndoGqN6XM?= =?utf-8?q?5XpsfyaGfMy+AqVec/Qz7ANdPvaeEtL2eSvi/K7DgP8WzAH4b1kCzsY8Zs7c8R6Og?= =?utf-8?q?j4XMKiFhrKT+4wxQsTD9lelUIJFFtE50R7OeGH9RQ1WpH9ZU70DAv7RSXlKgUg0k2?= =?utf-8?q?ewawpNzlwMv6B3349LX4JcmRNyoWnJ6m/qEDmRx3NQTx+DGywmC47e+E9UlwTHNWS?= =?utf-8?q?bPh7/8QG2Mt1Z5DrT6XSY7fElRA3/rB9reli7ADdPCXy6V1KCxdCB4S8Ivb9Cr8E1?= =?utf-8?q?0SNJT1/+SdZ/XslqEag64fiNruQI7x6i/GlSCCjmDyQA/t139PMLbyf+0B9Y6dHca?= =?utf-8?q?A+I6dCmLVV1weSV44cjtrboSGTmqMh9Y1RiuZmSrjLqe1wPGq6TgiCDaU3wPN0XUJ?= =?utf-8?q?L7UW+kbJJ3AhrXVo+s+xdr71bjFg17xezObHzspS4CK4Z6saDQCjWxt4IemHMSEJw?= =?utf-8?q?vui9B7G/mfuEme6CosdaVzBj1bZySjUT2eLp/fOzrwIRc6TaZGZAK1mAejGXGYnWu?= =?utf-8?q?yVhcwt8TPK+aleXZFc2CE4N/ctzpZh9oZlPZ4uISjbv2OuDs0x0J3aGVa1lSgU0o4?= =?utf-8?q?jjxrSRTS9QFTUCcQ20XJhv9kWJAGHOSUZH1hH+LfHs6XlEKRHfCHtMv+vZKIi8tDD?= =?utf-8?q?Alw4lcs65ki+22Gm6qaLzR4PZB2wPQJmgN69J9nrHmTdpblKFyUdjqp+3UqOdYOEp?= =?utf-8?q?6/oONJZGPAM?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3/PLaztksu8DJF3q20uSbnFejdeO?= =?utf-8?q?/jtte8dt5NWl/3eTFGTtKpT5NhshEDpUsVELwshtTE+Quq6EYSnj/yNfH7F6YcKGj?= =?utf-8?q?tDJ3WSy0c7lAtl/95z3RxQLc+L+lt8bKfzIaiuRbzWlmuDjlkl6A1bm9djDGtnVqV?= =?utf-8?q?pxIcYp406Ju4+9QBldRXroLmhJtFfnuqaOh1FNSEfaHnRq29VgGJFIhQqVk6lVMSy?= =?utf-8?q?XLY3IhWWtMU7uE3pFCLIwx1hnOfoId8Y3Ig4+MhhFnQLNn28uvH8dNkGN665uhlon?= =?utf-8?q?r5IDXwxTRrDFjHaeXyuVPmvHOuFrW6AkDGQNhhFxTXgqnTvK018yxaXKKrsGBiIih?= =?utf-8?q?VAGyw7XMmAs5DEH8p24Xm9jyN2ytxHd9UtcKanWjJFZely24pEW4yvCAvLPIP1foh?= =?utf-8?q?eha4BTw4DJ40Zt2Jl8h6cb3Kt6XiYPb3PPNlu8HTsn8igGwMJrBOZTMfBcTmvuV8j?= =?utf-8?q?Q9LjWUrexTlD6n5EXcY1mBwBomCRJHJq1FQO7vUtAls0liWkpR+kZKzbkkhw1TtrP?= =?utf-8?q?B5b3MGbEjcwZ4NsulspB1B/KyR6uanDj8pBIFVRxs2RSy8x2+U0mx2VKf+4ZjoJqX?= =?utf-8?q?YHgFDj8j0hLUfKGtVbMx0S9UQqt2UJsis7LreC6QroDmokjbwnrkAGo/i0I0F0blr?= =?utf-8?q?CR6nWaxHESe3TQgwDSOgAlmczaI5Cq7PHHeoyoabjewSLBvFJTP86b35hekvOTbRJ?= =?utf-8?q?R86fZakndyz2b4k5fhcsZ28wAbY7nFjl5X3Eo5crdidw60CU1cBHujGVaqduicYOT?= =?utf-8?q?hvqjnGrxiEjoP6bAuVF2+tzKQaawYJxURUawCNATH/ts09JAzZ7k/bU0G6BXv5KwE?= =?utf-8?q?Z/YO9KBm3Unw+v9GmZ8gCAs5CXcAGEzxHdMrdcGRaTPrP3V6bBji3ZOREt4Rn5bxX?= =?utf-8?q?hU2VCoHC/FcrtOTmeTyno1za6MvLH6yESUcQ7pE4QGB1ZgOdkYbz46gQ5fx4OhuSp?= =?utf-8?q?QjpPpTo5rNSkIlD/EUPxC1U7ZxVhwdXJp21kz+IJMxvhEyHTpjxcUvppowouZBHbo?= =?utf-8?q?QN1CcQEgtqoavbT7A/8iSVcNuBV67jzdcI1KRbgSzgxEYrTZSzB4RHoo9Mk+VZo/L?= =?utf-8?q?LwYv7YWC1WLET4o4RGSgtdNjd9n3MP5NtzhOeo/QxNXMUrWZd61sTU4opPSSLj8vI?= =?utf-8?q?tbrosoG6W8mGtIDgp7GyGbvVgLYk3LEX4Lq4+4fSPaRrxCqc+JRzJFS2mnJpg+X/L?= =?utf-8?q?Disz2JDkM50wd1PBn7afgJY7XX4ais9PL6b0wrRA9CxbYJmsEsR9KsuTbRu6J49Ju?= =?utf-8?q?Y6CZCr0db3q+JiVrcmLrzx5PbQEiu9TTAVAiFLXeKV+G086TFrYyxeMuEjaG1PGlD?= =?utf-8?q?Z8kHN+E5KAA5hBL2QjozoeDjPeYn7MbAYySHRoQTURESTSRIt/RvNAePPCXqCADnB?= =?utf-8?q?utOXwqo64LhoWbXD07RPiX+9xpo7rl5Wzyx+2K/qfrwKUiPHewun4ODBxeTDG0LEs?= =?utf-8?q?ydEFAQeMB2M8Jy3fENCXaR4qWgInuC6FZQai/gtiTs4cNscgPK67NhjbvEp1jAIgh?= =?utf-8?q?zmJGscXlH4d/?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f62432f0-2ab2-4f7a-e28a-08dd6aca63ab X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 11:52:44.6516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eSChFngBnEma947wTlhZRLQaOihsUiYIHIzmTVOfFFd/tuToE7AcqSA6cW4AuNtudfoTqSAvIMJwjE7uXHuQow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10793 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_OUT_LOW when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. The in-tree DTS files have the right polarity set up already so we can expect this to "just work" Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Reviewed-by: Bartosz Golaszewski --- sound/soc/codecs/wcd9335.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 7cef43bb2a8800971604b0e1ac55aac26c5919bd..8ee4360aff9293178e338e3ef300c37f6f2ac809 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include @@ -331,7 +331,7 @@ struct wcd9335_codec { int comp_enabled[COMPANDER_MAX]; int intr1; - int reset_gpio; + struct gpio_desc *reset_gpio; struct regulator_bulk_data supplies[WCD9335_MAX_SUPPLY]; unsigned int rx_port_value[WCD9335_RX_MAX]; @@ -4975,12 +4975,11 @@ static const struct regmap_irq_chip wcd9335_regmap_irq1_chip = { static int wcd9335_parse_dt(struct wcd9335_codec *wcd) { struct device *dev = wcd->dev; - struct device_node *np = dev->of_node; int ret; - wcd->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0); - if (wcd->reset_gpio < 0) - return dev_err_probe(dev, wcd->reset_gpio, "Reset GPIO missing from DT\n"); + wcd->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(wcd->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd->reset_gpio), "Reset GPIO missing from DT\n"); wcd->mclk = devm_clk_get(dev, "mclk"); if (IS_ERR(wcd->mclk)) @@ -5023,9 +5022,9 @@ static int wcd9335_power_on_reset(struct wcd9335_codec *wcd) */ usleep_range(600, 650); - gpio_direction_output(wcd->reset_gpio, 0); + gpiod_set_value(wcd->reset_gpio, 1); msleep(20); - gpio_set_value(wcd->reset_gpio, 1); + gpiod_set_value(wcd->reset_gpio, 0); msleep(20); return 0;