From patchwork Fri May 22 13:15:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 6464331 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 98105C0020 for ; Fri, 22 May 2015 13:23:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BAB422038E for ; Fri, 22 May 2015 13:23:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 7E0A320390 for ; Fri, 22 May 2015 13:23:21 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7FBAA265CFA; Fri, 22 May 2015 15:23:20 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 772EF265CA5; Fri, 22 May 2015 15:20:18 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 99645265CA5; Fri, 22 May 2015 15:20:17 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by alsa0.perex.cz (Postfix) with ESMTP id AE406266189 for ; Fri, 22 May 2015 15:15:32 +0200 (CEST) Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0M1kWE-1ZApVK3XUQ-00tmFu; Fri, 22 May 2015 15:15:21 +0200 From: Arnd Bergmann To: Srinivas Kandagatla Date: Fri, 22 May 2015 15:15:15 +0200 Message-ID: <2168878.0V0FR6oKgi@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <2534276.hIjFJK74Zh@wuerfel> References: <1432245125-8939-1-git-send-email-srinivas.kandagatla@linaro.org> <1432245161-8990-1-git-send-email-srinivas.kandagatla@linaro.org> <2534276.hIjFJK74Zh@wuerfel> MIME-Version: 1.0 X-Provags-ID: V03:K0:v2uTxL0q1NGGjB2MuL0AFi0mbvLoOuL9PHYW9q8FjLfrk2OJSN7 H4PuKMW+WD8gTXyhLcZz9YBLWYU1+P5ZDGJ1/ighLMDlXhrxji4ENm11Nc+IKW3SS2zDLBe IWaAfVWvEz9hWnRfpagZV11INWxvmRIry7g7hkZyEWCh9vItMc7ioulO3t5nACui13vNQ52 tIEPDgI9XgMga6geDY/ew== X-UI-Out-Filterresults: notjunk:1; Cc: devicetree@vger.kernel.org, Kenneth Westfield , Banajit Goswami , Pawel Moll , Ian Campbell , Takashi Iwai , linux-kernel@vger.kernel.org, Patrick Lai , Liam Girdwood , Rob Herring , Mark Brown , Kumar Gala , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 22 May 2015 09:24:35 Arnd Bergmann wrote: > Could you instead make the drivers compile without OF being set? > > I see that patch 7 and 8 introduces another two options doing > > > +config SND_SOC_LPASS_APQ8016 > + tristate > + depends on SND_SOC_QCOM > + select SND_SOC_LPASS_CPU > + select SND_SOC_LPASS_PLATFORM > + > > +config SND_SOC_APQ8016_SBC > + tristate "SoC Audio support for APQ8016 SBC platforms" > + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST > + select SND_SOC_LPASS_APQ8016 > + help > > so you get an obvious build failure here when SND_SOC_APQ8016_SBC > gets selected with COMPILE_TEST on a platform that does not support OF. > > Actually, the patch 9bae4880acee ("ASoC: qcom: move ipq806x specific bits out of lpass driver.") already broke things more after I fixed it up. Please fold in this bit too before you send it again, and try to test the changes you send: Arnd diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index b30c2baa7501..08ebc9b8f915 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -20,7 +20,7 @@ config SND_SOC_LPASS_IPQ806X config SND_SOC_STORM tristate "ASoC I2S support for Storm boards" - depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST + depends on SND_SOC_QCOM && (ARCH_QCOM || COMPILE_TEST) select SND_SOC_LPASS_IPQ806X select SND_SOC_MAX98357A help