From patchwork Thu Jan 16 09:03:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Geoffrey D. Bennett" X-Patchwork-Id: 13941486 Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9FB91D63C8 for ; Thu, 16 Jan 2025 09:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.16.231.148 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737018228; cv=none; b=S4jRcObgEaTvR0VeDVX3L0sh/dYRhkLJEZAzmxZklAyCFzzbtnW96m+z4/hMTarGpFWxY1FOVwPHvGp1lQgR/KiJq3I1Tx8R9lqw5pVlK6lxR4Wji72JdWw4ndiHuWyJIgNlVuhV/e9dlpnsQ9uBtJyQobHTSNvDv4eQGuAhD0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737018228; c=relaxed/simple; bh=g9Y4M4s0GQu3ILho+7yEbrkac3+uwhE+ELeQ84R+Qh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NqMfSA3wKjBjjiJI+Ijn2KNF0M6fr463vbwO2oHp2Jem09NTg88Tjz1SzKVnjcc9g+PoEglnFrGBMiViv3tm4K/wdkAASislR36RZeFxKv83Y/BF/bjtKC+zg9doLKbhm+yTK8MmyFzYt1FJXPNaGkwiw2fscluSkXiNhOjhaZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=b4.vu; spf=pass smtp.mailfrom=b4.vu; dkim=pass (2048-bit key) header.d=b4.vu header.i=@b4.vu header.b=V8F/XwFG; arc=none smtp.client-ip=203.16.231.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=b4.vu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=b4.vu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=b4.vu header.i=@b4.vu header.b="V8F/XwFG" Received: by m.b4.vu (Postfix, from userid 1000) id 1B68664A5801; Thu, 16 Jan 2025 19:33:45 +1030 (ACDT) DKIM-Filter: OpenDKIM Filter v2.11.0 m.b4.vu 1B68664A5801 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=b4.vu; s=m1; t=1737018225; bh=I1c8cQW2h3IyL5mebxUFKL+d9rNVnhw0SGdH19EqGzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V8F/XwFG6pXYp9xKOFYR3YuFtWQ04sVa9T4mJup52vvh6EDsE/pHmIhOuSUDbgy/p 6uiyG11NENPXfe9ygl24RVCyqH0IPaj/29B6TClHlq43D0qFcMs5Qv31RzfeIMVsVa O7JA/XXwb1+5CYhdr0hue1OPOgiB3uK7J2NzlypyBc6Mc+/2IDuNNhzCub1thC8DgX zyITafJzb2lWoDIxeJaCWVnmizWOYrahcKLQuJ7ZH6DJUrPbELIWvXVeFGeFTyNTPo Mc74WYQUW5I0rJJDBk5LFXjPp8DoyUN9TPrLGzahe82D4z2aoKzTHCGdYfSeIu4WXT I4pnAevc6CIGw== Date: Thu, 16 Jan 2025 19:33:45 +1030 From: "Geoffrey D. Bennett" To: Takashi Iwai , Jaroslav Kysela Cc: Takashi Iwai , linux-sound@vger.kernel.org Subject: [PATCH v7 2/2] ALSA: scarlett2: Add device_setup option to use FCP driver Message-ID: <256585db253a6f9405f3ef239c8a2cbbb044ae1a.1737017960.git.g@b4.vu> References: Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Add a new device_setup option (SCARLETT2_USE_FCP_DRIVER = 0x08) that allows users to opt in to using the new FCP driver instead of the existing scarlett2 driver for their device. This provides a way to test the new FCP driver on existing supported hardware while keeping the Scarlett2 driver as the default. When the SCARLETT2_USE_FCP_DRIVER bit is set in device_setup, the scarlett2 driver initialisation will hand off to the FCP driver instead of proceeding with its own initialisation. The FCP driver then provides access to the device via its hwdep interface. Signed-off-by: Geoffrey D. Bennett --- sound/usb/mixer_scarlett2.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c index 7f595c1752a5..288d22e6a0b2 100644 --- a/sound/usb/mixer_scarlett2.c +++ b/sound/usb/mixer_scarlett2.c @@ -166,6 +166,7 @@ #include "helper.h" #include "mixer_scarlett2.h" +#include "fcp.h" /* device_setup value to allow turning MSD mode back on */ #define SCARLETT2_MSD_ENABLE 0x02 @@ -173,6 +174,9 @@ /* device_setup value to disable this mixer driver */ #define SCARLETT2_DISABLE 0x04 +/* device_setup value to use the FCP driver instead */ +#define SCARLETT2_USE_FCP_DRIVER 0x08 + /* some gui mixers can't handle negative ctl values */ #define SCARLETT2_VOLUME_BIAS 127 @@ -9702,6 +9706,10 @@ int snd_scarlett2_init(struct usb_mixer_interface *mixer) if (!mixer->protocol) return 0; + /* check if the user wants to use the FCP driver instead */ + if (chip->setup & SCARLETT2_USE_FCP_DRIVER) + return snd_fcp_init(mixer); + /* find entry in scarlett2_devices */ entry = get_scarlett2_device_entry(mixer); if (!entry) {