From patchwork Mon Sep 29 15:32:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4997591 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B7A149F2BA for ; Mon, 29 Sep 2014 15:33:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E89F5201B4 for ; Mon, 29 Sep 2014 15:33:08 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id CF01720173 for ; Mon, 29 Sep 2014 15:33:07 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id BC4E926063D; Mon, 29 Sep 2014 17:33:05 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 9A226260627; Mon, 29 Sep 2014 17:32:55 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A8A4E260631; Mon, 29 Sep 2014 17:32:53 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by alsa0.perex.cz (Postfix) with ESMTP id 7E515260607 for ; Mon, 29 Sep 2014 17:32:45 +0200 (CEST) Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue007) with ESMTP (Nemesis) id 0MLmVT-1XYtma2SJ9-000xc5; Mon, 29 Sep 2014 17:32:19 +0200 From: Arnd Bergmann To: broonie@kernel.org Date: Mon, 29 Sep 2014 17:32:17 +0200 Message-ID: <2771900.ce8bYznKIN@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:5Hpj/4Re0OPAH28TCGrYxUh0q3dg3qax8Zw+y4S6xw0 C4P4gbw11QT2JiZ4dXDW4K+DOT30zn3LZKy4BVrfYddKWNitRI Tb+OwC5xoPiDTm4PWsh6n+uX71XmtuCO69vLUAPi+0duH8LRZG ha25A+yqg+FpvKtITA3oYtgCUCzKfEvdn8hzwyyINtbS2NH7Sb YSQsK4HATB/7MjomflYGTyhUyNppuL+PPtN6aChP7mRR2j4XYY +/y8jcvymYhI9nRPwSb3b1b/faLcywtwFWS88AMrQJ5iq5dy4R OIO9DDuq1gjmbVSdTUpNoC1bkQPlPVGvGPOY1NulyB1+YF79f0 PFmbX4//z2jwtcWKJs7o= X-UI-Out-Filterresults: notjunk:1; Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com, Liam Girdwood , Peter Ujfalusi , linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH] ASoC: davinci: vcif must be a module if SND_DAVINCI_SOC is X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP It is possible to configure a kernel with SND_DAVINCI_SOC=m and SND_DM365_VOICE_CODEC=y, which results in a link error: sound/built-in.o: In function `davinci_vcif_probe': sound/soc/davinci/davinci-vcif.c:223: undefined reference to `davinci_soc_platform_register' The best way to avoid this is to make SND_DM365_VOICE_CODEC a tristate option that depends on SND_DAVINCI_SOC, so it can only be a module or disabled when the base driver is a loadable module Signed-off-by: Arnd Bergmann diff --git a/sound/soc/davinci/Kconfig b/sound/soc/davinci/Kconfig index d69510c53239..8e948c63f3d9 100644 --- a/sound/soc/davinci/Kconfig +++ b/sound/soc/davinci/Kconfig @@ -63,7 +63,8 @@ config SND_DM365_AIC3X_CODEC Say Y if you want to add support for AIC3101 audio codec config SND_DM365_VOICE_CODEC - bool "Voice Codec - CQ93VC" + tristate "Voice Codec - CQ93VC" + depends on SND_DAVINCI_SOC select MFD_DAVINCI_VOICECODEC select SND_DAVINCI_SOC_VCIF select SND_SOC_CQ0093VC