From patchwork Wed Nov 18 14:26:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7649631 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BEC509F1D3 for ; Wed, 18 Nov 2015 14:27:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B89B120620 for ; Wed, 18 Nov 2015 14:27:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 6B729205F7 for ; Wed, 18 Nov 2015 14:27:12 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9306126588E; Wed, 18 Nov 2015 15:27:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4BEE12658AB; Wed, 18 Nov 2015 15:26:38 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 02E3F26588E; Wed, 18 Nov 2015 15:26:37 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by alsa0.perex.cz (Postfix) with ESMTP id 8A173265A59 for ; Wed, 18 Nov 2015 15:26:14 +0100 (CET) Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0LnSZS-1aZmPF0rFe-00hbsv; Wed, 18 Nov 2015 15:26:03 +0100 From: Arnd Bergmann To: Mark Brown Date: Wed, 18 Nov 2015 15:26 +0100 Message-ID: <3706378.kEJZeaR6pv@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <11363089.F4JJ1Xsq7F@wuerfel> References: <11363089.F4JJ1Xsq7F@wuerfel> MIME-Version: 1.0 X-Provags-ID: V03:K0:mHScFvAEwg0+dledvbkiU4w0RH8mIxyr1XY7r7hJ/4GMJLskgB1 jhQIEX8jHdd+aJ/vnWDLB1LOKewl5qLO6azAMcakcwh0/s2pXdfp0TsnQFsOLvVY8k+E+xK ndVyeNCMjeizGAAKHOQrxrgM/XB/+wxV8rQPHdzU+lQy21Ob2QW55n0EI88sI+ENigC8IWt 30D/J6Ev8066fz5FCSz1g== X-UI-Out-Filterresults: notjunk:1; V01:K0:pkQlykCKOIc=:tm+T0H11l/dkyxYkpZ5uws tudfqzthuUPf/vy3XeyZseN88vWcMkZxiBGYF3VhwNApHbU+Lb8liroDHEFCv7HlljuQFqgN+ +NvEdSX4xvp7Ivw5eDRxw+JLUxL9nTUI9W6+WA661bWXfDn3cvPfZOzT4lW2YJJmeupH+H8mw BKOfnoS7j/V9wedM9n3ZXwXC7YPBzsmfJoL5TwWhIZThnmn/kxpRgPrYbsFL8ci+nsWRdzm4R hZZ/Cgt6+sgerUl2VZ/Q2nyLq95Jxjs62pU5hTbtU4Hcdem1ynvSLrlZGhkUsWX/aANns7tyk ana7x/nVIav97Gy6vw7J8PhYMA9A/cbYScHUfbxhn22PP17fLf/aqxpQuDreELNwg5BBjOVgR viXNi0rLQMDC/xH2wPUKfJRT5q2YDYLNeySsDVVEDJrj0tdyRTShj3ATsOcUTnCVWIIUm4ps8 4HYFlDw8Soz1CyT+HIZwXq1PVxXUqv3/96s6+E0WR2K7o3UYvWuErql+kf+Xx37Y9ww4mWcfF dA12PxCZhBB0oMSV1QeK5gt68PA95ixP/1jiGWIK0Rd6H81eap0ysuk1c45Aax25hNiAPbguv Gs0MOcq7zZNpbS3nKralLFLHLvwafFqiVnWAOfh+sj/3K4CcHXTJ7Mhzc6Kn+h/DlYQj7NFVy u2n/uOwG/sdGPbEv98XoptOgKIzEzjcneayIPStJcp4Dh+ORqaLzlUzZJ9gY0kNLxFsoW2XQO x6LqoX+HGB3feGqq Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Sangbeom Kim , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Liam Girdwood , Vinod Koul , Kukjin Kim , linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH v3 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s drivers independent of the mach/dma.h header file and to allow removing the dependency on the specific dmaengine driver in the next patch. As a side not, only the s3c24xx-i2s driver seems to still be used, while the definition of the s3c2412-i2s platform device was removed in commit 6d259a25b56d ("ARM: SAMSUNG: use static declaration when it is not used in other files") after it had never been referenced since its introduction in f0fba2ad1b6b ("ASoC: multi-component - ASoC Multi-Component Support"). Apparently it should have been used by mach-jive.c, but that never happened. My patch at this point leaves the current state unchanged, we can decide whether to fix or delete the jive driver and s3c2412-i2s another time. Signed-off-by: Arnd Bergmann Reviewed-by: Krzysztof Kozlowski --- v3 changes: fix typo in s3c24xx-i2s.c v2 changes: check for NULL pdata diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c index 69fa6a194fdf..b78b4f3ea170 100644 --- a/arch/arm/plat-samsung/devs.c +++ b/arch/arm/plat-samsung/devs.c @@ -571,6 +571,11 @@ static struct resource s3c_iis_resource[] = { [0] = DEFINE_RES_MEM(S3C24XX_PA_IIS, S3C24XX_SZ_IIS), }; +static struct s3c_audio_pdata s3c_iis_platdata = { + .dma_playback = (void *)DMACH_I2S_OUT, + .dma_capture = (void *)DMACH_I2S_IN, +}; + struct platform_device s3c_device_iis = { .name = "s3c24xx-iis", .id = -1, @@ -579,6 +584,7 @@ struct platform_device s3c_device_iis = { .dev = { .dma_mask = &samsung_device_dma_mask, .coherent_dma_mask = DMA_BIT_MASK(32), + .platform_data = &s3c_iis_platdata, } }; #endif /* CONFIG_PLAT_S3C24XX */ diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c index 77d27c85a32a..105317f523f2 100644 --- a/sound/soc/samsung/s3c2412-i2s.c +++ b/sound/soc/samsung/s3c2412-i2s.c @@ -33,14 +33,14 @@ #include "regs-i2s-v2.h" #include "s3c2412-i2s.h" +#include + static struct s3c_dma_params s3c2412_i2s_pcm_stereo_out = { - .slave = (void *)(uintptr_t)DMACH_I2S_OUT, .ch_name = "tx", .dma_size = 4, }; static struct s3c_dma_params s3c2412_i2s_pcm_stereo_in = { - .slave = (void *)(uintptr_t)DMACH_I2S_IN, .ch_name = "rx", .dma_size = 4, }; @@ -152,6 +152,12 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev) { int ret = 0; struct resource *res; + struct s3c_audio_pdata *pdata = dev_get_platdata(&pdev->dev); + + if (!pdata) { + dev_err(&pdev->dev, "missing platform data"); + return -ENXIO; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); s3c2412_i2s.regs = devm_ioremap_resource(&pdev->dev, res); @@ -159,7 +165,9 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev) return PTR_ERR(s3c2412_i2s.regs); s3c2412_i2s_pcm_stereo_out.dma_addr = res->start + S3C2412_IISTXD; + s3c2412_i2s_pcm_stereo_out.slave = pdata->dma_playback; s3c2412_i2s_pcm_stereo_in.dma_addr = res->start + S3C2412_IISRXD; + s3c2412_i2s_pcm_stereo_in.slave = pdata->dma_capture; ret = s3c_i2sv2_register_component(&pdev->dev, -1, &s3c2412_i2s_component, diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c index 9da3a77ea2c7..9e6a5bc012e3 100644 --- a/sound/soc/samsung/s3c24xx-i2s.c +++ b/sound/soc/samsung/s3c24xx-i2s.c @@ -31,14 +31,14 @@ #include "dma.h" #include "s3c24xx-i2s.h" +#include + static struct s3c_dma_params s3c24xx_i2s_pcm_stereo_out = { - .slave = (void *)(uintptr_t)DMACH_I2S_OUT, .ch_name = "tx", .dma_size = 2, }; static struct s3c_dma_params s3c24xx_i2s_pcm_stereo_in = { - .slave = (void *)(uintptr_t)DMACH_I2S_IN, .ch_name = "rx", .dma_size = 2, }; @@ -454,6 +454,12 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev) { int ret = 0; struct resource *res; + struct s3c_audio_pdata *pdata = dev_get_platdata(&pdev->dev); + + if (!pdata) { + dev_err(&pdev->dev, "missing platform data"); + return -ENXIO; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) { @@ -465,7 +471,9 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev) return PTR_ERR(s3c24xx_i2s.regs); s3c24xx_i2s_pcm_stereo_out.dma_addr = res->start + S3C2410_IISFIFO; + s3c24xx_i2s_pcm_stereo_out.slave = pdata->dma_playback; s3c24xx_i2s_pcm_stereo_in.dma_addr = res->start + S3C2410_IISFIFO; + s3c24xx_i2s_pcm_stereo_in.slave = pdata->dma_capture; ret = devm_snd_soc_register_component(&pdev->dev, &s3c24xx_i2s_component, &s3c24xx_i2s_dai, 1);