| Message ID | 3dc9167d-fb33-43a6-baa6-dbef8b5da7b9@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 19adbe96d3e3c2188ad5838b936550e073cba54d |
| Headers | show |
| Series | ALSA: hda: generic: Remove obsolete call to ledtrig_audio_get | expand |
On Sat, 13 Jan 2024 17:08:54 +0100, Heiner Kallweit wrote: > > Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to > ensure the initial brightness is set") the audio triggers have an > activate callback which sets the LED brightness as soon as the > (default) trigger is bound to the LED device. So we can remove the > call to ledtrig_audio_get. > > Positive side effect: We have no code dependency to ledtrig-audio any > longer, therefore, if built as module, it's no longer loaded if not > needed. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Thanks, applied now. Takashi
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index bf685d012..de2a3d08c 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -3946,7 +3946,6 @@ static int create_mute_led_cdev(struct hda_codec *codec, cdev->max_brightness = 1; cdev->default_trigger = micmute ? "audio-micmute" : "audio-mute"; cdev->brightness_set_blocking = callback; - cdev->brightness = ledtrig_audio_get(idx); cdev->flags = LED_CORE_SUSPENDRESUME; err = led_classdev_register(&codec->core.dev, cdev);
Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to ensure the initial brightness is set") the audio triggers have an activate callback which sets the LED brightness as soon as the (default) trigger is bound to the LED device. So we can remove the call to ledtrig_audio_get. Positive side effect: We have no code dependency to ledtrig-audio any longer, therefore, if built as module, it's no longer loaded if not needed. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- sound/pci/hda/hda_generic.c | 1 - 1 file changed, 1 deletion(-)