From patchwork Wed Nov 18 21:16:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7652691 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D606ABF90C for ; Wed, 18 Nov 2015 21:17:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B5AA204AD for ; Wed, 18 Nov 2015 21:17:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id BCA03204A9 for ; Wed, 18 Nov 2015 21:17:11 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id C73D3265B69; Wed, 18 Nov 2015 22:17:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 25E3F265A69; Wed, 18 Nov 2015 22:17:02 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D20CF265A7B; Wed, 18 Nov 2015 22:17:00 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by alsa0.perex.cz (Postfix) with ESMTP id C3E8D265A36 for ; Wed, 18 Nov 2015 22:16:53 +0100 (CET) Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0MCIPR-1a8CeY1cu1-009AGy; Wed, 18 Nov 2015 22:16:51 +0100 From: Arnd Bergmann To: broonie@kernel.org Date: Wed, 18 Nov 2015 22:16:48 +0100 Message-ID: <4237757.xIRJLSDgsa@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:KdOAgrCc9uueetkiShOFpSXI4UvVexOCClxhVz3NVjJGGbVno33 JiIIn5CRb+1nvdx1fW6NLrydBJfg0aQuC8KyZi48eHJHishe3Bb6iB6Dw2G1O+2oLik8QdE QLShlTLwNcrPZoLx3/UVq3ZKBWys7R34cEr5WCJ1Na0flytM5tkEgtDSyv4QJ0qkf2fROF1 bsuekBGjz4wgQIFk1r6MA== X-UI-Out-Filterresults: notjunk:1; V01:K0:Shyg/It6p0E=:k2nIJglBf7FBBZBJ7xpYrv BHSVFrhWdXniaSlayJUQGnVVUyNnimthezBIUSQAt4iaz/N0OJ7YccR28KEkEkgxB94uh2Fds TS8IvUYkwUN8xbrI+Lb8kcLRC+n9yXvZaJOCtN4WlTb50Iq5cSW7KV9JTMJquvbRkWC7Ty77X rMR4QBSZfQL9w58tziT+P8ZW13Fy2qgq65bIcqfxECRykzRebN227VdtBnnpLExepwbmj+pJ+ xaK5Gl54ZtHxeOeaAtJ5h0yg9aH/Qg5XjxVecm2TjfKaG7PBimOIyjvhSONpwF0nIWbp6obwj 9hSFDctyAOFz8KdAJoHJE8SM4GWCxibX/nBialI/YSbcZCFCBrqqflm+IlKrTv03r0ZgjoFbT vGGHUy6dgsEca6HwrCInSXDj9CeFQOT3zmbvlCqWZJiUpa1xUetCYSbMZiF4GYpkQoYO3XHQN 8fiG2i0RZkED5FTomafJv8ycpRSq/mISDSMxL623mR53m2MB6SSSOwo8ihMRfJzk4KcBA0eWT 0FcXSYGQmDgbSVqHCPU2y7t9kaKMBDKYABF1829/ouKJrr8Vjb1ZV3JomSWL5GhU3Bfzf6z0O cawwgMUnt+XCMdFjNXq8y8kzWzEXihLuaS9+55mDBqxb4KUvN1P5tdvbkI5WKwvTvKRyepP6t m0vx8iuzHJeACoY8wvtwFUhyZosGC3Osu9YQbyr6Xld1rprP04cBpVHTNuuLjTJYwhS3IE9Oh wOfb7gd7+2dIdtsV Cc: alsa-devel@alsa-project.org, linux-sh@vger.kernel.org, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, horms+renesas@verge.net.au, linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH] ASoC: sh: fix fsi build warnings for 64 bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP As this driver can now be compiled for ARM64, we get a new warning as a result of passing a DMA filter data pointer through an 'int': sound/soc/sh/fsi.c: In function 'fsi_dma_probe': sound/soc/sh/fsi.c:1372:24: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] shdma_chan_filter, (void *)io->dma_id, We already know that we only need the legacy filter function on arch/sh, so we can hide the legacy DMA interface function behind an #ifdef. This has the other advantage of no longer depending on the shdma_chan_filter function to be visible. Signed-off-by: Arnd Bergmann diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c index 0215c78cbddf..ead520182e26 100644 --- a/sound/soc/sh/fsi.c +++ b/sound/soc/sh/fsi.c @@ -1362,15 +1362,18 @@ static int fsi_dma_push_start_stop(struct fsi_priv *fsi, struct fsi_stream *io, static int fsi_dma_probe(struct fsi_priv *fsi, struct fsi_stream *io, struct device *dev) { - dma_cap_mask_t mask; int is_play = fsi_stream_is_play(fsi, io); +#ifdef CONFIG_SUPERH + dma_cap_mask_t mask; dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); - io->chan = dma_request_slave_channel_compat(mask, - shdma_chan_filter, (void *)io->dma_id, - dev, is_play ? "tx" : "rx"); + io->chan = dma_request_channel(mask, shdma_chan_filter, + (void *)io->dma_id); +#else + io->chan = dma_request_slave_channel(dev, is_play ? "tx" : "rx"); +#endif if (io->chan) { struct dma_slave_config cfg = {}; int ret;