From patchwork Tue May 10 15:11:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Thomson X-Patchwork-Id: 9058871 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 69900BF29F for ; Tue, 10 May 2016 15:13:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFD2820149 for ; Tue, 10 May 2016 15:13:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 9E13720148 for ; Tue, 10 May 2016 15:13:32 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 463E7266199; Tue, 10 May 2016 17:13:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1B56B26578F; Tue, 10 May 2016 17:11:26 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id EE85E265D63; Tue, 10 May 2016 17:11:24 +0200 (CEST) Received: from mail1.bemta5.messagelabs.com (mail1.bemta5.messagelabs.com [195.245.231.139]) by alsa0.perex.cz (Postfix) with ESMTP id 9A8952652EE for ; Tue, 10 May 2016 17:11:09 +0200 (CEST) Received: from [85.158.139.19] by server-3.bemta-5.messagelabs.com id 19/48-29997-D0AF1375; Tue, 10 May 2016 15:11:09 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRWlGSWpSXmKPExsUSt3OpsS7vL8N wg0P/WC2uXDzEZDH14RM2i29XOpgsLu+aw2bRuauf1WLD97WMDmweGz43sXnsnHWX3WPTqk42 j31vl7F5rN9ylcXj8ya5ALYo1sy8pPyKBNaM1bPusBZMZq/oWjuZrYGxi62LkYtDSGA9o8S+C b8Zuxg5gJwKie7FNl2MnBy8ApkSHf2vmUBsTgF3iY/717CA2EICbhIHpzaxg9hsAhYSk088YA OxWQRUJe5eOwsWFxYIkWi6PRtsvohAF6PE6lePwRLMAuUSZzctYoNYIChxcuYTFoi4hMTBFy+ YIRYYSJxe0AgWlxCwl5j+/iozyG0SAvoSjcdiIcKGEt9nfYMqMZc4v2Aa+wRGwVlIps5CMnUB I9MqRo3i1KKy1CJdQxO9pKLM9IyS3MTMHF1DA1O93NTi4sT01JzEpGK95PzcTYzA8GcAgh2MZ 097HmKU5GBSEuUVnGIYLsSXlJ9SmZFYnBFfVJqTWnyIUYaDQ0mCd9IPoJxgUWp6akVaZg4wEm HSEhw8SiK8qSBp3uKCxNzizHSI1ClGXY4FP26vZRJiycvPS5US550AUiQAUpRRmgc3ApYULjH KSgnzMgIdJcRTkFqUm1mCKv+KUZyDUUmYtxlkCk9mXgncpldARzABHSHHpg9yREkiQkqqgdEq KPyGetND0a/7VqslT1FxqzS+0RJnlXHHt2XdjP4j0ck7t4T8+Px4oUZF3JsZMplHDjzVXeHcF 9cz3c97xgo1aVfB2tWTdgbkc0b82mHd5KuVrcswe0Lop0nSs/pc9QR+ZnFX//1QZ88qenravn WJh+pOK5y7sMFh/lYd59Sui4nmfWyq65VYijMSDbWYi4oTAZIuzXQFAwAA X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-15.tower-178.messagelabs.com!1462893068!37981694!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3734 invoked from network); 10 May 2016 15:11:09 -0000 Received: from mailrelay2.diasemi.com (HELO sw-ex-cashub01.diasemi.com) (94.185.165.51) by server-15.tower-178.messagelabs.com with AES128-SHA encrypted SMTP; 10 May 2016 15:11:09 -0000 Received: from swsrvapps-01.diasemi.com (10.20.28.141) by SW-EX-CASHUB01.diasemi.com (10.20.16.140) with Microsoft SMTP Server id 14.3.248.2; Tue, 10 May 2016 16:11:09 +0100 Received: by swsrvapps-01.diasemi.com (Postfix, from userid 22379) id 7009E3FAFC; Tue, 10 May 2016 16:11:08 +0100 (BST) Message-ID: <4af28c42abc15713e6746ea39d82869f98ddf771.1462892732.git.Adam.Thomson.Opensource@diasemi.com> In-Reply-To: References: From: Adam Thomson Date: Tue, 10 May 2016 16:11:08 +0100 To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai MIME-Version: 1.0 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 10/05/2016 13:08:00 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Support Opensource Subject: [alsa-devel] [PATCH 5/5] ASoC: da7213: Allow PLL disable/bypass when using 32KHz sysclk X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Current checking for PLL 32KHz mode fails in driver code when bypassing the PLL. This is due to an incorrect check of PLL source type when 32KHz clock is provided. Removal of this check resolves the issue. Signed-off-by: Adam Thomson --- sound/soc/codecs/da7213.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c index a233fe7..e5527bc 100644 --- a/sound/soc/codecs/da7213.c +++ b/sound/soc/codecs/da7213.c @@ -1342,7 +1342,7 @@ static int da7213_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id, pll_ctrl = 0; /* Workout input divider based on MCLK rate */ - if ((da7213->mclk_rate == 32768) && (source == DA7213_SYSCLK_PLL)) { + if (da7213->mclk_rate == 32768) { /* 32KHz PLL Mode */ indiv_bits = DA7213_PLL_INDIV_9_TO_18_MHZ; indiv = DA7213_PLL_INDIV_9_TO_18_MHZ_VAL;