| Message ID | 5233faeef4073f33e2826866eae35e8c9502c35f.1450807642.git.Adam.Thomson.Opensource@diasemi.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ff099790412cb46536efba02039b36d81300976 |
| Headers | show |
On Tue, Dec 22, 2015 at 06:27:53PM +0000, Adam Thomson wrote: > In current AB silicon, BIAS_EN field is enabled by default in the > REFERENCES register, so the regmap default value should reflect > this. This is the sort of thing where a register patch would normally be used - if you put in a register patch for the older silicon then the driver can correct for the register default automatically.
On December 23, 2015 00:10, Mark Brown wrote: > On Tue, Dec 22, 2015 at 06:27:53PM +0000, Adam Thomson wrote: > > In current AB silicon, BIAS_EN field is enabled by default in the > > REFERENCES register, so the regmap default value should reflect > > this. > > This is the sort of thing where a register patch would normally be used > - if you put in a register patch for the older silicon then the driver > can correct for the register default automatically. Thanks. Yes, am aware of that. Were the older silicon still in use then I'd have taken that route, but didn't seem necessary in this instance.
On Wed, Dec 23, 2015 at 09:47:23AM +0000, Opensource [Adam Thomson] wrote: > On December 23, 2015 00:10, Mark Brown wrote: > > This is the sort of thing where a register patch would normally be used > > - if you put in a register patch for the older silicon then the driver > > can correct for the register default automatically. > Thanks. Yes, am aware of that. Were the older silicon still in use then I'd have > taken that route, but didn't seem necessary in this instance. It costs you nothing to do it properly and you might be surprised how often older silicon turns up somewhere.
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 253d8e7..3502c13 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1788,7 +1788,7 @@ static struct reg_default da7219_reg_defaults[] = { { DA7219_DIG_ROUTING_DAC, 0x32 }, { DA7219_DAI_OFFSET_LOWER, 0x00 }, { DA7219_DAI_OFFSET_UPPER, 0x00 }, - { DA7219_REFERENCES, 0x00 }, + { DA7219_REFERENCES, 0x08 }, { DA7219_MIXIN_L_SELECT, 0x00 }, { DA7219_MIXIN_L_GAIN, 0x03 }, { DA7219_ADC_L_GAIN, 0x6F },
In current AB silicon, BIAS_EN field is enabled by default in the REFERENCES register, so the regmap default value should reflect this. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> --- sound/soc/codecs/da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)