From patchwork Tue May 27 04:13:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Sakamoto X-Patchwork-Id: 4245991 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E73D1BF90B for ; Tue, 27 May 2014 04:14:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3248B20266 for ; Tue, 27 May 2014 04:14:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id A62F720263 for ; Tue, 27 May 2014 04:14:03 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3547D2654EA; Tue, 27 May 2014 06:14:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id E95112654B9; Tue, 27 May 2014 06:13:48 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6F38D2654BE; Tue, 27 May 2014 06:13:47 +0200 (CEST) Received: from smtp303.phy.lolipop.jp (smtp303.phy.lolipop.jp [210.157.22.87]) by alsa0.perex.cz (Postfix) with ESMTP id C978D2654B2 for ; Tue, 27 May 2014 06:13:37 +0200 (CEST) Received: from smtp303.phy.lolipop.lan (HELO smtp303.phy.lolipop.jp) (172.17.1.87) (smtp-auth username m12129643-o-takashi, mechanism plain) by smtp303.phy.lolipop.jp (qpsmtpd/0.82) with ESMTPA; Tue, 27 May 2014 13:13:32 +0900 Received: from 127.0.0.1 (127.0.0.1) by smtp303.phy.lolipop.jp (LOLIPOP-Fsecure); Tue, 27 May 2014 13:13:26 +0900 (JST) X-Virus-Status: clean(LOLIPOP-Fsecure) Message-ID: <538410E5.8080909@sakamocchi.jp> Date: Tue, 27 May 2014 13:13:25 +0900 From: Takashi Sakamoto User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Takashi Iwai , Clemens Ladisch References: <1398433530-13136-1-git-send-email-o-takashi@sakamocchi.jp> <538185B4.6010909@sakamocchi.jp> <5382FE3B.2010507@ladisch.de> <5383C41D.4020103@sakamocchi.jp> In-Reply-To: <5383C41D.4020103@sakamocchi.jp> X-Enigmail-Version: 1.5.2 Cc: alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net, ffado-devel@lists.sf.net Subject: Re: [alsa-devel] [PATCH 00/49 v4] Enhancement for support of Firewire devices X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Iwai-san, Attached files are fixups for each patches. I think it better to renew patches because there're somewhat much lines to be modified. Regards Takashi Sakamoto o-takashi@sakamocchi.jp (May 27 2014 07:45), Takashi Sakamoto wrote: > Iwai-san, > > (May 26 2014 21:38), Takashi Iwai wrote: >> Meanwhile I applied the patches to topic/firewire branch and put to my >> build test bot. I'll merge the branch to for-next tomorrow if no one >> gives objections. > > Thanks for your applying this patchset to topic/firewire branch. I > receive some sparse messages from kbuild test backend. There're several > codes which should be fixed, mainly for type conflict. > > I want you to apply revised patchset. I've already done most of this > work for revised patchset. > > Should I post them as new patchset? Or post new patches to previous > patchset? > > > Thanks > > Takashi Sakamoto > o-takashi@sakamocchi.jp From b12634cce5b43885a40cd5fdde4975e6824bf274 Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Tue, 27 May 2014 11:27:44 +0900 Subject: fixup for [PATCH 48/49] Prevent from narrowing conversion. Signed-off-by: Takashi Sakamoto --- sound/firewire/bebob/bebob_maudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c index cf3abb9..4c61709 100644 --- a/sound/firewire/bebob/bebob_maudio.c +++ b/sound/firewire/bebob/bebob_maudio.c @@ -111,7 +111,7 @@ int snd_bebob_maudio_load_firmware(struct fw_unit *unit) * firmware version 5058 or later has date later than "20070401", but * 'date' is not null-terminated. */ - if (date < 0x3230303730343031) { + if (date < 0x3230303730343031LL) { dev_err(&unit->device, "Use firmware version 5058 or later\n"); err = -ENOSYS; -- 1.8.3.2