diff mbox

ASoC: CS42L51_I2C depends on I2C

Message ID 5453CCCF.5090201@infradead.org (mailing list archive)
State Accepted
Commit e894beb8183dd9e3834983440900ceb632823676
Headers show

Commit Message

Randy Dunlap Oct. 31, 2014, 5:54 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_I2C is not enabled by making the
driver depend on I2C.

../sound/soc/codecs/cs42l51-i2c.c:55:1: warning: data definition has no type or storage class [enabled by default]
 module_i2c_driver(cs42l51_i2c_driver);
 ^
../sound/soc/codecs/cs42l51-i2c.c:55:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
../sound/soc/codecs/cs42l51-i2c.c:55:1: warning: parameter names (without types) in function declaration [enabled by default]
../sound/soc/codecs/cs42l51-i2c.c:45:26: warning: 'cs42l51_i2c_driver' defined but not used [-Wunused-variable]
 static struct i2c_driver cs42l51_i2c_driver = {
                          ^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 sound/soc/codecs/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Austin, Brian Oct. 31, 2014, 7:22 p.m. UTC | #1 
On Fri, 31 Oct 2014, Randy Dunlap wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when CONFIG_I2C is not enabled by making the
> driver depend on I2C.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Brian Austin <brian.austin@cirrus.com>

Thanks for submitting this. Sorry I dropped it
Brian
Mark Brown Oct. 31, 2014, 7:26 p.m. UTC | #2 
On Fri, Oct 31, 2014 at 10:54:23AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when CONFIG_I2C is not enabled by making the
> driver depend on I2C.

Applied, please do try to follow the changelog style for the subsystem.
diff mbox

Patch

--- linux-next-20141031.orig/sound/soc/codecs/Kconfig
+++ linux-next-20141031/sound/soc/codecs/Kconfig
@@ -338,6 +338,7 @@  config SND_SOC_CS42L51
 
 config SND_SOC_CS42L51_I2C
 	tristate "Cirrus Logic CS42L51 CODEC (I2C)"
+	depends on I2C
 	select SND_SOC_CS42L51
 
 config SND_SOC_CS42L52