From patchwork Wed Nov 5 21:17:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Clemens Ladisch X-Patchwork-Id: 5238221 X-Patchwork-Delegate: tiwai@suse.de Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A86E1C11AC for ; Wed, 5 Nov 2014 21:18:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7EFDE2012F for ; Wed, 5 Nov 2014 21:17:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 38C7E200F3 for ; Wed, 5 Nov 2014 21:17:57 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 13998261537; Wed, 5 Nov 2014 22:17:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 8522B261537; Wed, 5 Nov 2014 22:17:44 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 94D6726153C; Wed, 5 Nov 2014 22:17:42 +0100 (CET) Received: from dehamd003.servertools24.de (dehamd003.servertools24.de [31.47.254.18]) by alsa0.perex.cz (Postfix) with ESMTP id 60CEF2614FF for ; Wed, 5 Nov 2014 22:17:34 +0100 (CET) Received: from [192.168.42.157] (tmo-106-34.customers.d1-online.com [80.187.106.34]) by dehamd003.servertools24.de (Postfix) with ESMTPSA id C28C4F8018; Wed, 5 Nov 2014 22:16:18 +0100 (CET) Message-ID: <545A93E3.7020906@ladisch.de> Date: Wed, 05 Nov 2014 22:17:23 +0100 From: Clemens Ladisch User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Cyrus Harmon , alsa-devel@alsa-project.org References: <1394388767-23658-1-git-send-email-cyrus@bobobeach.com> <531DAB14.5080201@ladisch.de> <76F78615-8762-4A6C-B601-97380805F450@bobobeach.com> <531DDD04.5050902@ladisch.de> <0EFBCC9F-93CA-4368-9530-B9049B3743FB@bobobeach.com> <531EC9CC.4060203@ladisch.de> <88C9DBF9-92A3-4885-87C5-A9966C326D0F@bobobeach.com> <545895AD.7020004@ladisch.de> <545A697C.5070800@bobobeach.com> In-Reply-To: <545A697C.5070800@bobobeach.com> X-PPP-Message-ID: <20141105211619.160314.88045@dehamd003.servertools24.de> X-PPP-Vhost: ladisch.de Subject: Re: [alsa-devel] [PATCH] add Steinberg UR44 USB Audio Interface support to quirks-table X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Cyrus Harmon wrote: > [ 2.964094] snd-usb-audio 3-3.2:1.0: checking PCM interface > [ 2.964104] snd-usb-audio: probe of 3-3.2:1.0 failed with error -5 > [ 2.966339] snd-usb-audio 3-3.2:1.1: checking PCM interface > [ 2.966341] snd-usb-audio 3-3.2:1.1: altsets found > [ 2.966342] snd-usb-audio 3-3.2:1.1: endpoint found > [ 2.966343] snd-usb-audio 3-3.2:1.1: iso found > [ 2.966344] snd-usb-audio 3-3.2:1.1: descriptors found > [ 2.968544] usb 3-3.2:1.0: checking PCM interface > [ 2.968546] usb 3-3.2:1.2: checking PCM interface > [ 2.968547] usb 3-3.2:1.2: altsets found > [ 2.968547] usb 3-3.2:1.2: endpoint found > [ 2.968548] usb 3-3.2:1.2: iso found > [ 2.968549] usb 3-3.2:1.2: descriptors found > [ 2.970657] usb 3-3.2:1.3: checking PCM interface > [ 2.970666] usb 3-3.2:1.4: checking PCM interface > [ 2.970930] snd-usb-audio: probe of 3-3.2:1.1 failed with error -5 Strange; in theory, this cannot happen. Please add this patch and try again. Regards, Clemens --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -536,7 +536,9 @@ snd_usb_audio_probe(struct usb_device *dev, err = 1; /* continue */ if (quirk && quirk->ifnum != QUIRK_NO_INTERFACE) { /* need some special handlings */ - if ((err = snd_usb_create_quirk(chip, intf, &usb_audio_driver, quirk)) < 0) + err = snd_usb_create_quirk(chip, intf, &usb_audio_driver, quirk); + dev_info(&intf->dev, "quirk return code: %d\n", err); + if (err < 0) goto __error; } @@ -547,11 +549,13 @@ snd_usb_audio_probe(struct usb_device *dev, goto __error; } } + dev_info(&intf->dev, "probe step 2\n"); /* we are allowed to call snd_card_register() many times */ if (snd_card_register(chip->card) < 0) { goto __error; } + dev_info(&intf->dev, "probe step 3\n"); usb_chip[chip->index] = chip; chip->num_interfaces++; @@ -560,6 +564,7 @@ snd_usb_audio_probe(struct usb_device *dev, return chip; __error: + dev_info(&intf->dev, "probe failed\n"); if (chip) { if (!chip->num_interfaces) snd_card_free(chip->card); --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -367,6 +367,7 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip, err = create_autodetect_quirk(chip, iface, driver); if (err < 0) return err; + dev_info(&iface->dev, "first interface successful\n"); /* * ALSA PCM playback/capture devices cannot be registered in two steps, @@ -385,9 +386,13 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip, err = create_autodetect_quirk(chip, iface, driver); if (err >= 0) + { usb_driver_claim_interface(driver, iface, (void *)-1L); + dev_info(&iface->dev, "interface %d successful\n", ifnum); + } } + dev_info(&iface->dev, "create_autodetect_quirks successful\n"); return 0; }