diff mbox

add Steinberg UR44 USB Audio Interface support to quirks-table

Message ID 545B07DB.6070200@bobobeach.com (mailing list archive)
State Superseded
Delegated to: Takashi Iwai
Headers show

Commit Message

Cyrus Harmon Nov. 6, 2014, 5:32 a.m. UTC
I think UR22 works! I'm just aping the UR22 support to work for UR44!

But, here it is:

  YAMAHA_DEVICE(0x2002, NULL),



On 11/05/2014 09:28 PM, Vlad Catoi wrote:
> Cyrus,
>
> Pass it along, I can try it on the UR22 as well.
>
> ~Vlad
>
> On Wed, 2014-11-05 at 20:39 -0800, Cyrus Harmon wrote:
>> Hi Takashi,
>>
>> Clemens has sent me another diagnostic/debugging patch to try. Perhaps
>> we should wait to see the results of that before pushing to for-next. If
>> we don't get a deeper understanding of the problem in the next couple of
>> days, I'll send along the original patch.
>>
>> thanks,
>>
>> Cyrus
>>
>> On 11/05/2014 03:14 PM, Takashi Iwai wrote:
>>> At Tue, 04 Nov 2014 00:55:11 -0800,
>>> Cyrus Harmon wrote:
>>>> I have used a number of 3.1x kernels. At the moment, I'm writing this
>>>> from a 3.17.0 kernel that doesn't recognize the UR44 without my patch.
>>> OK, could you repost the patch (and put me to Cc) so that I can apply
>>> to for-next branch?
>>>
>>>
>>> thanks,
>>>
>>> Takashi
>>>
>>>
>>>> thanks,
>>>>
>>>> Cyrus
>>>>
>>>> On 11/03/2014 10:28 PM, Takashi Iwai wrote:
>>>>> At Mon, 03 Nov 2014 16:36:58 -0800,
>>>>> Cyrus Harmon wrote:
>>>>>> Well, it's 7 months on and I'm still using a patched kernel to access my
>>>>>> UR44. Any chance of either seeing my original patch committed, or some
>>>>>> suggestions on a more proper fix, if there's something with my original
>>>>>> patch?
>>>>> Which kernel version are you testing?
>>>>>
>>>>>
>>>>> Takashi
>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> Cyrus
>>>>>>
>>>>>> On 03/17/2014 09:29 AM, Cyrus Harmon wrote:
>>>>>>> On Mar 11, 2014, at 1:31 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
>>>>>>>
>>>>>>>> Cyrus Harmon wrote:
>>>>>>>>> On Mar 10, 2014, at 8:40 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
>>>>>>>>>> In theory, kernel 3.11 and later should support this device without
>>>>>>>>>> a quirk entry.  I guess it actually does not?
>>>>>>>>> no, the stock kernel doesn’t support this device.
>>>>>>>> Strange; in theory, the driver should be able to pick up these
>>>>>>>> descriptors.
>>>>>>>>
>>>>>>>> Are there any error messages in the system log when you plug it in or
>>>>>>>> reload the unpatch snd-usb-audio driver?
>>>>>>> Following up on this from last week, here’s the error message I see with an unpatched kernel:
>>>>>>>
>>>>>>> Mar 11 02:25:11 cbox kernel: [   82.426640] usb 2-1.6: new high-speed USB device number 4 using ehci-pci
>>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515364] usb 2-1.6: New USB device found, idVendor=0499, idProduct=150e
>>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515368] usb 2-1.6: New USB device strings: Mfr=1, Product=2, SerialNumber=0
>>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515370] usb 2-1.6: Product: Steinberg UR44
>>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515372] usb 2-1.6: Manufacturer: Yamaha Corporation
>>>>>>> Mar 11 02:25:12 cbox kernel: [   82.518134] snd-usb-audio: probe of 2-1.6:1.0 failed with error -5
>>>>>>> Mar 11 02:25:12 cbox kernel: [   82.523317] snd-usb-audio: probe of 2-1.6:1.1 failed with error -5
>>>>>>> Mar 11 02:25:12 cbox mtp-probe: checking bus 2, device 4: "/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.6"
>>>>>>> Mar 11 02:25:12 cbox mtp-probe: bus: 2, device: 4 was not an MTP device
>>>>>>>
>>>>>>> Any suggestions for further debugging this?
>>>>>>>
>>>>>>> Also, from an earlier message,
>>>>>>>
>>>>>>> On Mar 10, 2014, at 8:40 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
>>>>>>>
>>>>>>>> This sounds as if the playback stream needs to be synchronized to the
>>>>>>>> recording stream
>>>>>>> Any pointers on where I might look to figure out how to do this?
>>>>>>>
>>>>>>> thanks again,
>>>>>>>
>>>>>>> Cyrus
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Alsa-devel mailing list
>>>>>>> Alsa-devel@alsa-project.org
>>>>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>>>> _______________________________________________
>>>>>> Alsa-devel mailing list
>>>>>> Alsa-devel@alsa-project.org
>>>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>>>>
>>>>> _______________________________________________
>>>>> Alsa-devel mailing list
>>>>> Alsa-devel@alsa-project.org
>>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>> _______________________________________________
>>>> Alsa-devel mailing list
>>>> Alsa-devel@alsa-project.org
>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Comments

Vlad Catoi Nov. 6, 2014, 1:46 p.m. UTC | #1
Oh! Sorry, I thought you guys were trying to get this to work without
needing the quirks :)

~Vlad

On Wed, 2014-11-05 at 21:32 -0800, Cyrus Harmon wrote:
> I think UR22 works! I'm just aping the UR22 support to work for UR44!
> 
> But, here it is:
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index f652b10..987ca01 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -436,6 +436,36 @@ YAMAHA_DEVICE(0x105d, NULL),
>                  }
>          }
>   },
> +{
> +       USB_DEVICE(0x0499, 0x150e),
> +       .driver_info = (unsigned long) & (const struct 
> snd_usb_audio_quirk) {
> +               /* .vendor_name = "Yamaha", */
> +               /* .product_name = "Steinberg UR44", */
> +               .ifnum = QUIRK_ANY_INTERFACE,
> +               .type = QUIRK_COMPOSITE,
> +               .data = (const struct snd_usb_audio_quirk[]) {
> +                       {
> +                               .ifnum = 1,
> +                               .type = QUIRK_AUDIO_STANDARD_INTERFACE
> +                       },
> +                       {
> +                               .ifnum = 2,
> +                               .type = QUIRK_AUDIO_STANDARD_INTERFACE
> +                       },
> +                       {
> +                               .ifnum = 3,
> +                               .type = QUIRK_MIDI_YAMAHA
> +                       },
> +                       {
> +                               .ifnum = 4,
> +                               .type = QUIRK_IGNORE_INTERFACE
> +                       },
> +                       {
> +                               .ifnum = -1
> +                       }
> +               }
> +       }
> +},
>   YAMAHA_DEVICE(0x2000, "DGP-7"),
>   YAMAHA_DEVICE(0x2001, "DGP-5"),
>   YAMAHA_DEVICE(0x2002, NULL),
> 
> 
> 
> On 11/05/2014 09:28 PM, Vlad Catoi wrote:
> > Cyrus,
> >
> > Pass it along, I can try it on the UR22 as well.
> >
> > ~Vlad
> >
> > On Wed, 2014-11-05 at 20:39 -0800, Cyrus Harmon wrote:
> >> Hi Takashi,
> >>
> >> Clemens has sent me another diagnostic/debugging patch to try. Perhaps
> >> we should wait to see the results of that before pushing to for-next. If
> >> we don't get a deeper understanding of the problem in the next couple of
> >> days, I'll send along the original patch.
> >>
> >> thanks,
> >>
> >> Cyrus
> >>
> >> On 11/05/2014 03:14 PM, Takashi Iwai wrote:
> >>> At Tue, 04 Nov 2014 00:55:11 -0800,
> >>> Cyrus Harmon wrote:
> >>>> I have used a number of 3.1x kernels. At the moment, I'm writing this
> >>>> from a 3.17.0 kernel that doesn't recognize the UR44 without my patch.
> >>> OK, could you repost the patch (and put me to Cc) so that I can apply
> >>> to for-next branch?
> >>>
> >>>
> >>> thanks,
> >>>
> >>> Takashi
> >>>
> >>>
> >>>> thanks,
> >>>>
> >>>> Cyrus
> >>>>
> >>>> On 11/03/2014 10:28 PM, Takashi Iwai wrote:
> >>>>> At Mon, 03 Nov 2014 16:36:58 -0800,
> >>>>> Cyrus Harmon wrote:
> >>>>>> Well, it's 7 months on and I'm still using a patched kernel to access my
> >>>>>> UR44. Any chance of either seeing my original patch committed, or some
> >>>>>> suggestions on a more proper fix, if there's something with my original
> >>>>>> patch?
> >>>>> Which kernel version are you testing?
> >>>>>
> >>>>>
> >>>>> Takashi
> >>>>>
> >>>>>> thanks,
> >>>>>>
> >>>>>> Cyrus
> >>>>>>
> >>>>>> On 03/17/2014 09:29 AM, Cyrus Harmon wrote:
> >>>>>>> On Mar 11, 2014, at 1:31 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
> >>>>>>>
> >>>>>>>> Cyrus Harmon wrote:
> >>>>>>>>> On Mar 10, 2014, at 8:40 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
> >>>>>>>>>> In theory, kernel 3.11 and later should support this device without
> >>>>>>>>>> a quirk entry.  I guess it actually does not?
> >>>>>>>>> no, the stock kernel doesn’t support this device.
> >>>>>>>> Strange; in theory, the driver should be able to pick up these
> >>>>>>>> descriptors.
> >>>>>>>>
> >>>>>>>> Are there any error messages in the system log when you plug it in or
> >>>>>>>> reload the unpatch snd-usb-audio driver?
> >>>>>>> Following up on this from last week, here’s the error message I see with an unpatched kernel:
> >>>>>>>
> >>>>>>> Mar 11 02:25:11 cbox kernel: [   82.426640] usb 2-1.6: new high-speed USB device number 4 using ehci-pci
> >>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515364] usb 2-1.6: New USB device found, idVendor=0499, idProduct=150e
> >>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515368] usb 2-1.6: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> >>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515370] usb 2-1.6: Product: Steinberg UR44
> >>>>>>> Mar 11 02:25:12 cbox kernel: [   82.515372] usb 2-1.6: Manufacturer: Yamaha Corporation
> >>>>>>> Mar 11 02:25:12 cbox kernel: [   82.518134] snd-usb-audio: probe of 2-1.6:1.0 failed with error -5
> >>>>>>> Mar 11 02:25:12 cbox kernel: [   82.523317] snd-usb-audio: probe of 2-1.6:1.1 failed with error -5
> >>>>>>> Mar 11 02:25:12 cbox mtp-probe: checking bus 2, device 4: "/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.6"
> >>>>>>> Mar 11 02:25:12 cbox mtp-probe: bus: 2, device: 4 was not an MTP device
> >>>>>>>
> >>>>>>> Any suggestions for further debugging this?
> >>>>>>>
> >>>>>>> Also, from an earlier message,
> >>>>>>>
> >>>>>>> On Mar 10, 2014, at 8:40 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
> >>>>>>>
> >>>>>>>> This sounds as if the playback stream needs to be synchronized to the
> >>>>>>>> recording stream
> >>>>>>> Any pointers on where I might look to figure out how to do this?
> >>>>>>>
> >>>>>>> thanks again,
> >>>>>>>
> >>>>>>> Cyrus
> >>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> Alsa-devel mailing list
> >>>>>>> Alsa-devel@alsa-project.org
> >>>>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >>>>>> _______________________________________________
> >>>>>> Alsa-devel mailing list
> >>>>>> Alsa-devel@alsa-project.org
> >>>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >>>>>>
> >>>>> _______________________________________________
> >>>>> Alsa-devel mailing list
> >>>>> Alsa-devel@alsa-project.org
> >>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >>>> _______________________________________________
> >>>> Alsa-devel mailing list
> >>>> Alsa-devel@alsa-project.org
> >>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >> _______________________________________________
> >> Alsa-devel mailing list
> >> Alsa-devel@alsa-project.org
> >> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
diff mbox

Patch

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index f652b10..987ca01 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -436,6 +436,36 @@  YAMAHA_DEVICE(0x105d, NULL),
                 }
         }
  },
+{
+       USB_DEVICE(0x0499, 0x150e),
+       .driver_info = (unsigned long) & (const struct 
snd_usb_audio_quirk) {
+               /* .vendor_name = "Yamaha", */
+               /* .product_name = "Steinberg UR44", */
+               .ifnum = QUIRK_ANY_INTERFACE,
+               .type = QUIRK_COMPOSITE,
+               .data = (const struct snd_usb_audio_quirk[]) {
+                       {
+                               .ifnum = 1,
+                               .type = QUIRK_AUDIO_STANDARD_INTERFACE
+                       },
+                       {
+                               .ifnum = 2,
+                               .type = QUIRK_AUDIO_STANDARD_INTERFACE
+                       },
+                       {
+                               .ifnum = 3,
+                               .type = QUIRK_MIDI_YAMAHA
+                       },
+                       {
+                               .ifnum = 4,
+                               .type = QUIRK_IGNORE_INTERFACE
+                       },
+                       {
+                               .ifnum = -1
+                       }
+               }
+       }
+},
  YAMAHA_DEVICE(0x2000, "DGP-7"),
  YAMAHA_DEVICE(0x2001, "DGP-5"),