| Message ID | 5469E09C.6040808@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6da95e1ea8e2492530eac9c51b293226e3f4ce94 |
| Headers | show |
At Mon, 17 Nov 2014 12:48:44 +0100, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 17 Nov 2014 12:42:16 +0100 > > The vfree() function performs also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied, thanks. Takashi > --- > sound/pci/lola/lola_mixer.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/pci/lola/lola_mixer.c b/sound/pci/lola/lola_mixer.c > index 782f4d8..e7fe15d 100644 > --- a/sound/pci/lola/lola_mixer.c > +++ b/sound/pci/lola/lola_mixer.c > @@ -108,8 +108,7 @@ int lola_init_pins(struct lola *chip, int dir, int *nidp) > > void lola_free_mixer(struct lola *chip) > { > - if (chip->mixer.array_saved) > - vfree(chip->mixer.array_saved); > + vfree(chip->mixer.array_saved); > } > > int lola_init_mixer_widget(struct lola *chip, int nid) > -- > 2.1.3 > >
diff --git a/sound/pci/lola/lola_mixer.c b/sound/pci/lola/lola_mixer.c index 782f4d8..e7fe15d 100644 --- a/sound/pci/lola/lola_mixer.c +++ b/sound/pci/lola/lola_mixer.c @@ -108,8 +108,7 @@ int lola_init_pins(struct lola *chip, int dir, int *nidp) void lola_free_mixer(struct lola *chip) { - if (chip->mixer.array_saved) - vfree(chip->mixer.array_saved); + vfree(chip->mixer.array_saved); } int lola_init_mixer_widget(struct lola *chip, int nid)