From patchwork Mon Nov 17 11:48:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 5318281 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 291E39F7DE for ; Mon, 17 Nov 2014 11:49:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 61EE22015E for ; Mon, 17 Nov 2014 11:49:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 199D22012B for ; Mon, 17 Nov 2014 11:49:26 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id C02812616F6; Mon, 17 Nov 2014 12:49:24 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id ACB31261643; Mon, 17 Nov 2014 12:49:05 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7EA8F2616F6; Mon, 17 Nov 2014 12:49:04 +0100 (CET) Received: from mout.web.de (mout.web.de [212.227.17.12]) by alsa0.perex.cz (Postfix) with ESMTP id 8E1C3261615 for ; Mon, 17 Nov 2014 12:48:56 +0100 (CET) Received: from [192.168.1.2] ([78.49.145.180]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0LmcjH-1YPfkW3fSl-00aCUx; Mon, 17 Nov 2014 12:48:52 +0100 Message-ID: <5469E09C.6040808@users.sourceforge.net> Date: Mon, 17 Nov 2014 12:48:44 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:yKpGRLGtY0A7tVMG08tW4aPCxptTBvsfjv/vXnYmjGjsQ7R0RT9 tx/lgccJRdr38DgkPKJC700yErf7VPNuP4f2V+4qfHa8MrKEmw6ko7C+mzuuremxxrfmG8F IGmb7e52c8dYkL1z1mCVx6GAab2QnTYuRKExVvAhFT9Xm/3A+nWHf5hcQ/0+HiTq4r2zJjM 4keN2EjKOsx8sJDfIYXyQ== X-UI-Out-Filterresults: notjunk:1; Cc: kernel-janitors@vger.kernel.org, LKML , Coccinelle Subject: [alsa-devel] [PATCH 1/1] ALSA: lola: Deletion of an unnecessary check before the function call "vfree" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Mon, 17 Nov 2014 12:42:16 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/pci/lola/lola_mixer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/lola/lola_mixer.c b/sound/pci/lola/lola_mixer.c index 782f4d8..e7fe15d 100644 --- a/sound/pci/lola/lola_mixer.c +++ b/sound/pci/lola/lola_mixer.c @@ -108,8 +108,7 @@ int lola_init_pins(struct lola *chip, int dir, int *nidp) void lola_free_mixer(struct lola *chip) { - if (chip->mixer.array_saved) - vfree(chip->mixer.array_saved); + vfree(chip->mixer.array_saved); } int lola_init_mixer_widget(struct lola *chip, int nid)