From patchwork Mon Nov 17 12:12:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 5318571 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 755789F1E1 for ; Mon, 17 Nov 2014 12:12:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A36E320108 for ; Mon, 17 Nov 2014 12:12:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 5926A200D6 for ; Mon, 17 Nov 2014 12:12:50 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 600D8261A9A; Mon, 17 Nov 2014 13:12:48 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, RCVD_IN_DNSWL_NONE,UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id D5323261A5A; Mon, 17 Nov 2014 13:12:40 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5A738261A7E; Mon, 17 Nov 2014 13:12:39 +0100 (CET) Received: from mout.web.de (mout.web.de [212.227.17.11]) by alsa0.perex.cz (Postfix) with ESMTP id 650592619F3 for ; Mon, 17 Nov 2014 13:12:31 +0100 (CET) Received: from [192.168.1.2] ([78.49.145.180]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0MGzjq-1XmTHJ47Tm-00Dnsu; Mon, 17 Nov 2014 13:12:24 +0100 Message-ID: <5469E61F.6000002@users.sourceforge.net> Date: Mon, 17 Nov 2014 13:12:15 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:CX+scxY4fl5xgwZ/n6yvlzrw4uaoqPG6Jg3WRM8z1OaLPCO2ha1 s8DWqOjFlKPyemSW3W/UyLHxnlCwcxWUe9lqHJERPNqwb/rSrgpesMGWG5dY/Ieykq7uvEf axC69k3zBuxTdMTsqQMvP7obMqS39gxA6cpDuz6muOllDbW6BhcB0TzHb7QbrI0Nu8qBC2w UddL/FC8+Sg0e53gPcyHg== X-UI-Out-Filterresults: notjunk:1; Cc: kernel-janitors@vger.kernel.org, LKML , Coccinelle Subject: [alsa-devel] [PATCH 1/1] ALSA: hdsp: Deletion of an unnecessary check before the function call "release_firmware" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Mon, 17 Nov 2014 13:04:14 +0100 The release_firmware() function tests whether its argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/pci/rme9652/hdsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 7646ba1..0ae568d 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5368,8 +5368,7 @@ static int snd_hdsp_free(struct hdsp *hdsp) snd_hdsp_free_buffers(hdsp); - if (hdsp->firmware) - release_firmware(hdsp->firmware); + release_firmware(hdsp->firmware); vfree(hdsp->fw_uploaded); if (hdsp->iobase)