From patchwork Sat Jan 10 00:51:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Flater X-Patchwork-Id: 5603571 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C318C9F1C5 for ; Sat, 10 Jan 2015 00:52:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 08B2C20639 for ; Sat, 10 Jan 2015 00:52:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 0908620634 for ; Sat, 10 Jan 2015 00:52:06 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id E162B260690; Sat, 10 Jan 2015 01:52:04 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 329E826060E; Sat, 10 Jan 2015 01:51:56 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6F15A26061E; Sat, 10 Jan 2015 01:51:55 +0100 (CET) Received: from nupi.pair.com (nupi.pair.com [209.68.5.149]) by alsa0.perex.cz (Postfix) with ESMTP id 5BAB42605CF for ; Sat, 10 Jan 2015 01:51:48 +0100 (CET) Received: from [192.168.1.9] (pool-108-51-164-104.washdc.fios.verizon.net [108.51.164.104]) by nupi.pair.com (Postfix) with ESMTPSA id 7F58C4B1A7; Fri, 9 Jan 2015 19:51:47 -0500 (EST) Message-ID: <54B077A3.7030703@flaterco.com> Date: Fri, 09 Jan 2015 19:51:47 -0500 From: David Flater User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Takashi Iwai Cc: Alsa Devel , LKML Subject: [alsa-devel] [PATCHv2 2/2] ALSA: log emu8000 DRAM size at level INFO X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Applicable after PATCHv2 1/2: Detected sound font memory goes unreported unless the kernel was built with ALSA debugging enabled. Elevate that to a printk at level INFO. Signed-off-by: David Flater --- History: 2015-01-09 v2: In response to feedback from Takashi Iwai, 1. Optimize for diff size. 1a. Use goto to avoid indenting. 1b. Jettison new debugging printouts. 2. Split printk into second patch. Retested on CT4390 (4 MiB) and CT4380 (512 KiB). 2015-01-08 v1 patch sent to LKML, Alsa Devel and maintainers. Tested on unexpanded CT4390 (4 MiB), CT4520 (512 KiB), and CT4380 (512 KiB). sound/isa/sb/emu8000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/sb/emu8000.c b/sound/isa/sb/emu8000.c index 3dcf80e..7429a51 100644 --- a/sound/isa/sb/emu8000.c +++ b/sound/isa/sb/emu8000.c @@ -451,7 +451,7 @@ size_dram(struct snd_emu8000 *emu) snd_emu8000_dma_chan(emu, 0, EMU8000_RAM_CLOSE); snd_emu8000_dma_chan(emu, 1, EMU8000_RAM_CLOSE); - snd_printdd("EMU8000 [0x%lx]: %d Kb on-board memory detected\n", + snd_printk(KERN_INFO "EMU8000 [0x%lx]: %d KiB on-board DRAM detected\n", emu->port1, size/1024); emu->mem_size = size;