From patchwork Sun Jan 11 21:10:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Flater X-Patchwork-Id: 5607111 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5B3C0C058D for ; Sun, 11 Jan 2015 21:10:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8638F2062A for ; Sun, 11 Jan 2015 21:10:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 6FE52205F7 for ; Sun, 11 Jan 2015 21:10:37 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 91F5726047D; Sun, 11 Jan 2015 22:10:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id A22D12604D3; Sun, 11 Jan 2015 22:10:30 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D4FA42604E9; Sun, 11 Jan 2015 22:10:28 +0100 (CET) Received: from nupi.pair.com (nupi.pair.com [209.68.5.149]) by alsa0.perex.cz (Postfix) with ESMTP id AFAA026046A for ; Sun, 11 Jan 2015 22:10:08 +0100 (CET) Received: from [192.168.1.9] (pool-108-51-164-104.washdc.fios.verizon.net [108.51.164.104]) by nupi.pair.com (Postfix) with ESMTPSA id ADE2D4AF1B; Sun, 11 Jan 2015 16:10:07 -0500 (EST) Message-ID: <54B2E6AF.8060501@flaterco.com> Date: Sun, 11 Jan 2015 16:10:07 -0500 From: David Flater User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Takashi Iwai Cc: Alsa Devel , LKML Subject: [alsa-devel] [PATCHv3 2/2] ALSA: log emu8000 DRAM size at level INFO X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Applicable after PATCHv3 1/2: Detected sound font memory goes unreported unless the kernel was built with ALSA debugging enabled. Elevate that to a pr_info. Signed-off-by: David Flater --- History: 2015-01-11 v3: In response to feedback from Takashi Iwai, Patch 1: Repeat code to avoid goto middle of loop. Patch 2: Use pr_info not printk. Retested on CT4390 (4 MiB) and CT4380 (512 KiB). 2015-01-09 v2: In response to feedback from Takashi Iwai, 1. Optimize for diff size. 1a. Use goto to avoid indenting and repeating code. 1b. Jettison new debugging printouts. 2. Split printk into second patch. Retested on CT4390 (4 MiB) and CT4380 (512 KiB). 2015-01-08 v1 patch sent to LKML, Alsa Devel and maintainers. Tested on unexpanded CT4390 (4 MiB), CT4520 (512 KiB), and CT4380 (512 KiB). sound/isa/sb/emu8000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/sb/emu8000.c b/sound/isa/sb/emu8000.c index d25e384..96e9d94 100644 --- a/sound/isa/sb/emu8000.c +++ b/sound/isa/sb/emu8000.c @@ -453,7 +453,7 @@ skip_detect: snd_emu8000_dma_chan(emu, 0, EMU8000_RAM_CLOSE); snd_emu8000_dma_chan(emu, 1, EMU8000_RAM_CLOSE); - snd_printdd("EMU8000 [0x%lx]: %d Kb on-board memory detected\n", + pr_info("EMU8000 [0x%lx]: %d KiB on-board DRAM detected\n", emu->port1, size/1024); emu->mem_size = size;