From patchwork Tue Aug 25 11:53:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 7070961 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9C4E39F344 for ; Tue, 25 Aug 2015 11:53:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CE72120896 for ; Tue, 25 Aug 2015 11:53:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 962942056C for ; Tue, 25 Aug 2015 11:53:40 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 95B882615FC; Tue, 25 Aug 2015 13:53:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 44AAF2605AF; Tue, 25 Aug 2015 13:53:31 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 14D12260609; Tue, 25 Aug 2015 13:53:30 +0200 (CEST) Received: from lists.s-osg.org (lists.s-osg.org [54.187.51.154]) by alsa0.perex.cz (Postfix) with ESMTP id 085A92605AA for ; Tue, 25 Aug 2015 13:53:23 +0200 (CEST) Received: from [192.168.1.131] (121.108.23.95.dynamic.jazztel.es [95.23.108.121]) by lists.s-osg.org (Postfix) with ESMTPSA id 16F07462CB; Tue, 25 Aug 2015 04:53:20 -0700 (PDT) To: kbuild test robot References: <201508251919.xL9c6697%fengguang.wu@intel.com> From: Javier Martinez Canillas Message-ID: <55DC572E.3070701@osg.samsung.com> Date: Tue, 25 Aug 2015 13:53:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <201508251919.xL9c6697%fengguang.wu@intel.com> Cc: Takashi Iwai , alsa-devel@alsa-project.org, kbuild-all@01.org Subject: Re: [alsa-devel] [sound:for-next 174/174] sound/ppc/keywest.c:104:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/25/2015 01:23 PM, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next > head: a2bc2af66a5b656577fc2d71b6c277b73537777e > commit: a2bc2af66a5b656577fc2d71b6c277b73537777e [174/174] ALSA: ppc: keywest: Export I2C module alias information > config: powerpc-defconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout a2bc2af66a5b656577fc2d71b6c277b73537777e > # save the attached .config to linux build tree > make.cross ARCH=powerpc > > All error/warnings (new ones prefixed by >>): > >>> sound/ppc/keywest.c:104:1: warning: data definition has no type or storage class > MODULE_DEVICE_TABLE(i2c, keywest_i2c_id); > ^ >>> sound/ppc/keywest.c:104:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] >>> sound/ppc/keywest.c:104:1: warning: parameter names (without types) in function declaration > cc1: some warnings being treated as errors > > vim +104 sound/ppc/keywest.c > > 98 > 99 static const struct i2c_device_id keywest_i2c_id[] = { > 100 { "MAC,tas3004", 0 }, /* instantiated by i2c-powermac */ > 101 { "keywest", 0 }, /* instantiated by us if needed */ > 102 { } > 103 }; > > 104 MODULE_DEVICE_TABLE(i2c, keywest_i2c_id); > 105 > 106 static struct i2c_driver keywest_driver = { > 107 .driver = { > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > Sigh, this is because it misses a include. I built test with make M=drivers but forgot that sound is outside drivers. So the following change is needed [0]. Takashi, Should I re-spin a v2 adding the include or now that you applied, should I send an incremental patch? [0] Best regards, diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c index f644a8c57e0a..4373615f13e2 100644 --- a/sound/ppc/keywest.c +++ b/sound/ppc/keywest.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include "pmac.h"