From patchwork Sat Aug 12 18:02:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9897425 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4DF260325 for ; Sat, 12 Aug 2017 18:03:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BA1928975 for ; Sat, 12 Aug 2017 18:03:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F4BF2898A; Sat, 12 Aug 2017 18:03:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AACA828975 for ; Sat, 12 Aug 2017 18:03:25 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id DAF2226706B; Sat, 12 Aug 2017 20:02:56 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9E7A826706C; Sat, 12 Aug 2017 20:02:55 +0200 (CEST) Received: from mout.web.de (mout.web.de [217.72.192.78]) by alsa0.perex.cz (Postfix) with ESMTP id 4C7D326701A for ; Sat, 12 Aug 2017 20:02:52 +0200 (CEST) Received: from [192.168.1.2] ([77.181.183.107]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M9XUJ-1dlJQN1Erf-00CwrE; Sat, 12 Aug 2017 20:02:16 +0200 To: alsa-devel@alsa-project.org, Fabian Frederick , Jaroslav Kysela , Takashi Iwai From: SF Markus Elfring Message-ID: <5991f20d-dbad-a916-76be-375ade7de737@users.sourceforge.net> Date: Sat, 12 Aug 2017 20:02:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:CokV93PmgVrFQKbkUF4+JsZIbyIUXGcSloFLYiyftAiy9ba0nRD +uvcUMFfSA2P5ceg7uyLgoUGFyewDyHd8NK4tL+KjnQ/r7+gPT/0xtgwkx4hi4jXfpWG0QK QmXw6nlMFOrFe07+ooM1onkx1xkEv8zZ+4dzmWIpBTgAZYcNidtEOo/N8nXmQ3cH2KpFrR4 yb0W3J8UKL/sg1IRaqMGA== X-UI-Out-Filterresults: notjunk:1; V01:K0:vh2vyWsyNaQ=:sU+S4cm2E1GTO2V2tBzjqY 98QFCWZdvxDoY+cpWoSoZrmAE2se9RkMJsKsXhLjzvlDqwFGXhsvJtpnLV8zl/dqkM7fj54Sj j4ODUTHKY8ynwM4KC5kI+9N2tIchBZx7k0z9W6oVlngqrQlxOhK9ZWu5Ty+VMIHYZNosUL8pn qMNUxlOEYXc8cdoyY+FPXLoYyCXGdW3wsPSeC1eWY4z4gknb4WgkYkP3Yzh9ehkMAm4HgktjC 57u4zcbU+YvOwqpGQx6HnwMwmSM2DqVmvKPWpDifPpN6DkbSeUFRcfQXf2ciR+tLzh8nlKJud p7r6yaLomW+0NoN/I7BIbb86ZY3KmfzTX0A2WnYzq1HZepWYgQJIL7LXkk0r0AaoPpmZ0LTb2 4L341KYcnuJ5Peji2/lZnHuWoSRj/ZUaVwVxkv34rBe3YRbxXt2fW30PDcLJpV6NHUvZqlO8J pal4Vfp/u73xiD5+A9mQ0PovAKm7zw7Trl04VCUZfi1wfim6rVeRjYKpLRyykYqobzi/szO8O vjJJEHv1oD2I4ItkovVnhjPpIqvduG9OH/fNaD7q1OMc/gCH/I583F4ia20CWw7RujDm+7+Fj 6XGnDmZsmwGKwh8/BlGd+iVsk5ozff/NBiOp391WXwabUjTcNxhVlCABsPNlGBhuCmxN1lomR KbEoE5KGHgAHLnnIxIh2nefHz8BcrtgzCC0A4ByyZhujcIEO+ZoXfc9ewT9+K/MP8tawL2o2n E+j/N/Lj7ThJxxhl67fcFhTiuQO7ZJjQIv5LsJfuw0yN1J2Sm/kZc7Vk5VVe13PUUZ3gHKh9X VWiW4RxaAGOS4FPKX6WaU0jU6f1fJdsXfKN3DOMwvIOB+QYp9I= Cc: kernel-janitors@vger.kernel.org, LKML Subject: [alsa-devel] [PATCH] ALSA: opl3: Delete an error message for a failed memory allocation in snd_opl3_new() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 12 Aug 2017 19:54:20 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/drivers/opl3/opl3_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/drivers/opl3/opl3_lib.c b/sound/drivers/opl3/opl3_lib.c index d5e5b4657b4b..588963d6be28 100644 --- a/sound/drivers/opl3/opl3_lib.c +++ b/sound/drivers/opl3/opl3_lib.c @@ -355,10 +355,8 @@ int snd_opl3_new(struct snd_card *card, *ropl3 = NULL; opl3 = kzalloc(sizeof(*opl3), GFP_KERNEL); - if (opl3 == NULL) { - snd_printk(KERN_ERR "opl3: cannot allocate\n"); + if (!opl3) return -ENOMEM; - } opl3->card = card; opl3->hardware = hardware;