From patchwork Thu Dec 24 05:37:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zidan Wang X-Patchwork-Id: 7915351 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1DDCBBEEE5 for ; Thu, 24 Dec 2015 05:34:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4952620429 for ; Thu, 24 Dec 2015 05:34:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 1F86F2034B for ; Thu, 24 Dec 2015 05:34:52 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 66A0D2665EA; Thu, 24 Dec 2015 06:34:50 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, NO_DNS_FOR_FROM,RCVD_IN_DNSWL_LOW,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D3F992665A6; Thu, 24 Dec 2015 06:34:42 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 616E12665AF; Thu, 24 Dec 2015 06:34:41 +0100 (CET) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0145.outbound.protection.outlook.com [65.55.169.145]) by alsa0.perex.cz (Postfix) with ESMTP id F2340266578 for ; Thu, 24 Dec 2015 06:34:33 +0100 (CET) Received: from DM2PR03CA0002.namprd03.prod.outlook.com (10.141.96.12) by CY1PR0301MB1257.namprd03.prod.outlook.com (10.161.212.155) with Microsoft SMTP Server (TLS) id 15.1.361.13; Thu, 24 Dec 2015 05:34:31 +0000 Received: from BL2FFO11OLC015.protection.gbl (2a01:111:f400:7c09::137) by DM2PR03CA0002.outlook.office365.com (2a01:111:e400:2428::12) with Microsoft SMTP Server (TLS) id 15.1.361.13 via Frontend Transport; Thu, 24 Dec 2015 05:34:31 +0000 Authentication-Results: spf=permerror (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; Received-SPF: PermError (protection.outlook.com: domain of freescale.com used an invalid SPF mechanism) Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11OLC015.mail.protection.outlook.com (10.173.160.81) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Thu, 24 Dec 2015 05:34:31 +0000 Received: from b50113.ap.freescale.net (b50113.ap.freescale.net [10.192.241.68]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id tBO5YQwR007385; Wed, 23 Dec 2015 22:34:27 -0700 From: Zidan Wang To: Date: Thu, 24 Dec 2015 13:37:26 +0800 Message-ID: <6344b98f891fff3011257b21e1d8e39d7a123831.1450935357.git.zidan.wang@freescale.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC015; 1:MsrNJu1YL/gr8jNb5cWszpQiC9KonN5dGVkIjcmCSFfNo/hEWiSirRFKu+iBTRxJQDvkoIt8ynwkRI6SfMKPaC/6TtO3NI4Kk86EUhGz9GiXG+vy1tUh15/4e/vEz4gKypLsftWNYnQU7/YV29DrGjjs61/1LtJyNIkODcUyke/0n5QXetXBoZHo6BwFBbaoU9/EAbEmPxtr2/VdBN7Q8P0wlGPCBnjh5+fHccPtHLBp7wJsrpbvDSfF4vALRH2vpe/Y+8nXmxoeRS1E7YdVZ6r2F8EsXS31zONL/PrccPIqL+nRUX9BKEAwt/vJJ/0A+ZI1hXCMhpNwr/EFrYF8OPoAzoRwhBFSHYZ68OIfbtRDByIzzuQrfPsc5rDhD86LT/k+TJDPQjaclg7zTQQOjCI4DOi2vtctiSLxNKXvlC63W8SJcbPlkSF+DhK8GAXh X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(448002)(3190300001)(199003)(189002)(92566002)(6806005)(110136002)(104016004)(19580405001)(86362001)(106466001)(47776003)(5003940100001)(33646002)(85326001)(87936001)(189998001)(5001960100002)(48376002)(77096005)(107886002)(97736004)(11100500001)(19580395003)(81156007)(586003)(50986999)(1096002)(69596002)(2351001)(4001430100002)(5008740100001)(118296001)(229853001)(50466002)(50226001)(36756003)(1220700001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0301MB1257; H:az84smr01.freescale.net; FPR:; SPF:PermError; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1257; 2:pDtqJ/LojxAlXocKicTdDHHhxEU7tEtayR2N7BdW45ICWAKKEsTC4u7YB9uEIy+DMUUSAJ/A71LlDiWn/DKq4wvU6yVCQu5Moh7HBYjoROm3QDofBv1uYlwtJ1SqDXqpjn9fP5y3KIofBoS8cxSoyA==; 3:KXdiV8wBlxNUVjq4MDhxGthMaeOavMVCvE5vbxhUoUrq+RpJxRgs4MRmzHKUmChMWa/Cj23AdRZxQQqZKMjfNjQGL0yp21xzGeEz97yu3qr4kggKGlzR+J8mQRv8IMwcP5HHBP6Lu+pJI+i9NRbBUFwjlE7QgwpXk/W2Kw05U0m9l/oqAwzngiym77k5eLJzX3u9YOLlK2wF6sObzHWpLYRqe59CaLGWmi6s+LzvkOs=; 25:kZeg1lRYPnRk3LEbQ7iPyFTLI78N31v7kNiKIu3p0o5vliRIh8ImLSfwpTkj6f6fbfetUPm5EzgBYBWhCSLCJXT7sbrmEWbAH50zDwNOvAfnVXxoi3lj6hc4tZb9GO6hCD7Nw4jvuX2kBo5+k6VbS/CU2bIDOaY7Vf6q0u2b/F5M3gtpuFXR3SVpc6daqGLVt4tELLpzTD5pqP6cheVszw3hItu5YeqgKm5vAQKXdsT5mhJpeugjLTCUKQgX2WRIw5JfMNUVzPOpwUw4gM0/rw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1257; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1257; 20:HqRuLZes+RS7jNuUxPfcky5KND2D7ylPS0n8IEcDVZSxVaWIuP2Pz26rg9guCwDhQx4JoCrboIK7qSnmnRBpsA7m0t1wuz3lGqN5lgPkLW/exSNdZq1+SomWLvO1Ws4L9cvlR0qAMVvbCzfLD9Kpoqaxcr6mRQA0Ec1b1xxHD6fyWKhr2gA+caCmyzplqOvxauBigceFtagtBLIx8LF0u62KfoTxJZr1YWkeoz98lOJgKqoe+8RHM5XEDH3xoDdxDGVn4ddgxBQvaVIcPuJTr+h7y7qbBnxv8FnvXiWNDFpztyRvRmASk2Qe+MLJkmk1sgyjLzERywqVipgeRnThj4Sv7Bcf9mjC00dLx/598uI=; 4:6cPDtIG1zQsPkaSYPAERxVl0SLkc90hgP6ymyTCObeBbHI616mM+/+qqqnUI6h7oTlxGQZEpc9aj6om4UA2FhgfuMdrO58Ftyvcs4WyPUPXXQlXuY6CMGL3osT9bx0PagqzEJgBjAkXAVa/LmvUbMCwOagdec6P+OKqb9D8zp+bZ0NUpZynRUzfPFZBHTdZQzxSdCPWvVUl1D2NzumWwlt4dZE/qjz2EikETwG5pr34eiYNlXAdTUHDblHfotc+xfoA/E7PKn+I4qYtN1lONLZo2dN+2BFK8nCkMISDA1SRCyZ7Ka6ahdtOWIGgx1GvlnG1Mj78hU7Lz/GRf3KfggKWtOWiSPcXvoAa/dXXl7MAVElFRvDqVFQ/LvXgGNnRmiP04yt9nFe/+hkQc5gjYHkZEx5F4XHQ14pV3GnRMlvKAceINf2jYcNW6eVP4kGr6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001); SRVR:CY1PR0301MB1257; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB1257; X-Forefront-PRVS: 0800C0C167 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB1257; 23:4tIXxEFrhDFSpEkfAF58UKomFU8IzBni5VE4CxE?= =?us-ascii?Q?ctsVPo2AINq6QeUeAWh/J+7enVL29uYeqeeJcfO17cBR6B7tl6ukoC1mQkrD?= =?us-ascii?Q?oE2zLAAWutdnlrOLE00fQuChdaHlZ7xkmAwxhLMIxUCq6TeOzY6B8+c7teNX?= =?us-ascii?Q?OluceZpYP7pfJLa9YISYCHsQ0QlG22n0J0K7+mbVSegbWTr87vR3B+bCPDqP?= =?us-ascii?Q?rpiphLrMFUwUCmh9JdO1/PytPpN5XoqwMDBc3onWqCyQ3mZMI4E7C05iJp/9?= =?us-ascii?Q?ljxuy9aB4e/pw801TnB3QhP8Jn+JuNBIPEALqOCWBkcslHsFdl9NfPsvZRhH?= =?us-ascii?Q?MItErZ6nH6sE0gtbzX6lPlnKdN22HDf2kdnTAHg3rWPe2E5vtvT7M4CMkU+L?= =?us-ascii?Q?81vdx0IRinBEE1lOikwCtvD04PEhzd8VM1jIlTV8Dw5V+QgCNhINvA58I0Zj?= =?us-ascii?Q?+L/jeyb+Hy9K5YUNUGg0NiUdsEstAfwLvwh9zeoWNynyZErV/2k0Ybhr1snQ?= =?us-ascii?Q?JWeqi+MSqTmz2dL5Nbxv9w7jAWcJog0t7SXhYtkCvATymXKBbH4gMAqzfsHU?= =?us-ascii?Q?7Zq40MwHSdd5u3fWXq5eOrMOKKVSQr4m1iz9Px4x0K9uyN69YLFDjRD89N7t?= =?us-ascii?Q?J2TGdYENOP7SM0kXUkMbqiSSE0oGNYyxXbOs1VqysVs2JpsjMXKNTXVYD6yn?= =?us-ascii?Q?pmK5+1CH/Sdw7gS1DvViJd9hrJWZZbwyHXqdDuUBwEVyWCYiJhkgOQz9st3D?= =?us-ascii?Q?na/P36Tp/MdvIQ7Gy0r6NNPV7Mn0mS9Mn2uN0jECCMNSlP7KdNAqdc6AGLt7?= =?us-ascii?Q?eVTaeZLtHEcKOcZ8W3zcwkfZow+kEtffNeLaC6jDICVHbOTCOih762llVUq6?= =?us-ascii?Q?HCDOVXKkENRYXSWevVxEHj9MRr5ytNyrz7/o/FoDoadhhEmsUGb8JlgvnZZq?= =?us-ascii?Q?M8ZqfDrw7+ILGd5+X2Qof/OX9zHLoYfAEFuLVzlqsE91Z7O+ao2JFyEIRCp6?= =?us-ascii?Q?jlpsLLGjxQ4JV8Rn7gmo3da28Eq3thmrQo5wohLjxEuFdUmjo57KwwIbOblm?= =?us-ascii?Q?JMM+dYzmJ5WLmnZal/rGUDfbURWvp?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1257; 5:cv8MyLOmnQo7Y/CFFpISKynY0UaWgv/jHQ49cBj9arLOQM8rsTu+KIh34wwyO///rziG3c9VTFcvbZKn8WOBGjt7H6wVYhGDcTDojJb/EA+DjbxfsetMJ9mRIOQr9NmHbV8PY2IYKf2uZ6JpvEH7GQ==; 24:bXtXAPkcy21ftMmwReioCwx+Jac7M9B1WthaV57Hl5yw4XlqjOxmWlIh//sssM7oHaseRROfB/bLwyeuM0+WZbKEheO3M7uNeVsTX663Lmo= X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2015 05:34:31.2550 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1257 Cc: alsa-devel@alsa-project.org, Zidan Wang , Xiubo.Lee@gmail.com, tiwai@suse.com, nicoleotsuka@gmail.com Subject: [alsa-devel] [PATCH v2] ASoC: fsl_asrc: old version asrc only support even numbered channels X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The latest asrc's channel bits is 4 bit, the old asrc's channel bits is 3. For the old version asrc, channel should be a even number. Signed-off-by: Zidan Wang --- v1->v2: 1. add an extra else if for the new condition. sound/soc/fsl/fsl_asrc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index be78dc9..16ff156 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -116,6 +116,10 @@ static int fsl_asrc_request_pair(int channels, struct fsl_asrc_pair *pair) } else if (asrc_priv->channel_avail < channels) { dev_err(dev, "can't afford required channels: %d\n", channels); ret = -EINVAL; + } else if (asrc_priv->channel_bits < 4 && channels % 2 != 0) { + dev_err(dev, "old version asrc can't support an odd \ + channel number\n"); + ret = -EINVAL; } else { asrc_priv->channel_avail -= channels; asrc_priv->pair[index] = pair;