From patchwork Thu Apr 24 11:13:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 4049551 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8DB429F3E2 for ; Thu, 24 Apr 2014 11:13:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AB0FA201B4 for ; Thu, 24 Apr 2014 11:13:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 8E6F3201BA for ; Thu, 24 Apr 2014 11:13:54 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id A1CB82652FC; Thu, 24 Apr 2014 13:13:53 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id E767C26527E; Thu, 24 Apr 2014 13:12:40 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id AFAF826524C; Thu, 24 Apr 2014 13:12:37 +0200 (CEST) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0142.outbound.protection.outlook.com [207.46.163.142]) by alsa0.perex.cz (Postfix) with ESMTP id 0CA89265251 for ; Thu, 24 Apr 2014 13:12:27 +0200 (CEST) Received: from BY2PR03CA040.namprd03.prod.outlook.com (10.141.249.13) by BY2PR03MB028.namprd03.prod.outlook.com (10.255.240.42) with Microsoft SMTP Server (TLS) id 15.0.921.12; Thu, 24 Apr 2014 11:12:23 +0000 Received: from BL2FFO11FD054.protection.gbl (2a01:111:f400:7c09::117) by BY2PR03CA040.outlook.office365.com (2a01:111:e400:2c5d::13) with Microsoft SMTP Server (TLS) id 15.0.921.12 via Frontend Transport; Thu, 24 Apr 2014 11:12:23 +0000 Received: from az84smr01.freescale.net (192.88.158.246) by BL2FFO11FD054.mail.protection.outlook.com (10.173.161.182) with Microsoft SMTP Server (TLS) id 15.0.929.8 via Frontend Transport; Thu, 24 Apr 2014 11:12:23 +0000 Received: from rio.ap.freescale.net (rio.ap.freescale.net [10.192.242.9]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id s3OBCBU8019332; Thu, 24 Apr 2014 04:12:20 -0700 From: Nicolin Chen To: Date: Thu, 24 Apr 2014 19:13:59 +0800 Message-ID: <64f9e48d758f3d3dd7bc806cef54df8aad8ac280.1398337861.git.Guangyu.Chen@freescale.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: References: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.158.246; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009001)(6009001)(428001)(189002)(199002)(36756003)(50986999)(47776003)(20776003)(46102001)(93916002)(4396001)(81542001)(81342001)(50226001)(76176999)(86362001)(80022001)(76482001)(77096999)(48376002)(92566001)(92726001)(50466002)(83072002)(89996001)(87936001)(79102001)(99396002)(88136002)(19580395003)(85852003)(87286001)(62966002)(83322001)(44976005)(80976001)(19580405001)(77982001)(74502001)(77156001)(74662001)(6806004)(31966008); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR03MB028; H:az84smr01.freescale.net; FPR:F0FDF75E.62954F73.7AF5E24F.64C256D1.20121; MLV:sfv; PTR:gate-az5.freescale.com; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Forefront-PRVS: 01917B1794 Received-SPF: None (: freescale.com does not designate permitted sender hosts) X-OriginatorOrg: freescale.com Cc: moinejf@free.fr, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, tiwai@suse.de, lgirdwood@gmail.com, jsarha@ti.com Subject: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Simplify error msg in simple_card_dai_link_of() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP It would look better to use prop instead. Signed-off-by: Nicolin Chen --- sound/soc/generic/simple-card.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index 383a4a1..c091557 100644 --- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -166,8 +166,7 @@ static int simple_card_dai_link_of(struct device_node *node, np = of_get_child_by_name(node, prop); if (!np) { ret = -EINVAL; - dev_err(dev, "%s: Can't find simple-audio-card,cpu DT node\n", - __func__); + dev_err(dev, "%s: Can't find %s DT node\n", __func__, prop); goto dai_link_of_err; } @@ -198,8 +197,7 @@ static int simple_card_dai_link_of(struct device_node *node, np = of_get_child_by_name(node, prop); if (!np) { ret = -EINVAL; - dev_err(dev, "%s: Can't find simple-audio-card,codec DT node\n", - __func__); + dev_err(dev, "%s: Can't find %s DT node\n", __func__, prop); goto dai_link_of_err; }