From patchwork Sat Nov 11 13:19:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10054271 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0E82360632 for ; Sat, 11 Nov 2017 13:19:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0CC429988 for ; Sat, 11 Nov 2017 13:19:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C497329A21; Sat, 11 Nov 2017 13:19:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAFBE29988 for ; Sat, 11 Nov 2017 13:19:41 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 25560267187; Sat, 11 Nov 2017 14:19:39 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 924AA267187; Sat, 11 Nov 2017 14:19:38 +0100 (CET) Received: from mout.web.de (mout.web.de [212.227.15.4]) by alsa0.perex.cz (Postfix) with ESMTP id 40B3426718D for ; Sat, 11 Nov 2017 14:19:34 +0100 (CET) Received: from [192.168.1.3] ([77.181.92.20]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Mf0a9-1ebtF22Vez-00OXe4; Sat, 11 Nov 2017 14:19:29 +0100 From: SF Markus Elfring To: alsa-devel@alsa-project.org, Arvind Yadav , Bhumika Goyal , Jaroslav Kysela , Takashi Iwai References: <4c38a970-2407-3559-060d-501b8259b3fc@users.sourceforge.net> Message-ID: <71f0710a-c884-4b3e-7e8e-6033a9142e3e@users.sourceforge.net> Date: Sat, 11 Nov 2017 14:19:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4c38a970-2407-3559-060d-501b8259b3fc@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:/wskmSNelxjcpSLhkg4QEXd5nqwa3TUygxrVmHGnhHXpwIMiV3J LmvjDNoGSlvo2+/puZReNX1QNOC60r07JLchJovEq/FbZeB4aPUUD0bFqBPfhk7VfD9a/Bn 0aO3TfSFiGshvhkkoM0MN2w2u1AnX4KKaAAP5IT71rnm8UXov/aosojlSC9k13/F7HfCZ5K AsKwy4QArxmK4J9FjL3Wg== X-UI-Out-Filterresults: notjunk:1; V01:K0:DVDkhRW3iSQ=:X0sbxXIstQOsZuxpG4pzbo txkxbszJwC3+hm1RWEo33cFHd56Pf2PXO/1kexs9ZZQXaBdu2Pog5hoJPtGT7eJbpNaJ7Ig9J W3P8zLYmdrhK3f2aIWpYnRwa8/XO3/PZ558hcuTAahNHgGgAkWC6h9xnE66h5y24VgPhWraQc 3+NWbrSElZTOIBFUI7vEXJ8uSuEbnO/AXhk8qwlUS0uQZCol+R4zCfJk2TOmfk3czklA3bdg5 5qXwkJdxt2zvuVwZ1JVcKbVeuuhEfxQe4gb+Qq6o5Ipu+PhSMNBBLp1pAwZY7Sh2BDrN1U7kG WVRb6Nniexy/jEYtdbWEq+GtTJjz0WO3AZYuZrbZGbjiIVXYd5N+wM8z29mSya6RIrIZlyOTR WmNRcE0jD4nGp75ZQojjjZ9oEJ7B0tFN7D3D+sh0XCMvhNVi0CDzko7pZIif8XrHK59NoPTJq Lx1oUqC6Ise5QJab1HsH8KHgrYfeZEqXjw/Vaz9Ug3a3NjAHTA2uPNvhYsKiKD1rPcBZ/qM/L gP/omrLFXZLGGfAWZi3cE51GHIUbQuoCZZIpdV40ggb5/8pZgTOB7xX1hCrtItWPjikerUXLg PmdyyDaRSp78f02I8nL2y9pQPqkF3fHy2GCl81V18EJFFXq2uZBKaagr3jwds2uQgZxKLDx5g S6zq9MhKq8OjjkEEg/91i1KtIPOAbNiGsShoQJzp+Ra2Vtjob55ZmBj7uzQvlYsW1GpbtNXNB 2oTVGFOQZ7qfEqtGi4jsVpnbhcy0iDRkMNgGdmcwZnSOzdPZ0VwDeahJ0QSgR8CHRY95BboO8 G9fxwOYsum3Fg2k5mpVxVbulFIzyXlNiSjCacPa/VAtHvpadWc= Cc: kernel-janitors@vger.kernel.org, LKML Subject: [alsa-devel] [PATCH 3/3] ALSA: ml403-ac97cr: Adjust four checks for null pointers X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 11 Nov 2017 14:04:04 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- sound/drivers/ml403-ac97cr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c index 4cf964ea2802..d897175a63b2 100644 --- a/sound/drivers/ml403-ac97cr.c +++ b/sound/drivers/ml403-ac97cr.c @@ -533,7 +533,7 @@ snd_ml403_ac97cr_pcm_pointer(struct snd_pcm_substream *substream) if (substream == ml403_ac97cr->capture_substream) ind2_rec = &ml403_ac97cr->capture_ind2_rec; - if (ind2_rec != NULL) + if (ind2_rec) return snd_pcm_indirect2_pointer(substream, ind2_rec); return (snd_pcm_uframes_t) 0; } @@ -788,7 +788,7 @@ static irqreturn_t snd_ml403_ac97cr_irq(int irq, void *dev_id) int cmp_irq; ml403_ac97cr = (struct snd_ml403_ac97cr *)dev_id; - if (ml403_ac97cr == NULL) + if (!ml403_ac97cr) return IRQ_NONE; pfdev = ml403_ac97cr->pfdev; @@ -1120,7 +1120,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, *rml403_ac97cr = NULL; ml403_ac97cr = kzalloc(sizeof(*ml403_ac97cr), GFP_KERNEL); - if (ml403_ac97cr == NULL) + if (!ml403_ac97cr) return -ENOMEM; spin_lock_init(&ml403_ac97cr->reg_lock); mutex_init(&ml403_ac97cr->cdc_mutex); @@ -1139,7 +1139,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, ml403_ac97cr->port = ioremap_nocache(resource->start, (resource->end) - (resource->start) + 1); - if (ml403_ac97cr->port == NULL) { + if (!ml403_ac97cr->port) { snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": " "unable to remap memory region (%pR)\n", resource);