| Message ID | 87a6yjy5sy.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7ad26d6671db758c959d7e1d100b138a38483612 |
| Headers | show |
| Series | ASoC: pcm3168a: ignore 0 Hz settings | expand |
Hi Mark > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Some sound card try to set 0 Hz as reset, but it is impossible. > This patch ignores it to avoid error return. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- This is for mark/for-5.9 Thank you for your help !! Best regards --- Kuninori Morimoto
On 25 Aug 2020 08:39:24 +0900, Kuninori Morimoto wrote: > Some sound card try to set 0 Hz as reset, but it is impossible. > This patch ignores it to avoid error return. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: pcm3168a: ignore 0 Hz settings commit: 7ad26d6671db758c959d7e1d100b138a38483612 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index 9711fab296eb..045c6f8b26be 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -306,6 +306,13 @@ static int pcm3168a_set_dai_sysclk(struct snd_soc_dai *dai, struct pcm3168a_priv *pcm3168a = snd_soc_component_get_drvdata(dai->component); int ret; + /* + * Some sound card sets 0 Hz as reset, + * but it is impossible to set. Ignore it here + */ + if (freq == 0) + return 0; + if (freq > PCM3168A_MAX_SYSCLK) return -EINVAL;