Message ID | 87a78o8o2m.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | ASoC: soc-core cleanup step6 | expand |
> +static int soc_init_pcm_runtime(struct snd_soc_card *card, > + struct snd_soc_pcm_runtime *rtd) > { > struct snd_soc_dai_link *dai_link = rtd->dai_link; > struct snd_soc_dai *cpu_dai = rtd->cpu_dai; > @@ -1998,8 +1998,11 @@ static int snd_soc_bind_card(struct snd_soc_card *card) > goto probe_end; > } > > - for_each_card_rtds(card, rtd) > - soc_link_init(card, rtd); > + for_each_card_rtds(card, rtd) { > + ret = soc_init_pcm_runtime(card, rtd); > + if (ret < 0) > + goto probe_end; > + } might be better to first introduce the error check (functional change), then rename? > > snd_soc_dapm_link_dai_widgets(card); > snd_soc_dapm_connect_dai_link_widgets(card); >
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index f624a2f..843bfe1 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1123,8 +1123,8 @@ static int soc_dai_pcm_new(struct snd_soc_dai **dais, int num_dais, return 0; } -static int soc_link_init(struct snd_soc_card *card, - struct snd_soc_pcm_runtime *rtd) +static int soc_init_pcm_runtime(struct snd_soc_card *card, + struct snd_soc_pcm_runtime *rtd) { struct snd_soc_dai_link *dai_link = rtd->dai_link; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; @@ -1998,8 +1998,11 @@ static int snd_soc_bind_card(struct snd_soc_card *card) goto probe_end; } - for_each_card_rtds(card, rtd) - soc_link_init(card, rtd); + for_each_card_rtds(card, rtd) { + ret = soc_init_pcm_runtime(card, rtd); + if (ret < 0) + goto probe_end; + } snd_soc_dapm_link_dai_widgets(card); snd_soc_dapm_connect_dai_link_widgets(card);