From patchwork Mon Mar 13 03:46:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9619719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F00AF604CC for ; Mon, 13 Mar 2017 03:55:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D259028446 for ; Mon, 13 Mar 2017 03:55:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4BD428452; Mon, 13 Mar 2017 03:55:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE8D328446 for ; Mon, 13 Mar 2017 03:55:51 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2ED6A266A9D; Mon, 13 Mar 2017 04:46:17 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 3925E266AA3; Mon, 13 Mar 2017 04:46:15 +0100 (CET) Received: from relmlie3.idc.renesas.com (relmlor4.renesas.com [210.160.252.174]) by alsa0.perex.cz (Postfix) with ESMTP id AA7EA2666E1 for ; Mon, 13 Mar 2017 04:46:09 +0100 (CET) Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie3.idc.renesas.com with ESMTP; 13 Mar 2017 12:46:03 +0900 Received: from relmlac4.idc.renesas.com (relmlac4.idc.renesas.com [10.200.69.24]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id A90256570A; Mon, 13 Mar 2017 12:46:03 +0900 (JST) Received: by relmlac4.idc.renesas.com (Postfix, from userid 0) id 8FB65480A6; Mon, 13 Mar 2017 12:46:03 +0900 (JST) Received: from relmlac4.idc.renesas.com (localhost [127.0.0.1]) by relmlac4.idc.renesas.com (Postfix) with ESMTP id 8AB7B480A5; Mon, 13 Mar 2017 12:46:03 +0900 (JST) Received: from relmlii1.idc.renesas.com [10.200.68.65] by relmlac4.idc.renesas.com with ESMTP id NAD27682; Mon, 13 Mar 2017 12:46:03 +0900 X-IronPort-AV: E=Sophos;i="5.36,156,1486393200"; d="scan'208";a="236478873" Received: from mail-sg2apc01lp0239.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.239]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 13 Mar 2017 12:46:02 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TvTVC4y4YQMbQn8zRVKt+cF8ESsFlvoY614mdZggxus=; b=dMjjbVnAulO0eyjadlPDiflfQR5xgMlAcXzCbiKMreH4xmIgYS10o+hfspa98ZzbJi/jhjmUPHqsFEMsfh4H+UFE/iINtJXiLeiihvNPZUQH4bUTrPwSc51bazx7VyAqAQkOww6zKMTFC2cXPzPRcBqQggrgCZrYIf+njXke1Eo= Authentication-Results: chromium.org; dkim=none (message not signed) header.d=none; chromium.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by SG2PR0601MB1936.apcprd06.prod.outlook.com (10.170.133.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Mon, 13 Mar 2017 03:46:00 +0000 Message-ID: <87a88pj105.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Brian Norris In-Reply-To: <20170311003939.GB4586@google.com> References: <20170308231854.50167-1-briannorris@chromium.org> <87zigvz4q3.wl%kuninori.morimoto.gx@renesas.com> <20170309002129.GA99773@google.com> <87varjz31k.wl%kuninori.morimoto.gx@renesas.com> <20170311003939.GB4586@google.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Mon, 13 Mar 2017 03:46:00 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR01CA0058.jpnprd01.prod.outlook.com (10.167.153.146) To SG2PR0601MB1936.apcprd06.prod.outlook.com (10.170.133.150) X-MS-Office365-Filtering-Correlation-Id: 86aa813b-5939-4fb4-611b-08d469c377d4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:SG2PR0601MB1936; X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1936; 3:R/mGCMGlfzN1oQUvkp5BtPiKBMX8PE4kwYWXpLloCXRXVQtifENxG/PApgUvG/n1U/imAftwRH5GO6CAk7bZnIooLf3/dbvFb4nyjSmIcCHPXN10TmnujNcI0QdOFyqJHH/XPkMedPNKR7ZGp8TitCXNj+9cS61zvSr70Ku9i/bcFX8LIoaBsuHjpHuHYXZ0goKEUqM3P+Tli7vh8yPUii2FpGGOJtV77Q36Ioaj5uPYxMkNt/V/9PrhqFQdZZ2dDWrICG2jXXbJunfBKG9IVXlxUP8Uaornu7BFggHYyFQ=; 25:hUwB8LNqPs1Btg84zIEO0gVnnHidCrAmaa7/Mq27QD0UScskOpyk8Ul/gQ3agDTMF29bdRMfbVrrGZoEHxVBh/Q8nxdj3NxdWr6QWp6gQ6prO39SrbcBDg5lyzjtlQF7LocZBje6F71NVhtlAKHl+uoOBbMp7RAHvP/27QGwG0xJHUvnBqrT/nJyKpo4cvsObDJa43Hk0V6hJLkWH5lmemIYDDAOXkyGASAqpuEe2vBjXPDs1KdRbkoJUmKL4gMUxAHFFbp+n1mCixbhZLbl5x1dGP99QJ+A0waCeNakeYmFjUk3ijwz5FEHRP20N05+2uZ6A67kxaaguDueYo7VAUl3iMjzQZAs0VY+sVqveaeqKqIBWhw3ZwktPOByPQ7cJFCjKtRAFF65IvD2/3fkVAUCy+cLW72DQPB5mwEX3adEOjoZ6rucMq3VjGSfb/5HhbeTWxVi0z6nyuTRVgSGZg== X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1936; 31:F342wA5QB/lsPfooBmEZPp0yFNkaPklEI9bL6yGWAx/EsQJ2aK4z2l5nzMcq0iRnYfQab0MbabeAymHNZg1KsRMA/O+XZDSjmlXnoVKW28sHn+4MVjYK9QW36uh/xUNYQqjrTKxu6C73K5Eyx1nKKT5rpGun5rj7z9yeUO7ahO8KLK1T/MRjyO6183OVklfXHtxF69qlaKATokseJzBI8e4Kt8ElbMExI5WuZCxJkho+42uATEcltKziYZeSXEmmWuqHAojLMm0iAK4AGXl5fGQgb7pKf+TE4hmi8Fc4Qlc=; 20:iLOcenvf6SpzwLkTYMWv6E0c+iTjrLg8k9gq/w4baNK2jBAJN5jgdg6l+WEtaLudAOwGABQSj9V7KFBm7u218UO33setLzOfCXW5xqlQYBbWc64BvLbnG3Y2cQCIIpWXd2ho6J8r868Dc7IkVHB52McmIHeXGiPMZEvGpDZPL7wBVAITzm2avF5xLDdF5rR9zZ0uqIS4btVSMmfaRiji+Qe9Dgj7hlk16jtmemaXrFovJ3PGod9WuGJf+QSz8l2zHNkbAS/XHjU8oeD6VJhSyuUOd+3HDvqBB0fH/FkNJ0UGhtVyd42nJTgTND610/2zFR0UiVFi0w2MhhChLioxdG4lObw5bxHh3DrRMxWzbaeE4/yOc7CDC7Kjdx1uWi9iBQZjL3C+yQ0cch0bY7e8Q3IIIoEGw1G4rHCm/zczJSoy4HtiBAO3Ol3h1rrLMrcBUTUVxEtfCQczxBOesjFk2CH03vkBR8A6ND6oLliPkTGbO+3q3w2iICGmqEJNUPUp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123558025)(20161123562025)(20161123560025)(6072148); SRVR:SG2PR0601MB1936; BCL:0; PCL:0; RULEID:; SRVR:SG2PR0601MB1936; X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1936; 4:jgU3gfw70uocy4N5TiPm5b00MsSAxhWXKBC05EwHG+Y191V5tuTrREJZYAxpOL34q9VoZlzyRVXpwYDG3TICmFGPKBOFm00kY/sgdmXzO7y5XyF00OpWFM66EmFv39x2LGNW+Y3yjTs1hnpPGzZomWU53SbsCpR0URuMko7erG6uAJ47ngVr66l8B0n/eiii6AXgAkQ0oPVbTAwg0eBYbQ2rg2tySnyDCzgSKdDRn8Kqnm6QekUsm+Jyzqx2dsq9ufPf8hNc6r3t/KrSkO7hMKCiIsrE70wGvpezEKbLUcNRzK2PL1V2cqZj8wCJ6Hf+MnTkeqXynGQY/uNiOOnoviSd34gZnk9Fnzm8W1lBqYcVBeyLdiCbKpl5keg4XndVoEf2aSaHcKFvne/XdygYZ82rTODjfbA9OogXJW9pbm2/CzPe/AJ3rOQidLiXicn9r1h4FuUzXtjuxX99tJYkEkVpM/RYXw1m4nFgNgIOpfx99CspUJUhMd7jkT88ywDZ8Iw4t+p2fPOcSvGj9t3lO1br/3osDZ2iYR5w1S1RXut47BcgXJUtA9/jF3IZlsfKfMnQq8HCDq+158OEDjb1gQLquNeS0SUcf05S0HTOd7Cg3gBmevx4FKU/Yx347mff X-Forefront-PRVS: 0245702D7B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39410400002)(39860400002)(39850400002)(39450400003)(39840400002)(36756003)(7736002)(305945005)(33646002)(93886004)(42186005)(86362001)(54906002)(25786008)(4326008)(53416004)(46406003)(83506001)(3846002)(6246003)(68736007)(6116002)(4001350100001)(81166006)(8676002)(50466002)(189998001)(110136004)(229853002)(2950100002)(53936002)(54356999)(76176999)(2906002)(6486002)(345774005)(47776003)(5660300001)(38730400002)(66066001)(6916009)(23726003)(50986999)(142933001)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2PR0601MB1936; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SG2PR0601MB1936; 23:Q9usrTHc598Fkt/SglotFyifoN95Qounckajdz1?= =?us-ascii?Q?EFktCJnzbWTTKYfTHRyhAWerXQztZ26PRVXyDvMwS9Tn+iHdDAKaeKZuCoz4?= =?us-ascii?Q?EazrLrYJEck2Tq62omavH891a+XW5D4sHkgFGHqjO4ruN2SSmx9cKoRQ4pzF?= =?us-ascii?Q?Gwg0QI2U3nwD2MTQDA4JmZznKr9LNGlVWIC1Mvu97ykY/ztIBhhdP0uu24Zv?= =?us-ascii?Q?Am+zDPjQ0UvLUzZ8GFy6IfVU4+iXMNJsxu830300XDL+CccnAXAMtF6RCb16?= =?us-ascii?Q?OAUnVYFK30v+VR/S4/IGCkq4v7yaK50w+LpiI6Pv6SNRYrqFfdwYGYWssa5T?= =?us-ascii?Q?Qks5Es4P8loK2Zns5TuaDFFkXOBlczZZIoIRAxWKQup1ONs2sePjMG/gWv35?= =?us-ascii?Q?h0BNO8nR5a1S95Z11yVMBVLQJYrkNspNAtT2MvS/t+axrr7o9TJe8KhKenQM?= =?us-ascii?Q?eVi1Eb+0mHmPCxGuGuOiChz9/NIovqMhk3+uBcm4WoV4sV7tvAIGuUqWK3o4?= =?us-ascii?Q?8bM4Ff+r+PKTYnfu70FE2S8NME4a6KQp2AwM4XVVlZwSVatGs9lHDQX1bg+y?= =?us-ascii?Q?RjFLHbGwvX6kaIiMVd5tJcHDarNrOfzPjiV2LIb0wgLr7A2CC7jchDNFpDsI?= =?us-ascii?Q?jHCj1wfbYCFWCUisLkyLsosVMUnY9qNfoPpBdziNqVARhlD5uIQvl2eF/Vo2?= =?us-ascii?Q?SKwFwKTVqgUnQ+Hwe6i6yjq0U5aZ0AMb+5jEzXeuEfZbOMyewM3CB6yWOCFd?= =?us-ascii?Q?Xm4g6DIuela0FYEN3hBA8e/y0KgukJNMGNMcLcdolTDvJF2flaE3ar8CvCO9?= =?us-ascii?Q?2GKeHCHX7l3aZugxCer28bvd8e51/1I4dcO6j5BKjoLEoI2iphsuj8rp+ca7?= =?us-ascii?Q?7NhTRVsdS0+fpENICJDHcnzJnfJ7ui2CoUGEeEv5WFNtrECm8dLS6mtdR1Bq?= =?us-ascii?Q?cc7X/isspBZTduRbbpNzmQYcqLzHTpVzQNsx9tiMKtjXMPd/pgUkTktGiLiP?= =?us-ascii?Q?QKz/Jf1HnPfsYGftilGbYhmLxb+NfDcSGolAX3OkqdAO74n4ZCQyNJa6DDmK?= =?us-ascii?Q?u4QuFyY1onpGQbdwGFB62WX9/P3S27dHYikdSwFOYnUeFSJ3+tqvKarLrKVI?= =?us-ascii?Q?AuKILowGTkGmqygUPO8UmLfcjWxXKr59NmvC5C0xgr5Kxzh0Sm86hGZjvsZQ?= =?us-ascii?Q?mj5ac+Da708CM9yA=3D?= X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1936; 6:TXmG5s+JeUC1bs9PZz1rR2KsLE0olk9CX0vlbCfqaKOJikr5FyM5UTx8kE/dpRsT52ucf0Tlggb7+hSPh8Hts8WIPHBCxTPzwCwijQzEWlSRv7B6kUcJ/Q+tbnZtjGYQrGNsHgL/lqsXORQPFFfDDaJ1CbPLWxaTfwglK61zK1bqMDvSJDmJasbeiuE93DVGSyFjI8LlZXR9E+536TeHPhLZH442JTIXeT3Q8j6RFSMhvsP5FeF+dsV0re8nsEhnlOg4CGPLcSh6vqZrsurbPRRFnLevkgHlkKa+omTSvSRSiY26A0gWmV3tj8GLylJFuGMxf6wZECX+2+fEuzC8/+OKpU4ettnBPWwKF1B3UTt2PFUItBvpYvBA+Ma5t13nKripDmtCV3EKB8kdDV9U5Nws64ZmFvbIdBSNuqiBPvs=; 5:y4J6grW/YsYqMVQY+9WRrj5BnqnnzbW3q+wRXp2qxsh+biCBsnFJBf0eScmTAEds9iSuOvDMZxyvIzq2ol0ESGdxB8aPCTrcU8gMqXHQbYcsY4khUOg06p9iWTxfR8cD1zCbHyrQLQ83w9HqXrkvYsnRG03Jrkww0ghVvftZx04=; 24:awSiUOqHqAMn4b0MhIH4cuNW9zrEoW6/0wV3MqfQmUuFwKTnSEQeY0B+VetUY7T0QCKSyKP4QdthkbZlcucXNCOjmOf4CYDb/Li0zRZZnqc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1936; 7:m0Fvt27SiN1zPqRooHNYPuHVoCo8sghturXQpoYydp+gDXR7UoJH2PLoEzWSMAcXYqBy8LusQwP49xqV6wupmtiHZqTavMxT3yDeOcw0PKFAuU7aDnDabfZte5lPISbQ2PfSzluhSVdIuIWAs08olkRiv8eyupICX1cIwkBGdmfABhia2rLilvSgAsIGSfQ5YTlW3UKrQm52V0R0OkBuPTPe4+7fMrUrRDCaXnWJbmKkayEElIV8K4roNiviOx7Rkp7DIOnr2OeqrQ575XEhGyKUPvbHMz35JzuZSoPJ6TPNB4zuF0ij2aoXizlMP1aBU56XNnWASoRBAZ/Qr7PHGQ==; 20:teOX2CO5l34chMZWqvOm8V45vRYmYonNkCGOp9yci7wtXPhcHgWvjZx28ldqwB+2fdgNil0JZdKt6SlhVTVg2dDS7CmxrJcBrCAwNuEQ3NgT9/AosNjt4N5Bk90DcHfTapOxZmOae+/yBLtoEgklPk9aPZu/lsoZh6+pn30VYvc= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2017 03:46:00.8842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR0601MB1936 Cc: alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown Subject: Re: [alsa-devel] [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Brian Thank you for your feedback > There are 4 drivers calling that: > > snd_soc_dummy_probe > rt5514_spi_probe > 2 instances of snd_dmaengine_pcm_register, via rockchip_i2s_probe > > Only the latter two seem to run the assignment here: > > if (platform_drv->pcm_new) > platform->component.pcm_new = snd_soc_platform_drv_pcm_new; > > Both snd_soc_dummy_probe and rt5514_spi_probe find ->pcm_new NULL here. Hmm... The crasher was snd_dmaengine_pcm_register's platform ? This means, in your current kernel, dmaengine platform dosn't call its .pcm_new (= dmaengine_pcm_new) somehow ? I'm wondering why ->pcm_new became NULL which exists on probe timing ? Can you check component and driver by this patch ? This is very rough but enough for debug --------------------- --------------------- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 5933851..43da1ec 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -3322,6 +3322,10 @@ static int snd_soc_platform_drv_pcm_new(struct snd_soc_pcm_runtime *rtd) { struct snd_soc_platform *platform = rtd->platform; + printk("-------use name: %s, %p\n", + platform->component.name, + platform->driver); + return platform->driver->pcm_new(rtd); } @@ -3356,8 +3360,12 @@ int snd_soc_add_platform(struct device *dev, struct snd_soc_platform *platform, platform->component.probe = snd_soc_platform_drv_probe; if (platform_drv->remove) platform->component.remove = snd_soc_platform_drv_remove; - if (platform_drv->pcm_new) + if (platform_drv->pcm_new) { + printk("-------add name: %s, %p\n", + platform->component.name, + platform->driver); platform->component.pcm_new = snd_soc_platform_drv_pcm_new; + } if (platform_drv->pcm_free) platform->component.pcm_free = snd_soc_platform_drv_pcm_free;