From patchwork Tue May 16 01:48:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9728289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EFA4F602B4 for ; Tue, 16 May 2017 01:57:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D68172843B for ; Tue, 16 May 2017 01:57:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C8C3828481; Tue, 16 May 2017 01:57:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F18A02843B for ; Tue, 16 May 2017 01:57:29 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id A3A0B266E50; Tue, 16 May 2017 03:48:38 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2ACEF266EC7; Tue, 16 May 2017 03:48:37 +0200 (CEST) Received: from relmlie4.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa0.perex.cz (Postfix) with ESMTP id C8BAE266B38 for ; Tue, 16 May 2017 03:48:29 +0200 (CEST) Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie4.idc.renesas.com with ESMTP; 16 May 2017 10:48:27 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 2981E5FA58; Tue, 16 May 2017 10:48:28 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.38,346,1491231600"; d="scan'208";a="243923926" Received: from mail-pu1apc01lp0019.outbound.protection.outlook.com (HELO APC01-PU1-obe.outbound.protection.outlook.com) ([65.55.88.19]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 16 May 2017 10:48:27 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Log9AG5LZ5NH+raY8Ovc+dY5O2flN1AagL80pvoCezA=; b=ITTITLvqbsxsPoZinhlAEY/XHrOAoAc/xrG6EcKMeZxjnJV8BbyrQk10LvkMAgSlMFzM1RYOYXCBAwmwgj/6V7jAY7NFrLJ/qg6ncETN6QnFAhrr/FfyUK3fIWFo87C+OBGdnQlMMbYQMHOV0dLxKf3d+ek4XZUeJRRMcGVLxW0= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by KL1PR0601MB1878.apcprd06.prod.outlook.com (2603:1096:802:7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Tue, 16 May 2017 01:48:24 +0000 Message-ID: <87d1b9y3sk.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Tue, 16 May 2017 01:48:24 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: SG2PR0302CA0010.apcprd03.prod.outlook.com (2603:1096:3:2::20) To KL1PR0601MB1878.apcprd06.prod.outlook.com (2603:1096:802:7::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a1d5333-1c4b-4991-d045-08d49bfda47d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:KL1PR0601MB1878; X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1878; 3:X1E30f329nwhdqIYuzuz8gPXrFvc8S1qYhG/D8xSLEdxfAkIViZO02wtdVDrXTOZ0TB0m+uz1A3IlA75ufaxPlPKErbDfpR/EXcbnsR2FhhtyzrfSNndiAhCd6jeFRJiSRq8VbN0he040qoV3H3SkrEJwEsm9F3f5kw+qkE4XxFd/XwagLHTbh0qVzNdyYxMiDyz4lkwzkLqlQASF2QDnmpM3R5z2cyZ9taFDpKKSz79ufXm3F7y/qSsru6KQ157SVt0scdWYzQf6R6qox5unDMYYK4Ue9DpL8niNb0G59yXP9FZKNfh3e4WVbmIs5PKL9HcKygH4NUR5Cr64Jb30ArnuoZspQtLvdOONOfrlBQ=; 25:Kfrn54WyflWQqdeNeZ2Dh20edbY8DeehK1275mYouEudAP/S7a9QnntBCOxqr2xnilPJzZO+dshzX/hgU8vuNl/AoxaTPUYF8z1FjoPJ2yzNdisMKcaIjCMS9Cq5w3ch9Lf4TYinSfJ8yPUAAAIbK/P3VAICEfrSzYlhc2MeMzq935eKe8r/h8OzMp7mz4ckVkIZd8Wyb5yiMl1E0b+7NNyH8z3V7+SfeJ/pcuTc5/sU+NlhnwpnFGtS88US7thk1hrmSTsnZxXnjWfIb3swcQnZTQ8+aol5ogqv5r2imSzyh33d4GKWsUc3ZVCl3+WzP9JsYC1u4nLovFyvtITPl3xBpuPngL8zZ6kVarhqQO1stnd4LNJW4lVaR1GyssTgg97DRzG08ADimZRXIiqXIxV/tpYJCOjrL8XAtAincqJePFw7CaUTtyYVMOf9asbDZoPb9DUhaslHlcpOXKhx1YzDNJ/gfvZFtkkUTj05K3s= X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1878; 31:GGuLzydkhCPD5XEGglRubLp9SPt+Eb1lG4mqeNoBWVo5tI+KquQis8qp6r7KlxLyTXu+u1RhONx9y81PEqKBcpC+vZYCx7rMSHwQdKUt5NvdD5JIR7zypHynVy51PAYkxgEc/nSdiGDZ9n7kmNxDhMxbclR8XOod7hv9464NYtvA8boXUiJFu+MmMG3+pniM0/Ns80JHyFwqgLurSg7RgJnMZGUn6GE6oRddwkro1+g=; 20:6he6orsoa0zRKZD3G2fxvYy1MX5c3iPRrhmkBas4aUVFoPVJ5qSPh6GtR9Mf2fRG+l0slgtu3fPEXSHnGN3aHUnVB6IzxdkkA3n5U2th76qDvwbryLZZPy0aZ8gruo2BP9P0KqMx89W6xuw2NW6VED+tRHTm2zzhlUSF8IywG5nmZmfau8apzz+ABBSkRetLrCv9V5e/IN7QHyNXdxOCffvM+uuV36Hi2JUjw1UcuHLGfpGdA3ixoJRZQf/6dCRXfsYp56OSDcuC6Vski6G2APdW2QfzEcP83B5pR4lF5STANPJcyNEjiF4BlgscMybEvxwY2pnjBdQm0zjKD7O1rO4FbIHAwPFfiwmXd3IhaTRBHNd4hv60EOG+pblGr9u/lp9yYt5/H75Q9shK5sLkUhEYzaZKPQE+cLZaoX/o9w1evikvvxENaSHjz1xrzbV9EXqKq8Wy7M7//MkAoAHKwFeryRlzvgWVn5AJ0rQnL0msjYhKO4iopQ5SKrgeSbWU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:KL1PR0601MB1878; BCL:0; PCL:0; RULEID:; SRVR:KL1PR0601MB1878; X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1878; 4:/TQ0KggL0HXv/6yagQreMi6ZbsbGQ3goBn97J60ttTxUCYeODXTGtbEl2x7VTgqLfqBq3btAoiECbkV562fFCePpsQVc8Oqp27+t3F0V5FVeN+DWcYJp8Vyp4QtN5Q6pAqhBaaEMLeNGFcZwLGkB4TRvh6nJWtu0LFVT4nnOPGGnb+Eb2I4te3i055GSS0F9Uc8Ihm8HHOo+mNlFTEuA7t1KtuwU5O3d8E26ScpSGIB1ZlSyy1j+M+OkSgkcwx1PPAPoNT/3VXhbNMUj5NVta+Ri79SY4wFJn3tTng2iut+Ixooo8uAGbkKU7hpQ2naFKTzsoXZroZRFxSCqSj5El0fiqTsloTcC6HAs1SHZiK4iAFlbSGskvoFEEpJmEI7Ddml5R0vfWLvp9/nqMHJLesVYPQvUGsb0Q+Az1e6V+1qRt13I4CGWv5ybi43JLuZj3wf70YJVNQh7FVc1kv+V0wTlWJH405K9wzd6n0lAMKf8OoFyIZUgFeNvZDPVDndSHEQnRZYi48WrjHlxqfkoPGQp/lReSaFg9QRN3SpmGKGQy4r1id035Pi0GbAAS8LRDWe24jF8Gh8Smb/YmqlFyEWw/DzONDvw6vtBk+A+qCeDS1YVVFnddhmAHt7GS/gji7dymfLIGOmN/OMKcMJBEA3JG3m5hedwraeUHhPamGuf4WPGOlJodrFZMl4zfnTYupQj8WhqJkhb2gqCV2Of7e/xT2nnKfPInNhtogL/b94Dz9XvqqEED1//BCYIth9nTGTUwkdFVwanKyhMRORElGjS7nSDYPt0E2RhrT1CSys= X-Forefront-PRVS: 03094A4065 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39850400002)(39450400003)(39410400002)(39400400002)(39860400002)(39840400002)(42186005)(54356999)(54906002)(53416004)(6916009)(50986999)(36756003)(6486002)(478600001)(86362001)(47776003)(33646002)(66066001)(23726003)(4326008)(3846002)(81166006)(25786009)(6116002)(189998001)(110136004)(4001350100001)(8676002)(107886003)(38730400002)(83506001)(2906002)(5660300001)(7736002)(46406003)(50466002)(305945005)(53936002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:KL1PR0601MB1878; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; KL1PR0601MB1878; 23:DXU2nXXCbc+SP8jof88u2ydLt8dOXxcT6itf4mQ?= =?us-ascii?Q?nkafvuXs/QAkcIYPsBed4TIMFTWbdeenXHd4BTEqkD4Lx9N0E5Jf/hxBnxY/?= =?us-ascii?Q?k0O4+C/gLArFPfpf1N1eptXm+DOYVgoE6sQ9F7CCWUOgUxk89Ka8bbmXOtR6?= =?us-ascii?Q?ADHrU8Rddtx/BEwKq/TTZk31p1SSsEpRHI/7AEdllI4HArRwD3PJcntFJ30Q?= =?us-ascii?Q?rIh0clKA2u8Pb6QF5zAVnTbJ1r2WEZeRbXDGQqTF2UWLwHQ1cqKjqQ7gRxc/?= =?us-ascii?Q?SYS77CYGEIhEf6hcoFDMs+A4JlAruXrwUUWC2mkCLdHrieFxXLq0NUc/0+de?= =?us-ascii?Q?kyXFTxNh3ZwbZMNAxAgxNFzpPEn+fEI5W7dmSNi9oiifb+8vHnCkbZxu2FWy?= =?us-ascii?Q?rlMnNMbFpj1LJYGgUaT2HSe3vEu02K9Imalxlhf0c3dt31Y3s0tMeZfvLoUp?= =?us-ascii?Q?4jwCx0512W9zmOxtylYMS8Dth45C/FXsszfvRY53kbBF9BVyN7HPDW98rdor?= =?us-ascii?Q?7JXrEBvqbcoi28F5xqAkmd7CsqamY1Suq6loQcFzobRTUannyXzwENp0+C3+?= =?us-ascii?Q?HV2hbNGiC2PQeyqbIwK5OWjlZ1U/pKqCQC7nQ4r3j5wZs2JaLxatGp4tcUE7?= =?us-ascii?Q?VoG2A7khxV4c/L+Za790orjqsAOK3s9Wyh0iGEDDVLkB0GhdBPOt7bOJicc5?= =?us-ascii?Q?9t+pqH+Er1os7IiXiir53BmmNbeaDPBMgH1gkMPEm4m+xw6UJRm1j3Z92nLM?= =?us-ascii?Q?a7i4rkUGKkTXTtPSS0Rfirf8tRm2UXmciLsrbKybNp6vjpbHCum0pcJ7se3d?= =?us-ascii?Q?PF89tVJNmXoWk4/DuEn5429xtt6DqOqIc20ET1zfUzn/9HjUAs6fFeE2weGZ?= =?us-ascii?Q?LoTmg9VZ0xqIYkOKd2YKVePqeF/x3+rq/3v6bcWQwDJQEDmzI0JBfXoS2ecP?= =?us-ascii?Q?z/Dxu6Qaw32IfyfV18q0aWkYDlNC/EQEfvVnoTXWmj+rq2Epqi5H9hnrVDr4?= =?us-ascii?Q?Hma5kDmbFYzA5PQSkf6v7uEcNgLnkbMSgeZV8Uir8FayDQuypnyORdBd1K0S?= =?us-ascii?Q?6+tSrwafZtKZHNsG84rYEADgKsxx9?= X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1878; 6:8+W9f96wohFVr1EIt8ICmCvy6o/yxlSIXbQJl8HLMHwNMz7Yracr90uc1o7BQdLzvJVn3RhqHeFxntjTODl5CNq0Um6HkcveZvn9pfllXDD6JB/JRk5oeaba0XKY5ASrI0v20Qw1hvOdAdnEX61SOPIvMFtPnCAEJQMzoHjpuTL5Y1ukDb6qr9afGPrLVLmwACjwnTCgklpKI3SnRQITSq+P4TED6Hsq6Uvuc1E5ZR2qJSpFk5lsTnhq2sFoFAOD/vFDNx1GjKRjazQonlSLVdnEQC3d6ttaMKzmkF5/cy4PAGROOto1dhGPqb2o7Um80BvMyBOrkDKbkqq1u1OkeA7agqhhe5xqoVSa7/pUfV/xBzX9Fm/TiUMOMtZ1zDmexOeDYRF4v4/Jp8NnKHaAUufQtYkfvTpbbIL6zz1peCI5DoJFVt/JZWRNAL40NSahgQ0dSKrfSPML3pQW5W9DcN9FjuHR88adE7st1uqglSeykTQKGzFjfqMgCmH+ZHITe4m5dFwQOuuvhjrI99bIEH558MbfsfT9lapMJ+h1zhc=; 5:tl/NB3XtiyYWrkct2xJv6K3ujTzqQAC7PPmJDDxZV1z7DvcyBYQaqmGso/Ow1uf20/8POYtbTGM8oSXRUSD3W/aJnhLXmswKqz/66R5aGvOXIlzNNB9IMBctqvFi5kBFhOXn50izHupe1mfpdPkjkg==; 24:m4ISN92GP54kXQJ/AX6z6DkzUTp+6xDj1nBFUqnnMlS9UvkOLDNaUDeBvfBlwrG1r2z06IL8gp+LQoPrl+Cn8kY3XQlyxVL+HbAj1MFx2HI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1878; 7:fE92e38G6HExG+ph80SB3DKrC12hmwVJOKTS34btU0XdO1zX7ceFZ5WVWWvCtwwmdQ4fwaK3JFJ+U3SD4AHyGwmP3hWyxW4/nEhkdb6qlf/uBJxq8FFYL4hYzEXTyQczq4kW1Nkl5vfcPH48WQh0LpZTeC/Wj23hOnaSjSSJVlF9NTa1M3UrESiNk1vQuPiZn93ElESDv26zHYpRTrNINt9uiKQre+ijghbO6y33KR37TwByafijnXqRLgRJUBUCLfpXcWkUy3TZWRjL2sM/vPjEBDeeS20JP/SFa300/WX0exPzYxWrgYyTW4i61Xe+QJkZiZJUaIFUcSVhZL9DZQ==; 20:omE/RMMto/RQXfNuhphv8RolebILodk817QvgV7r2gUZfc6apPF23aTFa9g22VmA0qsM6rIm/XPv6Rrb48u38uKTkdYv0NLk1ig7FlUAzUrgZFmaP0PVbo8x79a6SUe5JnyjIPOZYuH2iF958MGXFSiShoo2HMv8afh5lkPlIH8= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2017 01:48:24.7726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1878 Cc: linux-renesas-soc@vger.kernel.org, Linux-ALSA , Simon , Hiroyuki Yokoyama Subject: [alsa-devel] [PATCH] ASoC: rsnd: don't call free_irq() on Parent SSI X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto If SSI uses shared pin, some SSI will be used as parent SSI. Then, normal SSI's remove and Parent SSI's remove (these are same SSI) will be called when unbind or remove timing. In this case, free_irq() will be called twice. This patch solve this issue. Signed-off-by: Kuninori Morimoto Tested-by: Hiroyuki Yokoyama Reported-by: Hiroyuki Yokoyama --- sound/soc/sh/rcar/ssi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 5960042..e23fcab 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -726,6 +726,11 @@ static int rsnd_ssi_dma_remove(struct rsnd_mod *mod, struct rsnd_priv *priv) { struct rsnd_ssi *ssi = rsnd_mod_to_ssi(mod); + struct rsnd_mod *ssi_parent_mod = rsnd_io_to_mod_ssip(io); + + /* Do nothing for SSI parent mod */ + if (ssi_parent_mod == mod) + return 0; /* PIO will request IRQ again */ free_irq(ssi->irq, mod);