diff mbox

ASoC: rsnd: add missing dev_dbg() in rsnd_bset()

Message ID 87d2cmuiin.wl%kuninori.morimoto.gx@gmail.com (mailing list archive)
State Accepted
Commit 4f8f86aa41232cc4595136f18013324482fdf749
Headers show

Commit Message

Kuninori Morimoto July 31, 2014, 6:52 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

b8c637864a6904a9ba8e0df556d5bdf9f26b2c54
(ASoC: rsnd: use regmap_mmio instead of original regmap bus)
used regmap_mmio and modified dev_dbg() for rsnd_read/write().
But rsnd_bset() is missing it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/sh/rcar/gen.c |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Mark Brown July 31, 2014, 7:37 p.m. UTC | #1 
On Wed, Jul 30, 2014 at 11:52:50PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> b8c637864a6904a9ba8e0df556d5bdf9f26b2c54
> (ASoC: rsnd: use regmap_mmio instead of original regmap bus)
> used regmap_mmio and modified dev_dbg() for rsnd_read/write().
> But rsnd_bset() is missing it.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c
index 5db0557..3fdf3be 100644
--- a/sound/soc/sh/rcar/gen.c
+++ b/sound/soc/sh/rcar/gen.c
@@ -92,6 +92,7 @@  void rsnd_write(struct rsnd_priv *priv,
 void rsnd_bset(struct rsnd_priv *priv, struct rsnd_mod *mod,
 	       enum rsnd_reg reg, u32 mask, u32 data)
 {
+	struct device *dev = rsnd_priv_to_dev(priv);
 	struct rsnd_gen *gen = rsnd_priv_to_gen(priv);
 
 	if (!rsnd_is_accessible_reg(priv, gen, reg))
@@ -99,6 +100,9 @@  void rsnd_bset(struct rsnd_priv *priv, struct rsnd_mod *mod,
 
 	regmap_fields_update_bits(gen->regs[reg], rsnd_mod_id(mod),
 				  mask, data);
+
+	dev_dbg(dev, "b %s - 0x%04d : %08x/%08x\n",
+		rsnd_mod_name(mod), reg, data, mask);
 }
 
 #define rsnd_gen_regmap_init(priv, id_size, reg_id, conf)		\