From patchwork Thu Apr 27 05:22:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9702369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 80D11602CC for ; Thu, 27 Apr 2017 05:23:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6FE48285EB for ; Thu, 27 Apr 2017 05:23:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6287628606; Thu, 27 Apr 2017 05:23:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42ED5285EE for ; Thu, 27 Apr 2017 05:23:10 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D5CDA267176; Thu, 27 Apr 2017 07:23:08 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 5D3DF26717B; Thu, 27 Apr 2017 07:23:07 +0200 (CEST) Received: from relmlie4.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa0.perex.cz (Postfix) with ESMTP id DDD522668B2 for ; Thu, 27 Apr 2017 07:22:58 +0200 (CEST) Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie4.idc.renesas.com with ESMTP; 27 Apr 2017 14:22:53 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id 336E466ACA; Thu, 27 Apr 2017 14:22:53 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.37,257,1488812400"; d="scan'208";a="241068956" Received: from mail-os2jpn01lp0144.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.144]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 27 Apr 2017 14:22:52 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hJVT5I3A3DXfq/7PkrllZIPf8j/s26NxwlRK7VaEuA4=; b=cmjP9IiozUEM76XWINkD9WXBMWRnGpI5HjaS4QZBUU4sBsL07T1lBF3HclSzIxdf2CHm/msrygFSJbZQ0BEThZHeEJcd01bBeknH9+WWxafbaFMPBQ1EQ7bGVDrVdCq4SF+df1Xxoteiq0HP5J7R1EOKbuwwlvz/HVrcI6RKblM= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by TY1PR06MB0831.apcprd06.prod.outlook.com (10.163.245.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Thu, 27 Apr 2017 05:22:51 +0000 Message-ID: <87efweqvh3.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Thu, 27 Apr 2017 05:22:51 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TYXPR0101CA0034.jpnprd01.prod.outlook.com (10.168.40.172) To TY1PR06MB0831.apcprd06.prod.outlook.com (10.163.245.25) X-MS-Office365-Filtering-Correlation-Id: 85e80318-6dc6-44fc-4755-08d48d2d7372 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:TY1PR06MB0831; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0831; 3:DB25vAvBCNy3msyC214Byw08r/ojwzzZKQH0BrLFeD0YBdnStnavYoJgIeuN+3Iq3+GR6zE9JPMsuA0A85qY1LHMR1BqjoqC0SImtxcw+fMHfy8wEPMP9Q8ptMkrXr79iPlKKkPiqWhZExx83yyabRNZSwnAl0TDYSuwsX/Cf9Ysp+2ryxgYDDdoq6p2w+yKds4THiAcbF2dwLeInhNJrLteRMDkGnDUG+pC6Hn9ayRIrjzqHV27fUJx5imylZXr7Gi+P/QXggZVt1UrQ0ZXUxEW2m/YM6xGRcyWEL2HaZgbQsNiMAsFxOmAEo409v8c6xlVBPCTQtPQd7C4GTyYsoQk1nlFpz2PRfnBqYCNCSs=; 25:LpSbk8lCcG4uvz+F4+WEhfJpJnHXEu/EkWNpmXKKEFHAtK0P/+oxqLy4lVtRftiPopzfpBOrb+Jz+ZGY159cZyveAqpZ20WKAHqIj2Hhd2xLwWPHUavW4YbBmS7UYurHRnnUVWIPEcXe6GM9pQlw+YyhAMLi3DKseAGj3b9nvSv00Gu0OSwkOtJRmYxd7dv5SfkGMnGeQnEjVPKMQTNSgGPFPefxfGoO5iFBc/fxBDnUO+x57jSdBBsOHgLO45aQirwG+KVLulsSt+iLHGGyMuTflprB1q2Etom04NUsBpGSmAvlBQjDKW4MLgFa4oho31Sc/RgNqIYACteikg9Siqe/SAe6DV7UWI2M35JxLZH2SYzfdgz1fN0OAQ4pqQ8LgwZkMymVxHr1BzuKRtX/o59aZDHbkv/XVGQku2BApoNmqTYSFmuc8FX3BvoXWVxsrDU20Ysn2c4gjKpuIyiCPQ== X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0831; 31:3J+PgzvtDQHcR8uombDJkBalslqKirSRGVbwa8I/8Mnkqrys1Dtqs0TUhU7cN4nHpel4GCe3vcBXkmhEnHdKFX6gl3puL+RFpeCVfz2mPqt+hsjjfXPTjCwm33lCgj7/wMaW2jrDCBg/OMlX6KHjv2DdgbagVPw0YYjCg4lQb09f4Qg4eM+bEPLq6Menew2kbIRvS2RNwRiy9VxuX4bRkAYxnZp7xWiviXBbIhqKVrg0stEXWQsj06J6Ldx2qhNOZtRS2VmZxcTd+cd/vmp7Ow==; 20:ZAwa/T77U1kSK4xiKB8dSTxXPeWOASxqZRDB6pUBP6P+OgLGpyzxVvrSyOcWqazpFtOmhuJxlyjW7WEOPmb9SIczxL7R7KtzEodrqfIB0/OVVTqp87OBluih+UBmmzSGandIMJQ1UCTaFpF7WWxpGcUDfypeNpFYPbWVNmP2Zd8TOMiqXvv5M5Ayxm9Qj8PJ1dWxpByDFuE0TJKTeNmJ56buJTnOXdV+BojEBer81hDgcxhV5Nn+IETlxqTcd8ae1vS0D0gSMkvsJoaSqox1H5xL02nOSO/ZPTjSdtp9n1Yc8QJwGlq+uBnKnwpT4G09aIZoA5Tr9gi+YyRTeGtLcjNja52OQGDPqjSyGcrN5i1e/OXp/cuy40qeVYuqVnZai6d6HII8K8XG2KgxW6zrE2827+RE3UfJhRtrfusDF1VOhgw0bWykIMSE6pVcrIVedA38Nfy/KWF+MTRiAUhf+lfpK6YlthetvmIczWNfcwhZR1hpfhXgMta1tSwH/i48 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:TY1PR06MB0831; BCL:0; PCL:0; RULEID:; SRVR:TY1PR06MB0831; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0831; 4:2wl/5bkRmZalC920iyky7iiSOLYAVVD60UL37Ep80QGghJi4omeEQLPfrkPgxYKdCGTsllqKVg+PpdXL8gtNp3gX4mkk0iQ8gcWzKLQTYa1lvIhFEqGyI0BtASGoBIr7LUqq7a7M6+62Yiqufc/ATwdFkeT+8lCOhCI6HcregyeWFxAqe/Nbc0jfzmEdVL3Pt2JVNJ6YkGbBaqtglGensueIYSwt628QO589ZlmRkJA24z6RdDJYASFjRuuc99Rxh24uelsm3yYs1CPau37KvD+V0nbD5t1hbYSk1iaXFPs+8wawOlBtY2/vw0jRSRQkvN1dlaBx+AUhZ1G915t8zih9f+SKH5alN7zKQN61/vnF2nRgKbfkyTafKLXrbkDXvOQzoPDCLQ1hLGnq/60rEsWP9yPgM3PAeQwQ3yV7U6wC+2ac1JLeYzbVS64G4SqIb40EdzZh3A6MA9GIqY3mEJHDhq/U97AdO1fhsKTR+BaSzEhdUwEkJ8N7Aao4H3Uqeqf7eYix79cR8uRLdowcZ+FFBa09oEvyx2DbOLKk9m0TnNMOcvnC67XxELz3xNEglmXTpaQd0AcEcdCpxE9kHx1lXFI0dg0oH+iqILMGTGEqz2KwQqB9vTaXv/ktHUpOWX+i7Z8twIoImR033ldu0o6PrjcxPwWw7Zr1FJxEUTVPnzpuaRhasDSpJfPHLL75rP1umwMtLX3FRbtZeSlBJqJwgprH3ZeYXx415kcvH8Q= X-Forefront-PRVS: 029097202E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39860400002)(39410400002)(39400400002)(39450400003)(39850400002)(39840400002)(6486002)(53936002)(5660300001)(42186005)(54906002)(53416004)(36756003)(47776003)(6916009)(7736002)(66066001)(81166006)(33646002)(8676002)(305945005)(86362001)(2906002)(189998001)(83506001)(6116002)(23726003)(3846002)(4001350100001)(54356999)(50986999)(25786009)(4326008)(110136004)(38730400002)(46406003)(50466002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0831; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0831; 23:cQpsiTqoqqT/91UijyYZcGLTlbI5N4T2YHTiqPki1?= =?us-ascii?Q?Q9ommbrrX8PpGKjURq9Rz6vfnDWVGSyCqTzItoxyGtuXJu9/FeeoZrUXq++e?= =?us-ascii?Q?KgW/l9kjm2SxDpdlj+oiDC0YnGU5VeK9HyXKdoSgfvtP9VxSZZmePSVF0NKk?= =?us-ascii?Q?fYBF05jwExP0NnLfvMdGpOB1V54eKpnee6befV88wATUmIcS54BZ6xp2QHlC?= =?us-ascii?Q?t8fECnkBYk9F6VykuIHa8wQGwO2FDr8UDdknGkOMNInpvqhmA/VGx0+vqnVN?= =?us-ascii?Q?CDyFvcAeBbcndWI4U5ARgd9IYy3POq4b2fFOBeiQYpkNMo43jxlBhxG5YPAd?= =?us-ascii?Q?S+7NH8HXbkKm4wDroowl2CxA/VHGKMpYXkCTm7YwiNKINgU4TjSOVKtcm4Gw?= =?us-ascii?Q?/eTuggO9gIF1+81BtrHyBpnjhVR2lqUm9qC3ECL7vvPXJq4/i701x0RlMFfi?= =?us-ascii?Q?u/OyvgID9VnxyJhRQrvsLk1j5PEYXZTGDv8T/sHwXr4WTZCgf2Fm+N4coF9W?= =?us-ascii?Q?upNBY5M89rL1iHdGrXztdz9dSl5gZF80jPBoCBKMwwCKEWQN/rhwmhb+CIwq?= =?us-ascii?Q?LanWlpwx/G/QvIV0k4zd3/Z7TpidBiEqVCkMQqpGGn0MASQ7IzSeeSC9RPYs?= =?us-ascii?Q?fSIBIoukf62iqAnF406GxpFi0dwajV2ref2k8sDYZwbexNhE9JsmMPdFzb2K?= =?us-ascii?Q?xImpoliM1FnHIbmz1a2CnlmABNPGmMH42P3uUgzJSQCyKnp9jz4bxK7tp2M6?= =?us-ascii?Q?ZVvxLqABdWwljoqNLQ4d+LDuLdyruqcqFG3/mzI0cPD1LGMzcrUjWjqmKVf9?= =?us-ascii?Q?wMM0OglUEYp9tNfDj+/GwY6UyIbowvX+XmpPbT+2jJi/g5TV/iT6I4ePNG8V?= =?us-ascii?Q?8Id3++168fSFC04sux8p3xqhV+jSMMDAXumEnLmXR8pCn6CrYQAaHh0UJp2c?= =?us-ascii?Q?TuRmOBVrUOiTfrXbb+jyh3aJ+mK642URAqkXk3Vj7L7eAPeDPi8ZaUwd8gTz?= =?us-ascii?Q?fx7O+7mXApye7KihZJaRiGjOW32SZw3m1fOozRuxTAE5g=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0831; 6:ah6hyAvh6cVYJZ+0ju+Jv2l5vypFzSI/iziNz8aQCJ+jw7QhWqQBfNX6waViq6Ie6mCbpBp6PEzo5iICd0NDdTEB7wyklTzUMgay4T5qYV/sT4mODpV9rqZ1sEwdl8NHedUcIwLXXh8GKRJCp+K5BhU9DImI0mrFqY7aLq0Q5U1cSFl5pi3eIxp70ejh72lhGzfGXAL5uBSDDQxhJcm+EY69HxWNdtYt+8BvesF7Bre+OcoIu3HMMimj97nm1+32b4eyz2CSQU0tyUzXs9aMnfR5u8rCJLSlK52MpaK0MXPpoqMg2+KcHjwpfqCVxx6UfqCgZJx3cQkROsyZM3jzDdG1IwqU/hjwPxO9zxHXURvSwrh83bEXtbpiKl4yayoP5LJ6aOvgcFKd+mFrYRgebpCOn6NsqZqXpblygcBNn0fwUYFQ9SMsJIDWx6xp1HAeBZh2RRczgt2gnmkYIG5Bs9CdXTKbHCa36S8Mkmy4dXinoCYTHl+3JmornyUnM2Z6Q9VxM14YyECvUCktZCRDW7IR5h0T4mxe7AJ4eQvH560=; 5:csCMP5yZcw3Ozkvd6klTmUSwkIkZoGIzhVZKFZlMP6cRmOMTQ/hUj4GbdhbN9A2u36yaAZdvYj4n+9NxIl0YjpQSaa4sjIKYOKLjmRphNJwZVEmlSdjb4KW3Sw8fxAFZVFqB5yk8I1F9lkRf78DopQ==; 24:KlYv8EyUKc7WROyhjbqvzdbVAEd8SWeC7FZwCnTRWeXRRTrgeqtKKNN3Dh4cQfWZvg8UiFGZnDuZA4WXLe1vc5BzgkvfG8t9v6UDSRn1r90= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0831; 7:CN3SbHxrMkg/mGg8fv4eJ17sWtF19mfkZPYGsT1wJ/tw6u/9LsfdGGk/2YpKDvo3IlMiq7tsCVtO0iKp36sf0khC4A0URirPqWxapWlgH5pEi8s0pu6wiKVaGvkwABFXQO1yRxdB6gRROe9JqkPqF8ex59Gg41qNsGJ7HKd9VbZ7pX32VukhX6pnmrEtzdUfTANTU+Zr6ry3be+W6sQd2So8nB7LBBIY2mMg8uA1PZocfcz47rSBlbLe8EGwlxnxhhUP7bn/G6nIS8mmfmmoWOHlsH1oZnlA445dAJ/F7BeHVEY0tmsEp4u0uVAksRaT2tCi1YuSR6cY7tfkZQ/lTQ==; 20:8w2uZXUrtv0R/3vCySfStmOELW66BxOONl7A67UzakHJzqkBl/YV/CG/DWB18eIjB2qNdrhC+hDOoWwfznXrqP+8YBf5UvIENHtiTsbTHcKDMRV4UoDYvTTRLSvrwU8k1owJELy+6Cs9LW6pCCYrYiF91LDkMeuboTMJBychV7I= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2017 05:22:51.4925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0831 Cc: linux-renesas-soc@vger.kernel.org, Linux-ALSA , Simon Subject: [alsa-devel] [PATCH] ASoC: ak4613: disable asymmetric audio interface format X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Asymmetric audio interface formats exist in ak4613 by same register settings. Capture Playback 24bit LEFT_J 16bit RIGHT_J 24bit LEFT_J 20bit RIGHT_J 24bit LEFT_J 24bit RIGHT_J 24bit LEFT_J 24bit LEFT_J 24bit I2S 24bit I2S These asymmetric formats makes driver / behavior difficult. It is not HW limitation, but SW limitation. To makes code reading easy, this patch doesn't remove code, but just comment out. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/ak4613.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/ak4613.c b/sound/soc/codecs/ak4613.c index b2dfdde..9d2be7c 100644 --- a/sound/soc/codecs/ak4613.c +++ b/sound/soc/codecs/ak4613.c @@ -139,9 +139,9 @@ struct ak4613_priv { #define AUDIO_IFACE(b, fmt) { b, SND_SOC_DAIFMT_##fmt } static const struct ak4613_interface ak4613_iface[] = { /* capture */ /* playback */ - [0] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(16, RIGHT_J) }, - [1] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(20, RIGHT_J) }, - [2] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, RIGHT_J) }, +/* [0] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(16, RIGHT_J) }, */ +/* [1] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(20, RIGHT_J) }, */ +/* [2] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, RIGHT_J) }, */ [3] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, LEFT_J) }, [4] = { AUDIO_IFACE(24, I2S), AUDIO_IFACE(24, I2S) }, }; @@ -262,7 +262,7 @@ static int ak4613_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) fmt &= SND_SOC_DAIFMT_FORMAT_MASK; switch (fmt) { - case SND_SOC_DAIFMT_RIGHT_J: +/* case SND_SOC_DAIFMT_RIGHT_J:*/ case SND_SOC_DAIFMT_LEFT_J: case SND_SOC_DAIFMT_I2S: priv->fmt = fmt; @@ -420,7 +420,7 @@ static int ak4613_set_bias_level(struct snd_soc_codec *codec, SNDRV_PCM_RATE_96000 |\ SNDRV_PCM_RATE_176400 |\ SNDRV_PCM_RATE_192000) -#define AK4613_PCM_FMTBIT (SNDRV_PCM_FMTBIT_S16_LE |\ +#define AK4613_PCM_FMTBIT (/*SNDRV_PCM_FMTBIT_S16_LE |*/ \ SNDRV_PCM_FMTBIT_S24_LE) static struct snd_soc_dai_driver ak4613_dai = {