From patchwork Tue Nov 6 04:36:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10669615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C873A13AD for ; Tue, 6 Nov 2018 04:37:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B61F62923F for ; Tue, 6 Nov 2018 04:37:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AA3F529264; Tue, 6 Nov 2018 04:37:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1F9F2923F for ; Tue, 6 Nov 2018 04:37:03 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E2F28267A66; Tue, 6 Nov 2018 05:37:02 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C71B1267A6C; Tue, 6 Nov 2018 05:37:00 +0100 (CET) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-ty1jpn01on0111.outbound.protection.outlook.com [104.47.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id BDC50267A5C for ; Tue, 6 Nov 2018 05:36:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdlQ3BrzfMbYC5j4R/kzYlgxhAtPurjziEmxlCOo0gY=; b=NhleMePopHohrmWYkfDa5jQNY5b57uvGtiPFQQMEJYCXVxaIEdGFNQbGM1vbOplZe4TOpqDgssX1AtOnsEfF4sCYJVV17fyTEhHkNLWaFowNrasexnwfsbcT4+nT5bi5dc0UM8NfB6LSCn7y6GcFvPXmsHvCow6Xr3SzsMzXsWQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.130) by OSBPR01MB3318.jpnprd01.prod.outlook.com (2603:1096:604:2e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Tue, 6 Nov 2018 04:36:55 +0000 Message-ID: <87h8gux221.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown In-Reply-To: <87lg66x23x.wl-kuninori.morimoto.gx@renesas.com> References: <87lg66x23x.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Tue, 6 Nov 2018 04:36:55 +0000 X-Originating-IP: [211.11.155.130] X-ClientProxiedBy: TY2PR04CA0010.apcprd04.prod.outlook.com (2603:1096:404:f6::22) To OSBPR01MB3318.jpnprd01.prod.outlook.com (2603:1096:604:2e::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24c04e79-8297-4048-bab2-08d643a17b53 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:OSBPR01MB3318; X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB3318; 3:ljvoBgypu0wkoiHkVjOd2gsSfWd/sskX4//YoXdSlgtle7+myoEMA/XW1L9+hkGvzJINeXqDlUP8JbaYZQC0VFP4hTRAixp1Ue+wzcRuhRR9oBFvxYN1HOiKk6lWvmhDCchRpZaGsnisTZxcChBsQZeVGIVnGQAeP1gnyhCDX563ZLNfuhmbXWCgzetC4YqOFo/0N6j5Fd6zGnYYxAygr9yQd7opaS5u5PQQAOu3Fb7cKI8aFixMJ31jBfW43ojV; 25:3at3At4W2jsKJPtRnNlzMOafIzNq6BpeMR4FbpkiDlkY2rocLsbjPTNC8xR4Z3j9Avf19/b5NSeZlx1poknjX1gtXEtcm/DI3NfVTFICbrwjuWNG96ekqWJg3cGckIMPpz5TzNOLKCtXTV+aXzWxeiQjKgIqEUvg/AwPt4b3oC0deFSZ4hUciDeZaKxBIE4TJ6GeZ2meMR1izqxmiZSYE8uT/xHcao6cBMufe8tkiZt9XJUoYyI0rfQR59qIZIQNxoBOPr02FzvlWf/6LrSy0YUCv9jDJKYt8xwsDAzByadF1eQoIJfkRnsr7W4KqTlZy5Ze2EJIohVlecqhWg2K1g==; 31:4MktjKQuwoPC18rSrpwfRuNnXsKD9puMY3LQUlH7ssznijsSOeJ4+nAYBQXtjMh2kdWmtFMFbK+j9OQaPpQeAcbEYmaEM95rgXclsY2Ko8BlNgTHcJlWc1pYss21ya9GUv6Dax/0hXdA+TAUheMCPu/x7Iw0/0BpTVgezdMxdINcYyIeFTQMmbPa4YL0m9SXjnTL7kvtP3V8tFybchaalZDwg9Z0BDm0JvAEQNzVwAo= X-MS-TrafficTypeDiagnostic: OSBPR01MB3318: X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB3318; 20:Cg4k28w0fkKtIjJrbHEbpW1BCOOL/l64j4DIZ4BtbY9XhbEKzqx9ufLF8YVt6lKQVg2Ipp/2lMB6ySePXT1Q8ddoNdGt4qrvQIxyf2J1zt2NB9lXAceQTMMnkDB1CDgCvM3UmD46UvH/22tkl8nucrU04GmZNhmlURwONrs87zkpeXMsv2pCNe0IItlzBeRz7rPhgCcrQhK3VVEaikXayrA7KOfaDY7F6+j/cjRRi519OlmzAyCZ7P7YuMxpwV8JzdYS9ck5n9IgHlyjJ7/1SJCAU+yFGPpg165jKJyFkLxP74V5b0+DuUEqnwgRnKmXI3FANgRvHgiP8CWxUtc7ycnf3z3YQrY3K+VRetZykAuEuGURINsuZJdkKO5XuPoHI282DvxjICpZE6CBb7STrRKqgX5CTSHDSEGljwit3z2laG2RRtY4VAW4AutlrDGtOORB8v0h41SIqTgOJoWqi+77KWkCGvydyH+bgQExJ5Z3cMYgP9PqpCfbTllN0X30; 4:lmYXQlpefdFaUWIfcMZ9QcCJ3wgh7wZk/hMrgfUv/Dptm5vVQd/+vAH0qa5ingd5f0b84Wd/9x0nWFbzekHE5PGK44r62ey3Cs6tc0924nZU6J7OggUmm22WQY/U4r058mR7lY149pzybs/vr8uqECTvewzeQlTnjNGYZYE+RUzC8lBF87DOOj7pA0ohbX2ZmDUf7L2Pzu+b6NEzeJvMh2nUmTYtJIZdHjUUh54OrR2LaR+wdcFFjbqMaFiJA3HNMtdMd37mB1JbJ1axQGoE3Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:OSBPR01MB3318; BCL:0; PCL:0; RULEID:; SRVR:OSBPR01MB3318; X-Forefront-PRVS: 0848C1A6AA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(396003)(136003)(376002)(346002)(189003)(199004)(53936002)(6916009)(478600001)(25786009)(4326008)(97736004)(69596002)(23726003)(66066001)(2906002)(6116002)(3846002)(47776003)(50466002)(8936002)(36756003)(11346002)(446003)(53416004)(316002)(5660300001)(86362001)(58126008)(575784001)(68736007)(16586007)(2616005)(956004)(486006)(386003)(476003)(52116002)(16526019)(7696005)(76176011)(26005)(186003)(106356001)(7736002)(305945005)(6486002)(81156014)(81166006)(8676002)(105586002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:OSBPR01MB3318; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OSBPR01MB3318; 23:QUZ6dXpbtoy/U2LjpwO2WQO9YSxxEEYAWmvRDngD1?= XPeZLmiUsCNUM5FrmK6+o5wakx+wu/4Hsgnwdp0J4VG9XdjYauDeS3lKpvjujk/w5RrPf6r6HKA+Ul3FKujlLvy61Vnokiw8jg2mk81Pd7RziWIglX72R9/OfcH35q8dsHGhoHx4N1wVYBCrazBalGz6+Ag2zFyjrNE8HweYv1ZfJNvTBRUZe+85xHU4L49vwrTPy5RVVTP/3GbTlett0FBw/rLobnY4DS8yxg37RkstJBnIXsdmvxkZkYMGLjCYtatwMB5E4RkhG3gnDyRMg1E1qbkkeErDfWWLKNOAVnYFKeiW3GUwj8e3PMYtL0j/m0lw47nty4ot44cRQLk5WO7NjfoWpvbWo9Ir4GJKeKZ/1TSYHEYKaOqLe2de9AyBBsL5MwhYpl8NVkJH5GAmeBqlp6SEKdaih0PuL7mki28wYKyZGcw9KBTmQ8Aulk3eGURDT9HejxhO6Taa0TrxX65vBZQn556VHEbwQUUDAHUDphpfXQdf+kGTNHBmwDqnK8mZNIYAC6iFXFOclCi447XoNMNYZQLCvxgy7EOY4uFObCpXo5LOFHou/Y4urJwMwevvrKBdqHFWGJ66aZeOzz4A7ZB/3+qB4imY5n+scPpAnJ47GoFMG1zf/5s25R9XBrPOAoizzkjzJk/xvUXGvsezT1hdyvUwD5LFtqjKmNVhlnAVZhsS5u9QuuSyYkXqN+AE0QXmHE/1d0ZY+y/NJQmv+EYbfhx1/JnBv8XtCji+AEMofcxQiXnES3BUljHYcuPZQOZYdAx/rzvRMFrVO76vU/BNDFAKut6tU7ExpGhZ8XqeD22ms/X46RozFQGCODPIcb6e8nP3qAV5X7JVWMqfEKI1iYUpVW+1M3DaN142eN/c2Tvo877R24YyyMQj78qFp8LYlJvr6Sr3DcVULSJlFMHjyqUmeSR0LVpHRPaODL9GWaoQLd752JPtV/vxLZS8119j8toZg9uj3Lhmj29os0cvZ5Z3LO0EpFbtVaGHZiuBWzfpe5USbE8wX4vIhZ9BG6iQo5/mg5wRP8fYl3S/K2taqC1rDFAM6+xw/6HQ2s/zaFwVsXvsmzynveA+bhZEVV++qAvY62A+JMAYnr0LRV641lfS8FwyZtowrmyxmbGYkYaeTlC4Y+qt4ybzGLKYlJFktsLY5jtM6xUrsZ7 X-Microsoft-Antispam-Message-Info: 8IGHvP2gxH2RIRm9Y+Q2bLcZkYQyij6w5ZvbKkZKkPs1jNKkCMyyTrMhtgmE9QMeHZn2uxXoOG23GjkNbpWnkrUJYqkGqfnyiCnrpdiX5UmuIEe2qgRuPYJi4DfCV80aFnNYl/m0KjcRQmU3lp1o7jPTyQEZF11UKDCJWnm4ppU7f3zL73F1sUsiI2ez6dk+Uu8KA1a2Vh3tYAieeUDv81Oxui7UawE94g4YaNckC9YPMSQ6Jy5A9eAAkdbILym4STwWHyDrr5SfJoH3/ia3rAZw1DSZ51RuLQwU4fbQrMcRNoJRM2p1RDs9oo1IOqxr4ZEiT+PMh+LM2O1w4mELNRqcWtztDpONh9z9VFklDuk= X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB3318; 6:ByhUkWghQbJV7Yg5t9/DvfgREjt36JYjBvOwfEZuORaDgRHFuSqnStv8WoEV+W7PENyKKpXiHMFYmhT8eyuJZv/Xy+zbegHvAX/QL0Nmm8veRFvD6RJLxq6VIiP2xKm2rQxvPv8MxDRbwKQDB3KpdpDuse3++i918rQrcXgkCNebpwhmbXjGPAqLOJ64zqR3me0uHAECsnDyuXacoRUL66HMAZSRu6sRQhVM4GDDkaEap/5QoJdRGz/+7zsLpgnv/sO5q5tgQcLS66c5ECedztVDhd1o04b4lBfffy5LZcFSGnyo3aGOiydfH8GmTAKDgzD0ZBhnln+C1Dtap8SPUI1clmZ1P/4F4boxkyT0UXP+mHeO2yGDPLa3YKSp9W6ymRKf8HZObl6YUVbUp6xO7VI15m1YV53pbuQMu6K9AhWpG6AXKMqg6q/RqoC5uyqk1eEqV0cgAxAT3j7at9lOsg==; 5:29ZKwKXTph4JVJUQrD2AfUvdsjoRVqnFKEM+WzN/dGDhyfIKh5W3pjU2gJdPXvWg4mp8yr613t24Z3RKKaXipXlHs6/6IUU7wL8kMsKq7oMZ5VH19W3QG+TX0Y8JrhAHvCFrfPQsXtZA3qPwDae2S0kqX/e8Sxw4k76ZpBDJuho=; 7:E9dJ37J0CO0WF1WLOVfioLY8tB6xNF7aYddE1oaEUvTsoc0W2wfU8+qLQcrRQS/5/heujUJl3SxraVWOKQ2kapVYWObLYrCR+9g++P/4RFeWwIQmg7JMxiO5mZUvUBl+wj7caKbbBvmGB1wvZyK03A== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB3318; 20:0QEdkHZ53qfYeRnbIjGdCU/opPfzPF+tpHAOYlLa488nxtiXTbFn+TR8G1CiEQsmSodkfliuYNPhDRKHQd8hdo+S4dQBFCr4ArIxpnE7B4gnzr/w+7LsEB1+GiT27tDtDet/IBApuWOf/6ns5qyhY/mxWKF2qjIcJi8ui+TfMvU= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2018 04:36:55.6603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24c04e79-8297-4048-bab2-08d643a17b53 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB3318 Cc: Linux-ALSA Subject: [alsa-devel] [PATCH 3/3] ASoC: audio-graph-scu-card: remove error check which never happen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Current driver is checking situation that can not happen. This patch removes over-kill check Signed-off-by: Kuninori Morimoto --- sound/soc/generic/audio-graph-scu-card.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c index ba7b0cf..2ba35bd 100644 --- a/sound/soc/generic/audio-graph-scu-card.c +++ b/sound/soc/generic/audio-graph-scu-card.c @@ -250,9 +250,6 @@ static int asoc_graph_card_parse_of(struct graph_card_data *priv) of_node_put(codec_port); if (codec) { - if (!codec_port) - continue; - if (codec_port_old == codec_port) continue; @@ -308,11 +305,7 @@ static int asoc_graph_get_dais_count(struct device *dev) of_node_put(codec_ep); of_node_put(codec_port); - if (cpu_ep) - count++; - - if (!codec_port) - continue; + count++; if (codec_port_old == codec_port) continue;